ecosystem refactor part 4: react native edition #4783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 944d56f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
This was referenced Sep 24, 2024
joaquim-verges
requested review from
gregfromstl,
MananTank,
jnsdls and
edwardysun
as code owners
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4783 +/- ##
=======================================
Coverage 49.12% 49.12%
=======================================
Files 1051 1051
Lines 56670 56679 +9
Branches 3887 3888 +1
=======================================
+ Hits 27840 27846 +6
- Misses 28197 28200 +3
Partials 633 633
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
force-pushed
the
09-24-ecosystem_refactor_part_4_react_native_edition
branch
from
24540fc
to
b1ca8b6
Compare
joaquim-verges
force-pushed
the
09-24-ecosystem_refactor_part_4_react_native_edition
branch
from
b1ca8b6
to
9c420a0
Compare
joaquim-verges
force-pushed
the
09-24-ecosystem_refactor_part_3
branch
from
f4e3ae8
to
702cf8f
Compare
joaquim-verges
force-pushed
the
09-24-ecosystem_refactor_part_4_react_native_edition
branch
2 times, most recently
from
a692ebd
to
214f948
Compare
gregfromstl
approved these changes
Sep 24, 2024
| storage, | ||
| }: { | ||
| storedToken: AuthStoredTokenWithCookieReturnType["storedToken"]; | ||
| client: ThirdwebClient; | ||
| recoveryCode?: string; | ||
| encryptionKey?: string; |
There was a problem hiding this comment.
Do we still want/need this? Prevents custom auth from being used with ecosystem wallets
joaquim-verges
force-pushed
the
09-24-ecosystem_refactor_part_4_react_native_edition
branch
from
214f948
to
ccf3c0a
Compare
joaquim-verges
force-pushed
the
09-24-ecosystem_refactor_part_4_react_native_edition
branch
from
ccf3c0a
to
b8f6d15
Compare
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing wallet functionalities and authentication processes in the `thirdweb` library, particularly for ecosystem wallets in React Native. It introduces new wallet interfaces, updates existing methods, and improves error handling for user authentication.
### Detailed summary
- Removed obsolete `web-wallet.ts.changeset/chilled-dancers-cheer.md` file.
- Added support for ecosystem wallets in `useAutoConnect` hook.
- Updated `createInAppWallet` to include new `createOptions` structure.
- Defined `IWebWallet` interface with methods for wallet setup and user status.
- Expanded `EcosystemWalletCreationOptions` to include authentication options.
- Modified `getUserStatus` to handle user status retrieval with better error logging.
- Updated `InAppWebConnector` to utilize the new wallet interfaces and methods.
- Implemented `ShardedWallet` class with user wallet status and account retrieval.
- Enhanced error handling in the authentication processes across various modules.
- Removed deprecated methods from `native-auth.ts`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
joaquim-verges
force-pushed
the
09-24-ecosystem_refactor_part_3
branch
from
702cf8f
to
1f1f99d
Compare
joaquim-verges
force-pushed
the
09-24-ecosystem_refactor_part_4_react_native_edition
branch
from
b8f6d15
to
944d56f
Compare
graphite-app
bot
deleted the
09-24-ecosystem_refactor_part_4_react_native_edition
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing wallet functionalities in the
thirdwebSDK, particularly for ecosystem wallets, with improvements in authentication processes and the introduction of new wallet interfaces for better integration in both web and native environments.Detailed summary
web-wallet.ts.changeset/chilled-dancers-cheer.md.useAutoConnect.tsto includecreateWallet.ecosystem.tsto addauthoptions increateOptions.IWebWalletinterface inweb-wallet.tsfor wallet methods.EcosystemWalletCreationOptionswith optionalauthproperties.useAutoConnectCoreto accept acreateWalletFnparameter.getUserStatusto log responses and handle errors better.customJwtandauthEndpointfunctions for improved authentication.InAppNativeConnectorand replaced them with new implementations.