-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecosystem wallet refactor (part 2) #4780
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on Graphite |
size-limit report 📦
|
9e56ac8
to
790201e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4780 +/- ##
==========================================
+ Coverage 49.11% 49.15% +0.03%
==========================================
Files 1052 1051 -1
Lines 56786 56700 -86
Branches 3889 3892 +3
==========================================
- Hits 27892 27869 -23
+ Misses 28261 28198 -63
Partials 633 633
*This pull request uses carry forward flags. Click here to find out more.
|
790201e
to
9a88a39
Compare
cb0b69e
to
e02d87b
Compare
9a88a39
to
ca5b8b3
Compare
ca5b8b3
to
131a054
Compare
131a054
to
822a11a
Compare
Merge activity
|
## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the `thirdweb` wallet implementation, specifically enhancing the `in-app` wallet functionality by integrating `localStorage` for authentication and modifying wallet creation methods. ### Detailed summary - Deleted `get-auth-token.ts` and `ecosystem-core.ts`. - Updated wallet creation to use `createInAppWallet`. - Integrated `localStorage` for authentication in multiple files. - Modified `EcosystemWalletCreationOptions` to include `InAppWalletCreationOptions`. - Removed obsolete auth token fetching in various functions. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
822a11a
to
de63195
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on refactoring the wallet creation and authentication process in the
thirdweb
library, specifically enhancing theinApp
wallet functionality and removing theget-auth-token
utility.Detailed summary
get-auth-token.ts
andecosystem-core.ts
.createWallet
to usecreateInAppWallet
.EcosystemWalletCreationOptions
to includeInAppWalletCreationOptions
.getAuthToken
withlocalStorage.getAuthCookie
in multiple files.createInAppWallet
to accept anecosystem
parameter.ecosystem
ID.