Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS selector change in PR #2492 hides the checkbox input when editing a Field:Boolean #2511

Closed
jasongorst opened this issue Feb 9, 2024 · 3 comments · Fixed by #2512
Closed

CSS selector change in PR #2492 hides the checkbox input when editing a Field:Boolean #2511

jasongorst opened this issue Feb 9, 2024 · 3 comments · Fixed by #2512
Labels
bug breakages in functionality that is implemented

Comments

@jasongorst
Copy link
Contributor

In app/assets/stylesheets/administrate/components/_buttons.scss, the change in PR #2492 from

button,
input[type="button"],
input[type="reset"],
input[type="submit"],
.button {

to

button,
input,
.button {

makes these rules apply to all input types, including checkboxes.
@jasongorst jasongorst added the bug breakages in functionality that is implemented label Feb 9, 2024
@nickcharlton
Copy link
Member

Oh, oops.

Do you have any thoughts on what might work, given the linting rules and expected behaviour?

@jasongorst
Copy link
Contributor Author

Do you have any thoughts on what might work, given the linting rules and expected behaviour?

Just the attribute selectors would work,

[type="button"],
[type="reset"],
[type="submit"],

@jasongorst jasongorst mentioned this issue Feb 10, 2024
Merged
@jasongorst
Copy link
Contributor Author

I added a fix in PR #2512.

nickcharlton pushed a commit to jasongorst/administrate that referenced this issue Feb 14, 2024
@jasongorst @nickcharlton
Fix Field::Boolean hidden checkbox regression
46bc465 
In adjusting the styles in thoughtbot#2492, we removed more specific selectors to
pass linting rules. Unfortunately, this broke the situation where you
have a checkbox input when editing a `Field::Boolean`. This adds them
back in, in a linting happy way.

Fixes thoughtbot#2511
nickcharlton pushed a commit that referenced this issue Feb 14, 2024
@jasongorst
Fix Field::Boolean hidden checkbox regression (#2512)
bd5bb08 
In adjusting the styles in #2492, we removed more specific selectors to
pass linting rules. Unfortunately, this broke the situation where you
have a checkbox input when editing a `Field::Boolean`. This adds them
back in, in a linting happy way.

Fixes #2511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug breakages in functionality that is implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix css regression from #2492 jasongorst/administrate
2 participants
@nickcharlton @jasongorst