Fix css regression from #2492 #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongorst
changed the title
In adjusting the styles in thoughtbot#2492, we removed more specific selectors to pass linting rules. Unfortunately, this broke the situation where you have a checkbox input when editing a `Field::Boolean`. This adds them back in, in a linting happy way. Fixes thoughtbot#2511
nickcharlton
force-pushed
the
fix-buttons-scss
branch
from
0278e3d to
46bc465
Compare
|
Thank you! |
|
@nickcharlton is this fix queued for a new release |
|
No, it's a fix for #2492 which is only in v1.0.0.beta. It will go out in a new beta build though, which I should probably get on with! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix app/assets/stylesheets/administrate/components/_buttons.scss while satisfying stylelint. (Fixes Issue #2511.)