Switch to using @thoughtbot/stylelint-config #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to fix GHA, but also when it does run, there's some linting failures as the rules seem to be slightly different and/or maybe broken. I can't tell. |
nickcharlton
added
views-and-styles
|
Over on the stylelint-config repo, I'm trying to bring that up to date and sort things out there … then I can come back to this. |
|
This has been a ten (10) day side quest and I can finally think about sorting out the rules which are now failing. |
nickcharlton
force-pushed
the
nc-switch-to-stylelint
branch
from
566c1c9 to
2f446c7
Compare
In #2397, we're having trouble with ignoring directories using the existing `scss-lint` configuration on Hound. `scss-lint` has been deprecated for a while and we have another configuration based on thoughtbot guides, so this is a good fit. We use BEM style selectors in our CSS. So we add a custom rule, based on some prior work by @a-tokyo, but adjusted to fit in our JSON configuration file. In addition, we disable these rules as they don't make sense on Administrate: * Disable scss/dollar-variable-empty-line-before on variables * Disable function-no-unknown/no-global function names https://github.com/thoughtbot/stylelint-config sds/scss-lint@4ac76f9 humanmade/coding-standards#193 (comment) simonsmith/stylelint-selector-bem-pattern#23
nickcharlton
force-pushed
the
nc-switch-to-stylelint
branch
from
9231448 to
cbd5c0d
Compare
|
I published Now this is ready to go. Hound keeps trying to lint, |
jasongorst
added a commit
to jasongorst/administrate
that referenced
this pull request
Feb 10, 2024
jasongorst
added a commit
to jasongorst/administrate
that referenced
this pull request
Feb 10, 2024
nickcharlton
pushed a commit
to jasongorst/administrate
that referenced
this pull request
Feb 14, 2024
In adjusting the styles in thoughtbot#2492, we removed more specific selectors to pass linting rules. Unfortunately, this broke the situation where you have a checkbox input when editing a `Field::Boolean`. This adds them back in, in a linting happy way. Fixes thoughtbot#2511
This was referenced Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2397, we're having trouble with ignoring directories using the existing
scss-lintconfiguration on Hound.scss-linthas been deprecated for a while and we have another configuration based on thoughtbot guides, so this is a good fit.We use BEM style selectors in our CSS. So we add a custom rule, based on some prior work by @a-tokyo, but adjusted to fit in our JSON configuration file.
In addition, we disable these rules as they don't make sense on Administrate:
https://github.com/thoughtbot/stylelint-config
sds/scss-lint@4ac76f9
humanmade/coding-standards#193 (comment)
simonsmith/stylelint-selector-bem-pattern#23