Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: insert inside area filter before clustering #1330

Open
wants to merge 2 commits into
base: beta/v0.19.1
Choose a base branch
from

Conversation

YoshiRi
Copy link

@YoshiRi YoshiRi commented Jun 7, 2024

Description

slackの議論であったように、地図にエリアを設定してそのエリア内の低層点群を除去する機能をクラスタリングの直前で導入するPRです。

議論の結果Optionalということになったので一旦draftで設定します。

TODO

  • 今はbase_link + 0.15mの高さ未満の物体のみをフィルタするような設定にしています。
  • この高さの閾値はどの程度にするべきかはPRをいれる際に合意がほしいです。

関連PR:#1327

Related links

Tests performed

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqubecloud bot commented Jun 7, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@YoshiRi YoshiRi marked this pull request as draft June 7, 2024 10:19
@0x126 0x126 removed their request for review September 19, 2024 05:37
@YoshiRi YoshiRi marked this pull request as ready for review October 10, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants