Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): use autoware_cmake to avoid Boost warning #528

Merged
merged 1 commit into from
May 26, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented May 26, 2023

Description

autowarefoundation#849 からBoostのwarningが出ているパッケージだけを抜き出して適用

Related Links

https://tier4.atlassian.net/browse/AEAP-488

Tests performed

下記のコマンドでビルドしてBoostのwarningが出ないこと

colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --catkin-skip-building-tests --parallel-workers 8 --packages-up-to  $(colcon list --base-path src/autoware/universe/common/ | awk '{print $1}')

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.3.16@ee0f0d2). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@              Coverage Diff               @@
##             beta/v0.3.16    #528   +/-   ##
==============================================
  Coverage                ?   9.84%           
==============================================
  Files                   ?     426           
  Lines                   ?   35769           
  Branches                ?    8016           
==============================================
  Hits                    ?    3522           
  Misses                  ?   28861           
  Partials                ?    3386           
Flag Coverage Δ
differential 9.84% <0.00%> (?)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@v-nojiri7841-esol v-nojiri7841-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/autoware/universe/common/の範囲でboostのWarningが残存ないことを確認。

@h-ohta h-ohta merged commit a9a17b5 into beta/v0.3.16 May 26, 2023
@h-ohta h-ohta deleted the fix/common_autoware_cmake branch May 26, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants