Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_planner/util): add alias of tier4_autoware_utils func #609

Conversation

yn-mrse
Copy link

@yn-mrse yn-mrse commented Jun 22, 2023

Description

autowarefoundation#1383 のalias追加を抽出して適用します。
なおmotion_utilsはv0.3.x系で使われていないためtier4_autoware_utilsへ置き換えます。

Related links

autowarefoundation#1383

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

yn-mrse and others added 4 commits June 22, 2023 21:32
Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -3.63 ⚠️

Comparison is base (7faa75b) 10.00% compared to head (87339a7) 6.38%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@                        Coverage Diff                         @@
##           feat/keep_stopping_dist/v0.3.16    #609      +/-   ##
==================================================================
- Coverage                            10.00%   6.38%   -3.63%     
==================================================================
  Files                                  427      70     -357     
  Lines                                35939    5451   -30488     
  Branches                              8089     575    -7514     
==================================================================
- Hits                                  3597     348    -3249     
+ Misses                               28893    4885   -24008     
+ Partials                              3449     218    -3231     
Flag Coverage Δ
differential 6.38% <ø> (-3.63%) ⬇️
Impacted Files Coverage Δ
...vior_velocity_planner/include/utilization/util.hpp 5.88% <ø> (ø)

... and 358 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sfukuta
Copy link

sfukuta commented Jun 23, 2023

確認内容に、build確認もなにも記載がないですが、未実施ですか?

@yn-mrse
Copy link
Author

yn-mrse commented Jun 23, 2023

build確認および動作検証済みであるため、Test performed欄に追記します。

@yn-mrse yn-mrse merged commit 0998c6a into feat/keep_stopping_dist/v0.3.16 Jun 23, 2023
@yn-mrse yn-mrse deleted the feat/behavior_velocity_planner/util/add_alias/v0.3.16 branch June 23, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants