Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(perception): rearrange clustering pipeline v0.11.0 #849

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

badai-nguyen
Copy link

@badai-nguyen badai-nguyen commented Sep 19, 2023

Description

塩尻の https://tier4.atlassian.net/browse/RT0-29048?focusedCommentId=137966
を対応するためのCherry-pick

Related Link

This PR should merge together with : https://github.com/tier4/autoware_launch.x2/pull/431

Tests performed

Tested by logging_simulator: predicted objects are output
image

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

badai-nguyen and others added 2 commits September 19, 2023 09:56
…ll unknown object detection (autowarefoundation#4681)

* feat: add roi_pointcloud_fusion node

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

fix: postprocess

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

fix: launch file

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

chores: refactor

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

fix: closest cluster

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chores: refactor

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* docs: add readme

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: add missed parameter declare

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: add center transform

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: typos in launch

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* docs: update docs

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: change roi pointcloud fusion output to clusters

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: add cluster debug roi pointcloud fusion

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: use IoU_x in roi cluster fusion

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* feat: add cluster merger package

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: camera lidar launch

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* style(pre-commit): autofix

* fix: cluster merger

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: roi cluster fusion unknown object fix

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* docs: add readme cluster_merger

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* docs: update roi pointcloud fusion readme

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: multiple definition bug

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactor

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* docs: update docs

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactor

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: pre-commit

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: update camera_lidar_radar mode launch

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…on#4999)

* fix: change downsample filter

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: remove downsamle after compare map

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: add low range cropbox

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* refactor: use_pointcloud_map

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactor

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: add roi based clustering option

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: change node name

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: launch argument pasrer

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
…ndation#4983)

fix: camera lidar fusion launch

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@badai-nguyen badai-nguyen changed the title Feat/rearrange clustering v0.11.0 feat/rearrange clustering v0.11.0 Sep 19, 2023
@badai-nguyen badai-nguyen changed the title feat/rearrange clustering v0.11.0 refactor(perception): rearrange clustering pipeline v0.11.0 Sep 19, 2023
Copy link

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please test with x2 project environment

Copy link

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please merge after checking with the actual vehicle.

@badai-nguyen
Copy link
Author

I merged this since It was tested and worked on actual vehicle on Sep.21

@badai-nguyen badai-nguyen merged commit c3ed832 into beta/v0.11.0 Sep 22, 2023
@badai-nguyen badai-nguyen deleted the feat/rearrange-clustering-v0.11.0 branch September 22, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common documentation Improvements or additions to documentation launch perception
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants