-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(perception): rearrange clustering pipeline v0.11.0 #849
Conversation
…ll unknown object detection (autowarefoundation#4681) * feat: add roi_pointcloud_fusion node Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> fix: postprocess Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> fix: launch file Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> chores: refactor Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> fix: closest cluster Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chores: refactor Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * docs: add readme Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add missed parameter declare Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add center transform Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: typos in launch Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * docs: update docs Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: change roi pointcloud fusion output to clusters Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add cluster debug roi pointcloud fusion Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: use IoU_x in roi cluster fusion Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * feat: add cluster merger package Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: camera lidar launch Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * style(pre-commit): autofix * fix: cluster merger Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: roi cluster fusion unknown object fix Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: typo Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * docs: add readme cluster_merger Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * docs: update roi pointcloud fusion readme Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: typo Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: multiple definition bug Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: refactor Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * docs: update docs Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: refactor Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: pre-commit Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: update camera_lidar_radar mode launch Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…on#4999) * fix: change downsample filter Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: remove downsamle after compare map Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add low range cropbox Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * refactor: use_pointcloud_map Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: refactor Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add roi based clustering option Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: change node name Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: launch argument pasrer Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
…ndation#4983) fix: camera lidar fusion launch Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please test with x2 project environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please merge after checking with the actual vehicle.
I merged this since It was tested and worked on actual vehicle on Sep.21 |
Description
塩尻の https://tier4.atlassian.net/browse/RT0-29048?focusedCommentId=137966
を対応するためのCherry-pick
Related Link
This PR should merge together with : https://github.com/tier4/autoware_launch.x2/pull/431
Tests performed
Tested by logging_simulator: predicted objects are output
![image](https://private-user-images.githubusercontent.com/94814556/269139069-9549c8ac-4a3e-4a4b-9453-2132e81b2f67.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTI0NzcsIm5iZiI6MTczOTU5MjE3NywicGF0aCI6Ii85NDgxNDU1Ni8yNjkxMzkwNjktOTU0OWM4YWMtNGEzZS00YTRiLTk0NTMtMjEzMmU4MWIyZjY3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA0MDI1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVlYWM0NjZkMmIzMjM2YTQ3NGExMzljZWVmNzdhMjc4NWMyNzEzODUxZDc5NGVjMzQ1ZGUyZWZhN2ViMjIwYTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.G3BmSDZBI4y1W0z25gfzFX5hegGa-5-SpPVvkaA8t_U)
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.