Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: enable use region storage by default #1524

Merged
merged 4 commits into from
May 5, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Apr 29, 2019

What problem does this PR solve?

For 3.0, we default enable it.

What is changed and how it works?

change config.

Check List

Tests

  • Manual test

@nolouch nolouch requested review from rleungx and disksing April 29, 2019 10:12
@cwen0
Copy link
Member

cwen0 commented Apr 29, 2019

/run-all-tests

@nolouch nolouch changed the title config: default enable use region storage config: enable use region storage by default Apr 29, 2019
@nolouch
Copy link
Contributor Author

nolouch commented Apr 29, 2019

/run-all-tests

@codecov-io
Copy link

Codecov Report

Merging #1524 into master will increase coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
+ Coverage    67.7%   67.72%   +0.01%     
==========================================
  Files         158      158              
  Lines       15632    15648      +16     
==========================================
+ Hits        10584    10597      +13     
+ Misses       4094     4090       -4     
- Partials      954      961       +7
Impacted Files Coverage Δ
tests/cluster.go 84.32% <100%> (+0.98%) ⬆️
server/config.go 82.08% <66.66%> (-0.28%) ⬇️
pkg/tempurl/tempurl.go 57.14% <0%> (-14.29%) ⬇️
server/etcd_kv.go 65.95% <0%> (-4.26%) ⬇️
server/namespace_cluster.go 84.41% <0%> (-3.9%) ⬇️
server/core/kv.go 73.91% <0%> (-2.9%) ⬇️
server/leader.go 80.91% <0%> (-1.25%) ⬇️
server/grpc_service.go 57.87% <0%> (-1.11%) ⬇️
server/option.go 90.41% <0%> (-0.84%) ⬇️
client/client.go 68.25% <0%> (-0.65%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67549be...41d0a4f. Read the comment docs.

@nolouch nolouch merged commit 6a02baa into tikv:master May 5, 2019
@nolouch nolouch deleted the enable-region-storage branch May 5, 2019 13:35
nolouch added a commit to nolouch/pd that referenced this pull request May 15, 2019
* config: default enable use region storage
nolouch added a commit that referenced this pull request May 23, 2019
* tiny clean up code (#1526)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* config:  enable use region storage by default (#1524)

* config: default enable use region storage

* schedulers: let hot region balance not affect by balance-region-scheduler-limit (#1522)

Signed-off-by: nolouch <nolouch@gmail.com>

* log: do not add stack to error log (#1532)

* *: replace gofail with pingcap/failpoint (#1534)

* *: replace gofail with pingcap/failpoint

Signed-off-by: disksing <i@disksing.com>

* fix typo

Signed-off-by: disksing <i@disksing.com>

* fix typo

Signed-off-by: disksing <i@disksing.com>

* Update server/cluster_test.go

Co-Authored-By: Lonng <chris@lonng.org>

* Update server/tso.go

Co-Authored-By: Lonng <chris@lonng.org>

* Update server/tso.go

Co-Authored-By: Lonng <chris@lonng.org>

* check enable failpoint result

Signed-off-by: disksing <i@disksing.com>

* Update server/cluster.go

Co-Authored-By: Lonng <chris@lonng.org>

* server: set timeout for MoveLeader (#1533)

* server: set timeout for MoveLeader

Signed-off-by: disksing <i@disksing.com>

* client, server: add ScanRegions gRPC protocol support (#1535)

* client, server: support ScanRegions gRPC protocol

Signed-off-by: disksing <i@disksing.com>

* schedule: actively push operator  (#1536)

* schedule: actively push operator

Signed-off-by: nolouch <nolouch@gmail.com>

* *: update some dead links (#1543)

* update links

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* Add windows build script (#1540)

Signed-off-by: Ana Hobden <operator@hoverbear.org>

* fix operator timeout metrics (#1541)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* *:Rollback config in store when kv.persist failed (#1476)

* tests: independent region sync test (#1545)

* tests: independent syncer region test

Signed-off-by: nolouch <nolouch@gmail.com>

* schedule: operator limit for stores (#1474)

* add store limit for scheduling

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* statistic: add the statistic of flow (#1548)

* store_statistic: add the statistic of flow

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants