Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: tiny clean up code #1526

Merged
merged 1 commit into from
Apr 30, 2019
Merged

*: tiny clean up code #1526

merged 1 commit into from
Apr 30, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Apr 29, 2019

What problem does this PR solve?

Clean up some code.

What is changed and how it works?

Just clean up the code

Check List

Tests

  • Unit test

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #1526 into master will increase coverage by 0.11%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1526      +/-   ##
==========================================
+ Coverage    67.7%   67.82%   +0.11%     
==========================================
  Files         158      158              
  Lines       15632    15634       +2     
==========================================
+ Hits        10584    10603      +19     
+ Misses       4094     4082      -12     
+ Partials      954      949       -5
Impacted Files Coverage Δ
server/schedule/operator.go 86.9% <ø> (ø) ⬆️
server/schedule/merge_checker.go 74.07% <ø> (ø) ⬆️
server/schedule/scheduler.go 66.66% <ø> (ø) ⬆️
server/schedule/hot_cache.go 66.38% <ø> (ø) ⬆️
server/schedule/replica_checker.go 80.6% <ø> (ø) ⬆️
server/config.go 82.35% <ø> (ø) ⬆️
server/schedulers/balance_leader.go 96.22% <100%> (ø) ⬆️
server/schedulers/balance_region.go 82.45% <100%> (ø) ⬆️
server/util.go 73.5% <100%> (+2.84%) ⬆️
server/coordinator.go 84.7% <100%> (+0.06%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67549be...6e57d86. Read the comment docs.

@nolouch nolouch merged commit da95f0e into tikv:master Apr 30, 2019
@rleungx rleungx mentioned this pull request May 5, 2019
nolouch added a commit that referenced this pull request May 23, 2019
* tiny clean up code (#1526)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* config:  enable use region storage by default (#1524)

* config: default enable use region storage

* schedulers: let hot region balance not affect by balance-region-scheduler-limit (#1522)

Signed-off-by: nolouch <nolouch@gmail.com>

* log: do not add stack to error log (#1532)

* *: replace gofail with pingcap/failpoint (#1534)

* *: replace gofail with pingcap/failpoint

Signed-off-by: disksing <i@disksing.com>

* fix typo

Signed-off-by: disksing <i@disksing.com>

* fix typo

Signed-off-by: disksing <i@disksing.com>

* Update server/cluster_test.go

Co-Authored-By: Lonng <chris@lonng.org>

* Update server/tso.go

Co-Authored-By: Lonng <chris@lonng.org>

* Update server/tso.go

Co-Authored-By: Lonng <chris@lonng.org>

* check enable failpoint result

Signed-off-by: disksing <i@disksing.com>

* Update server/cluster.go

Co-Authored-By: Lonng <chris@lonng.org>

* server: set timeout for MoveLeader (#1533)

* server: set timeout for MoveLeader

Signed-off-by: disksing <i@disksing.com>

* client, server: add ScanRegions gRPC protocol support (#1535)

* client, server: support ScanRegions gRPC protocol

Signed-off-by: disksing <i@disksing.com>

* schedule: actively push operator  (#1536)

* schedule: actively push operator

Signed-off-by: nolouch <nolouch@gmail.com>

* *: update some dead links (#1543)

* update links

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* Add windows build script (#1540)

Signed-off-by: Ana Hobden <operator@hoverbear.org>

* fix operator timeout metrics (#1541)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* *:Rollback config in store when kv.persist failed (#1476)

* tests: independent region sync test (#1545)

* tests: independent syncer region test

Signed-off-by: nolouch <nolouch@gmail.com>

* schedule: operator limit for stores (#1474)

* add store limit for scheduling

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* statistic: add the statistic of flow (#1548)

* store_statistic: add the statistic of flow

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants