Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistic: add the statistic of flow #1548

Merged
merged 2 commits into from
May 22, 2019
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented May 22, 2019

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Add the metrics of the flow statistics of the store.

What is changed and how it works?

Add metrics.

Check List

Tests

  • Manual test

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch requested review from shafreeck, disksing and rleungx May 22, 2019 08:00
server/store_statistics.go Outdated Show resolved Hide resolved
server/store_statistics.go Outdated Show resolved Hide resolved
server/store_statistics.go Outdated Show resolved Hide resolved
Signed-off-by: nolouch <nolouch@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #1548 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
- Coverage   67.65%   67.56%   -0.09%     
==========================================
  Files         159      159              
  Lines       16134    16141       +7     
==========================================
- Hits        10915    10906       -9     
- Misses       4258     4264       +6     
- Partials      961      971      +10
Impacted Files Coverage Δ
server/store_statistics.go 85.95% <100%> (+0.86%) ⬆️
pkg/etcdutil/etcdutil.go 79.06% <0%> (-16.28%) ⬇️
server/etcd_kv.go 65.95% <0%> (-4.26%) ⬇️
server/leader.go 79.59% <0%> (-2.86%) ⬇️
server/core/kv.go 74.63% <0%> (-1.45%) ⬇️
server/grpc_service.go 59.22% <0%> (-1.29%) ⬇️
server/option.go 90.62% <0%> (-0.79%) ⬇️
server/cluster.go 74.46% <0%> (-0.54%) ⬇️
server/handler.go 53.62% <0%> (+0.48%) ⬆️
server/schedule/region_scatterer.go 88.4% <0%> (+2.17%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fe66a0...0ad2a0f. Read the comment docs.

Copy link
Contributor

@shafreeck shafreeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch nolouch merged commit c44ddf4 into tikv:master May 22, 2019
@nolouch nolouch deleted the add-flow-stats branch May 22, 2019 10:23
nolouch added a commit that referenced this pull request May 23, 2019
* tiny clean up code (#1526)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* config:  enable use region storage by default (#1524)

* config: default enable use region storage

* schedulers: let hot region balance not affect by balance-region-scheduler-limit (#1522)

Signed-off-by: nolouch <nolouch@gmail.com>

* log: do not add stack to error log (#1532)

* *: replace gofail with pingcap/failpoint (#1534)

* *: replace gofail with pingcap/failpoint

Signed-off-by: disksing <i@disksing.com>

* fix typo

Signed-off-by: disksing <i@disksing.com>

* fix typo

Signed-off-by: disksing <i@disksing.com>

* Update server/cluster_test.go

Co-Authored-By: Lonng <chris@lonng.org>

* Update server/tso.go

Co-Authored-By: Lonng <chris@lonng.org>

* Update server/tso.go

Co-Authored-By: Lonng <chris@lonng.org>

* check enable failpoint result

Signed-off-by: disksing <i@disksing.com>

* Update server/cluster.go

Co-Authored-By: Lonng <chris@lonng.org>

* server: set timeout for MoveLeader (#1533)

* server: set timeout for MoveLeader

Signed-off-by: disksing <i@disksing.com>

* client, server: add ScanRegions gRPC protocol support (#1535)

* client, server: support ScanRegions gRPC protocol

Signed-off-by: disksing <i@disksing.com>

* schedule: actively push operator  (#1536)

* schedule: actively push operator

Signed-off-by: nolouch <nolouch@gmail.com>

* *: update some dead links (#1543)

* update links

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* Add windows build script (#1540)

Signed-off-by: Ana Hobden <operator@hoverbear.org>

* fix operator timeout metrics (#1541)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* *:Rollback config in store when kv.persist failed (#1476)

* tests: independent region sync test (#1545)

* tests: independent syncer region test

Signed-off-by: nolouch <nolouch@gmail.com>

* schedule: operator limit for stores (#1474)

* add store limit for scheduling

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* statistic: add the statistic of flow (#1548)

* store_statistic: add the statistic of flow

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants