server: add api member delete #245
Conversation
| resp, err := s.hc.Get(strings.Join(parts, "")) | ||
| c.Assert(err, IsNil) | ||
| buf, err := ioutil.ReadAll(resp.Body) | ||
| c.Assert(err, IsNil) |
|
In etcd, if we removed a member with ID, we can't add this member with same ID again. |
| cfgs, _, clean := mustNewCluster(c, 3) | ||
| defer clean() | ||
|
|
||
| someone := rand.Intn(len(cfgs)) |
|
Cluster: pd1, pd2, pd3 If pd2 was removed, a new pd named |
|
if has data, can join? |
|
|
||
| for _, t := range table { | ||
| parts := []string{"http://", t.addr, "/api/v1/members", "/" + t.name} | ||
| req, err := http.NewRequest(http.MethodDelete, strings.Join(parts, ""), nil) |
There was a problem hiding this comment.
can't compile in go 1.5 with http.MethodDelete, see travis CI.
|
Unfortunately, we can's use Howerver, |
|
so we should check data dir when join and must ensure the joining peer is clear and new. |
|
Yes, I guess, but it's another story, maybe I should tweak join flag in another PR, let's focus on delete api 😄 |
|
yes, I will open another issue for you. |
|
|
||
| // step 1. get etcd id | ||
| var id uint64 | ||
| name := (mux.Vars(r))["name"] |
There was a problem hiding this comment.
check empty or missing name here?
There was a problem hiding this comment.
Actually, it is fine, only DELETE /api/v1/members/xxx will be routed to here.
|
LGTM |
|
@huachaohuang PTAL |
|
LGTM |
#235
PTAL @siddontang @huachaohuang @qiuyesuifeng