Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdutil: refine the etcd client healthy checker code #7727

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #7499.

What is changed and how does it work?

Refine the etcd client healthy checker code.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Merging #7727 (d1f921e) into master (aa9c83c) will increase coverage by 0.05%.
The diff coverage is 88.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7727      +/-   ##
==========================================
+ Coverage   73.82%   73.87%   +0.05%     
==========================================
  Files         429      429              
  Lines       47528    47537       +9     
==========================================
+ Hits        35086    35118      +32     
+ Misses       9451     9441      -10     
+ Partials     2991     2978      -13     
Flag Coverage Δ
unittests 73.87% <88.13%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 17, 2024
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 17, 2024
@JmPotato
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2024

This pull request has been accepted and is ready to merge.

Commit hash: d1f921e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 17, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8f4f81f into tikv:master Jan 17, 2024
25 of 26 checks passed
@JmPotato JmPotato deleted the refine_healthy_checker branch January 17, 2024 10:22
ti-chi-bot bot pushed a commit that referenced this pull request Feb 4, 2024
close #7251

Cherry-pick the etcd client health checker improvements from #7725. #7727, #7743,  #7737 and #7779.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants