Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdutil: return original endpoints when all are evicted #7779

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Jan 30, 2024

What problem does this PR solve?

Issue Number: ref #7730, ref #7499.

What is changed and how does it work?

Return the originally picked endpoints directly if all are evicted to gain better availability.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Jan 30, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Merging #7779 (4af2f53) into master (1c54865) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7779      +/-   ##
==========================================
- Coverage   73.65%   73.63%   -0.03%     
==========================================
  Files         430      430              
  Lines       47740    47745       +5     
==========================================
- Hits        35164    35157       -7     
- Misses       9578     9586       +8     
- Partials     2998     3002       +4     
Flag Coverage Δ
unittests 73.63% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2024
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide more information in the log message etcd client is closed, exit update endpoint goroutine to distinguish the situations in syncer and inspector?

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato requested a review from HuSharp January 30, 2024 09:23
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 30, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 31, 2024
@JmPotato
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 31, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 31, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 4af2f53

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 31, 2024
@ti-chi-bot ti-chi-bot bot merged commit 357ad3f into tikv:master Jan 31, 2024
25 of 26 checks passed
@JmPotato JmPotato deleted the check_pickedEps branch January 31, 2024 05:27
@JmPotato JmPotato changed the title etcdutil: return original enpoints when all are evicted etcdutil: return original endpoints when all are evicted Feb 1, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Feb 4, 2024
close #7251

Cherry-pick the etcd client health checker improvements from #7725. #7727, #7743,  #7737 and #7779.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants