-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdutil: return original endpoints when all are evicted #7779
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7779 +/- ##
==========================================
- Coverage 73.65% 73.63% -0.03%
==========================================
Files 430 430
Lines 47740 47745 +5
==========================================
- Hits 35164 35157 -7
- Misses 9578 9586 +8
- Partials 2998 3002 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
97709ba
to
5ba046f
Compare
Signed-off-by: JmPotato <ghzpotato@gmail.com>
5ba046f
to
e0d58db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide more information in the log message etcd client is closed, exit update endpoint goroutine
to distinguish the situations in syncer and inspector?
Signed-off-by: JmPotato <ghzpotato@gmail.com>
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 4af2f53
|
What problem does this PR solve?
Issue Number: ref #7730, ref #7499.
What is changed and how does it work?
Check List
Tests
Release note