Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: cherry-pick the etcd client health checker improvements #7793

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Feb 2, 2024

What problem does this PR solve?

Issue Number: close #7251, #6291, #7226. Cherry-pick part of code from #7725. #7727, #7743, #7737 and #7779.

What is changed and how does it work?

Cherry-pick the etcd client health checker improvements from #7725. #7727, #7743,  #7737 and #7779.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

image

image

Release note

Enhance PD availability in the event of IO hang causing node unavailability.

Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Feb 2, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 2, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Feb 2, 2024
Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update metrics json as well?

@JmPotato
Copy link
Member Author

JmPotato commented Feb 2, 2024

update metrics json as well?

Dashboard JSON could be imported or modified manually, so cherry-picking is not that necessary. I prefer to avoid making too many changes in this PR.

@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Feb 2, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 2, 2024
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Merging #7793 (1484980) into release-7.5 (ae19047) will increase coverage by 0.06%.
The diff coverage is 85.55%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.5    #7793      +/-   ##
===============================================
+ Coverage        74.53%   74.60%   +0.06%     
===============================================
  Files              443      444       +1     
  Lines            47983    48120     +137     
===============================================
+ Hits             35764    35899     +135     
- Misses            9035     9043       +8     
+ Partials          3184     3178       -6     
Flag Coverage Δ
unittests 74.60% <85.55%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2024
@JmPotato
Copy link
Member Author

JmPotato commented Feb 2, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2024
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Copy link
Member Author

JmPotato commented Feb 2, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2024
@JmPotato
Copy link
Member Author

JmPotato commented Feb 2, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

@JmPotato: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 4, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 4, 2024
@JmPotato
Copy link
Member Author

JmPotato commented Feb 4, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 1484980

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit 85e1a27 into tikv:release-7.5 Feb 4, 2024
24 checks passed
@JmPotato JmPotato deleted the cp_health_checker_improve branch February 4, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants