-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: cherry-pick the etcd client health checker improvements #7793
*: cherry-pick the etcd client health checker improvements #7793
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update metrics json as well?
Dashboard JSON could be imported or modified manually, so cherry-picking is not that necessary. I prefer to avoid making too many changes in this PR. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #7793 +/- ##
===============================================
+ Coverage 74.53% 74.60% +0.06%
===============================================
Files 443 444 +1
Lines 47983 48120 +137
===============================================
+ Hits 35764 35899 +135
- Misses 9035 9043 +8
+ Partials 3184 3178 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/hold |
Signed-off-by: JmPotato <ghzpotato@gmail.com>
e1122dc
to
1484980
Compare
/unhold |
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@JmPotato: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 1484980
|
What problem does this PR solve?
Issue Number: close #7251, #6291, #7226. Cherry-pick part of code from #7725. #7727, #7743, #7737 and #7779.
What is changed and how does it work?
Check List
Tests
Release note