Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Integration branch for HCM and accessibility fixes #524

Merged
merged 71 commits into from
Aug 21, 2023
Merged

Integration branch for HCM and accessibility fixes #524

merged 71 commits into from
Aug 21, 2023

Conversation

helenb
Copy link
Member

@helenb helenb commented Aug 16, 2023 •
edited
Loading

Link to Ticket

Description of Changes Made

This is an integration branch for various HCM and accessibility fixes on different tickets.

Includes the following MRS:

#508
#509
#510
#512
#513

How to Test

Screenshots

Expand to see more

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Consider adding unit tests, especially for bug fixes. If you don't, tell us why.
  • Tests and linting passes.
  • Consider updating documentation. If you don't, tell us why.
  • If relevant, list the environments / browsers in which you tested your changes.

@chris-lawton
ensure mobile menu button is visible in HCM
006c66d
@chris-lawton
use hcm mixin
91c5c40
@chris-lawton
make logo consistent in light/dark modes in HCM
0f470b3
@chris-lawton
ensure footer social icons can be seen in dark high contrast mode
c9b6a2f
@chris-lawton
rename mixim for clarity
5165983
@chris-lawton
invert footer logos in high contrast dark mode
604913c
@chris-lawton
show menu toggle button
f670387
@chris-lawton
change shard window colour based on colour scheme
e525cf6
@chris-lawton
add parenthesis to mixin
c548597
@chris-lawton
add underline and hover state to footer links
d84a065
@chris-lawton
add underline to links and show expanding border on hover/focus
0643b89
@chris-lawton
add underline to home page blog items and toggle on hover/focus
39f9818
@chris-lawton
ensure external link icon can be seen in hcm
550ea0c
@chris-lawton
change shards svg for light / dark modes
08a324e
@chris-lawton
use hcm mixin
fd099ec
@chris-lawton
rename mixin for clarity
cc48e20
@chris-lawton
add parenthesis to mixin
da6f35d
@chris-lawton
add more parenthesis
ab5cc7e
@chris-lawton
disable nesting depth
98d279a
@chris-lawton
add hover state to more button
1e58327
@chris-lawton
make hover state more consistent for links on homepage in hcm
78d1e8b
@chris-lawton
increase border thickness on hover rather than remove it
d66b286
@chris-lawton
add underline and hover state to footer links
16d9067
@chris-lawton
ensure client logos and chevron can be seen in dark hcm
6d9e5f3
@chris-lawton
drop the underline under keypoints so it doesn't overlap the border i…
37a70ec 
…n hcm
@chris-lawton
add hover state on pullquote
80ec36c
@chris-lawton
add hover state to quote slider
ecec8d6
@chris-lawton
add hover state for in page nav items
5a0fbeb
@chris-lawton
add parenthesis to mixins
d9fe73f
@chris-lawton
rename hcm dark mode mixin
97ba929
chris-lawton and others added 15 commits August 14, 2023 17:14
@chris-lawton
add parenthesis to mixin
df0ad7f
@chris-lawton
remove border radius from see more on hover
6c2562f
@chris-lawton
increase thickness of link underline on hover rather than remove it
78a92b7
@chris-lawton
add interaction state change to author name
bb0213f
@chris-lawton
add consistent state change to contact slim email
76e6127
@chris-lawton
fix related items in hcm
c74739b
@chris-lawton
add and toggle aria-expanded attr on mobile menu button
10b9008
@chris-lawton
remove 100% height from logo as it was preventing menu links from bei…
35a74a1 
…ng clicked on smaller viewports
@chris-lawton
ensure hidden menu links cannot receive focus
5df28b7
@chris-lawton
move the toggle button on the home page for a more logical tabbing order
8576ae5
@chris-lawton
add the skip link to the home page
f8dcccb
@chris-lawton
add hover state to menu button
19cb39c
@chris-lawton
add hover state for hcm
0b9b948
@chris-lawton
use header.html include on the homepage for correct dom order when ta…
140b626 
…bbing
@helenb
Merge pull request #509 from torchbox/feature/1389-home-page-HCM
127294a 
1389 | Home page HCM
@helenb helenb changed the title Integration/hcm accessibility fixes Integration branch for HCM and accessibility fixes Aug 16, 2023
helenb and others added 8 commits August 16, 2023 10:27
@helenb
Merge remote-tracking branch 'origin/integration/hcm-accessibility-fi…
05bda8b 
…xes' into feature/1786-proposition-pages-HCM
@helenb
Merge pull request #512 from torchbox/feature/1786-proposition-pages-HCM
15b62d1 
1786 | Proposition pages HCM
@chris-lawton
link for a client logo isn't a required field
9a9c73d
@helenb
Update stylelint and stylelint-config-torchbox, disable rules that in…
4d6fc51 
…terfere with system colours
@chris-lawton
Merge pull request #525 from torchbox/fix/check-client-logo-link-with…
00fadd8 
…-hcm

Check client logo link with hcm
@helenb
Merge pull request #526 from torchbox/feature/6515-hcm-for-nav-and-ri…
10b5d44 
…ch-text

Further HCM fixes and update style lint packages to cope with system colours (sort of)
@helenb
Merge remote-tracking branch 'origin/main' into integration/hcm-acces…
a01f5d8 
…sibility-fixes
@helenb
Ensure 'read case study' text does not appear for unlinked client logos
b09cf09
@helenb helenb merged commit 3f54fda into main Aug 21, 2023
2 checks passed
@helenb helenb deleted the integration/hcm-accessibility-fixes branch August 21, 2023 08:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
on-staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helenb @chris-lawton