Set grpc-timeout in milliseconds #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting it in nanoseconds overflowed the maximum length (8) of the header already at 100ms, causing PROTOCOL_ERROR responses. Using ms instead of nanoseconds is not bullet proof either, but covers the range of 1ms - ~27h.
Codecov ReportBase: 39.02% // Head: 39.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 39.02% 39.05% +0.02%
==========================================
Files 28 28
Lines 2091 2092 +1
==========================================
+ Hits 816 817 +1
Misses 1275 1275
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tsloughter
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting it in nanoseconds overflowed the maximum length (8) of the header already at 100ms, causing PROTOCOL_ERROR responses. Using ms instead of ns is not bullet proof either, but covers the range of 1ms - ~27h. Seems most if not all use cases should fit in this range and doing extra calculations for covering more range might not be worth it performance-wise.
Fixes #85