[8/y] Fix wildcard arg matching for Obj-C param types #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
andrewchang-bird
force-pushed
the
dev/andrewchang-bird/fix-objc-nil
branch
from
02586f8
to
40134ad
Compare
andrewchang-bird
force-pushed
the
dev/andrewchang-bird/fix-objc-parameters
branch
from
81d2134
to
8b03fb6
Compare
andrewchang-bird
changed the title
ryanmeisters
approved these changes
Jan 5, 2022
andrewchang-bird
force-pushed
the
dev/andrewchang-bird/fix-objc-nil
branch
from
40134ad
to
8f243ee
Compare
Dynamic mocking (introduced in 0.18) changed how Objective-C parameter types are faked for wildcard argument matching. To support Objective-C mocking, argument matchers for `NSObjectProtocol` parameters no longer create type facades that go through the resolution context thread, but instead create dynamic `NSProxy` doubles. Dynamic type facades weren’t set up to be used from Swift; this change enables Swift to properly resolve the type facades.
andrewchang-bird
force-pushed
the
dev/andrewchang-bird/fix-objc-parameters
branch
from
8b03fb6
to
1bd6c0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
📚 #248 [9/y] Fix nested optional codegen
📚 #247 ← [8/y] Fix wildcard arg matching for Obj-C param types
📚 #246 [7/y] Fix stubbing nil values in Obj-C mocks
📚 #254 [6/y] Update example projects
📚 #253 [5/y] Improve support for configuring SPM Xcode projects
📚 #252 [4/y] Show help message no mockable types are generated
📚 #251 [3/y] Fix unavailable generic protocol mock initializer
📚 #250 [2/y] Fix generator caching for multi-project setups
📚 #249 [1/y] Optimize dependency graph traversal
📚 #245 Replace SwiftPM with Swift Argument Parser
Dynamic mocking (introduced in 0.18) changed how Objective-C parameter types are faked for wildcard argument matching. To support Objective-C mocking, argument matchers for
NSObjectProtocolparameters no longer create type facades that go through the resolution context thread, but instead create dynamicNSProxydoubles.Dynamic type facades weren’t set up to be used from Swift; this change enables Swift to properly resolve the type facades.
Closes #233