[2/y] Fix generator caching for multi-project setups #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 24, 2021
This was referenced Jan 4, 2022
ryanmeisters
approved these changes
Jan 5, 2022
Base automatically changed from
dev/andrewchang-bird/optimize-dep-graph
to
master
January 6, 2022 03:41
Test target caching is currently done relative to the source project which causes improper invalidation when the source and test targets are in the same Xcode project. The downstream effect is that incremental Xcode builds are much slower for large projects since the generated mock file is “modified” each run. This fixes the test target caching by using the environment-supplied project and srcroot values for the cache key.
andrewchang-bird
force-pushed
the
dev/andrewchang-bird/fix-multiproj-caching
branch
from
560e0d0
to
e73c911
Compare
andrewchang-bird
deleted the
dev/andrewchang-bird/fix-multiproj-caching
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
📚 #254 [6/y] Update example projects
📚 #253 [5/y] Improve support for configuring SPM Xcode projects
📚 #252 [4/y] Show help message no mockable types are generated
📚 #251 [3/y] Fix unavailable generic protocol mock initializer
📚 #250 ← [2/y] Fix generator caching for multi-project setups
📚 #249 [1/y] Optimize dependency graph traversal
📚 #245 Replace SwiftPM with Swift Argument Parser
Test target caching is currently done relative to the source project which causes improper invalidation when the source and test targets are in the same Xcode project. The downstream effect is that incremental Xcode builds are much slower for large projects since the generated mock file is “modified” each run.
This fixes the test target caching by using the environment-supplied project and srcroot values for the cache key.