[1/y] Optimize dependency graph traversal #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLI was previously split out from the framework package definitions to fix SwiftUI issues. This merges the packages under a conditional build flag, similar to the official SwiftPM package manifest: https://github.com/apple/swift-package-manager/blob/main/Package.swift
Hermetic / non-portable builds are the default going forward given the the launcher included in 0.17. Installable artifacts will be released with the `-installable` suffix and the less intuitive `-cisafe` will be dropped for hermetic builds.
- XcodeProj 8.0.0 -> 8.7.1 - SwiftSyntax 0.50400.0 -> 0.50500.0
Fixes the linker warning that lib_InternalSwiftSyntaxParser.dylib was built for newer macOS version (10.14.6) than being linked (10.13).
- Removed Xcode 12 workflow as SwiftSyntax 0.50500.0 is not source compatible with Xcode 13. - Migrated from `install` to `configure` command.
This was referenced Dec 24, 2021
This was referenced Jan 4, 2022
ryanmeisters
approved these changes
Jan 5, 2022
Base automatically changed from
dev/andrewchang-bird/swift-argument-parser
to
master
January 6, 2022 03:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
📚 #254 [6/y] Update example projects
📚 #253 [5/y] Improve support for configuring SPM Xcode projects
📚 #252 [4/y] Show help message no mockable types are generated
📚 #251 [3/y] Fix unavailable generic protocol mock initializer
📚 #250 [2/y] Fix generator caching for multi-project setups
📚 #249 ← [1/y] Optimize dependency graph traversal
📚 #245 Replace SwiftPM with Swift Argument Parser
Parsing the dependency graph specifically for JSON project descriptions is quite slow for large projects. The biggest contributor is from re-computing the set key for targets. This change optimizes how the targets are indexed when constructing the dependency graph.
Before
~24s
After
~4s