Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dragen alignment pipeline version 4.2.4 #383

Merged
merged 9 commits into from
Aug 11, 2023

Conversation

alexiswl
Copy link
Member

@alexiswl alexiswl commented Aug 7, 2023

@alexiswl alexiswl requested a review from skanwal August 7, 2023 05:45
@alexiswl alexiswl self-assigned this Aug 7, 2023
@alexiswl alexiswl marked this pull request as draft August 7, 2023 05:46
@victorskl
Copy link
Member

Alexis; confirming -- is this new dragen alignment pipeline is alignment QC pipeline for both WGS and WTS, correct..? And that will be replaced wgs_alignment_qc with Ocicat release as discussed..?

@alexiswl
Copy link
Member Author

alexiswl commented Aug 7, 2023

The WGS QC Pipeline has one step (which calls the dragen alignment pipeline).

So I think we can shrink this down and just call the dragen alignment pipeline instead, we will use this for both WGS and WTS QC steps with the only difference being the '--enable-rna' parameter

@alexiswl
Copy link
Member Author

alexiswl commented Aug 7, 2023

Thoughts on this @skanwal, means a change to the WFL ID in umccr/infrastructure#334

@skanwal
Copy link
Member

skanwal commented Aug 8, 2023

I second this idea @alexiswl. Initially, I believe, we created wgs-qc pipeline thinking we might need to add additional steps to it down the road specifically for WGS data.

Did we test dragen alignment pipeline for WTS data in dev?

Copy link
Member

@skanwal skanwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Assuming it has been tested for WTS data in dev?

@alexiswl
Copy link
Member Author

alexiswl commented Aug 8, 2023

Did we test dragen alignment pipeline for WTS data in dev?

Pretty sure we ran the wgs qc for WTS as a test. Can run alignment for both WGS and WTS this afternoon

@alexiswl
Copy link
Member Author

alexiswl commented Aug 8, 2023

Done, with

WTS

wfr.82f89531a0b44d26b0e717c2f5b7178f

WGS

wfr.a241f7e6ec06487db6a9eecc8f694470

4.2.4 didn't have the --enable-map-align-output parameter available so have added that in.

It is a redundant parameter since we are not doing variant calling, but good to have regardless.

@alexiswl
Copy link
Member Author

alexiswl commented Aug 8, 2023

Also added to production_workflows project

@alexiswl alexiswl marked this pull request as ready for review August 8, 2023 09:34
@alexiswl
Copy link
Member Author

alexiswl commented Aug 8, 2023

Investigating missing RNA Quant Metrics and Transcript Coverage from multiqc in wfr.82f89531a0b44d26b0e717c2f5b7178f outputs.

May be that just adding --enable-rna=True isn't enough.

Also note that the output files for dragen still contain wgs_* prefixes :/

@alexiswl
Copy link
Member Author

alexiswl commented Aug 8, 2023

Ah need the --enable-rna-quantification parameter for transcript and quant metrics. This also requires an annotation file to be loaded. Are we happy to have these omitted? This 'QC' workflow can then just be with respect to alignment quality (and depth).

@skanwal
Copy link
Member

skanwal commented Aug 8, 2023

--enable-rna-quantification parameter for transcript and quant metrics. This also requires an annotation file to be loaded.

I'd suggest we should add these as looking at the QC report we are also missing rRNA%, which might be a useful metrics for the lab.

Also note that the output files for dragen still contain wgs_* prefixes :/

As also mentioned yesterday - not surprised..

@alexiswl
Copy link
Member Author

alexiswl commented Aug 9, 2023

I'd suggest we should add these as looking at the QC report we are also missing rRNA%, which might be a useful metrics for the lab.

We can add in --rrna-filter-enable=true then too -
from dragen v4.2 docs

@alexiswl
Copy link
Member Author

alexiswl commented Aug 9, 2023

Reran with wfr.9fca2a78578741c1b3b04fb540ff9162.

  • %rRNA ✅
  • Transcript Coverage Plot ✅
  • Quant Metrics Plot ❌

Tried running with multiqc 1.15 (released a few days ago) but I forgot to commit the search patterns file so that's a new PR here MultiQC/MultiQC#1969.

tl;dr, we can create our own custom container if we really need the quant metrics in multiqc?

@victorskl victorskl added the epic Epic feature! label Aug 9, 2023
@skanwal
Copy link
Member

skanwal commented Aug 9, 2023

tl;dr, we can create our own custom container if we really need the quant metrics in multiqc?

For dragen-transcriptome workflow, we'll need the plot. So, it'll be good to have it added.
Thanks for the upstream PR.

@alexiswl
Copy link
Member Author

alexiswl commented Aug 10, 2023

This is using from this commit MultiQC/MultiQC@eb98188

Copied and created an image under https://quay.io/repository/umccr/multiqc?tab=tags

Output here -

PTC_NebRNA210629_dragen_alignment_multiqc (1).zip

Have then updated the dragen alignment workflow to use new multiqc tool (have added this in as a separate PR #384)

@alexiswl alexiswl marked this pull request as draft August 10, 2023 05:13
@alexiswl
Copy link
Member Author

Waiting for #384

@alexiswl alexiswl marked this pull request as ready for review August 10, 2023 06:28
@alexiswl
Copy link
Member Author

@skanwal please let me know if this is all okay from your end?

Would like to get stg, prod PRs done for WGS/WTS QC infrastructure and fix up umccr/data-portal-apis#611 with the additional parameters discussed above.

@skanwal
Copy link
Member

skanwal commented Aug 10, 2023

All good from my end @alexiswl.

@skanwal skanwal self-requested a review August 10, 2023 23:56
@alexiswl alexiswl merged commit 6dacc18 into main Aug 11, 2023
@alexiswl alexiswl deleted the feature/dragen-alignment4.2.4 branch August 11, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Epic feature!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants