-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dragen alignment pipeline version 4.2.4 #383
Conversation
Alexis; confirming -- is this new dragen alignment pipeline is alignment QC pipeline for both WGS and WTS, correct..? And that will be replaced |
The WGS QC Pipeline has one step (which calls the dragen alignment pipeline). So I think we can shrink this down and just call the dragen alignment pipeline instead, we will use this for both WGS and WTS QC steps with the only difference being the '--enable-rna' parameter |
Thoughts on this @skanwal, means a change to the WFL ID in umccr/infrastructure#334 |
I second this idea @alexiswl. Initially, I believe, we created wgs-qc pipeline thinking we might need to add additional steps to it down the road specifically for WGS data. Did we test dragen alignment pipeline for WTS data in dev? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Assuming it has been tested for WTS data in dev?
Pretty sure we ran the wgs qc for WTS as a test. Can run alignment for both WGS and WTS this afternoon |
Done, with WTSwfr.82f89531a0b44d26b0e717c2f5b7178f WGSwfr.a241f7e6ec06487db6a9eecc8f694470 4.2.4 didn't have the --enable-map-align-output parameter available so have added that in. It is a redundant parameter since we are not doing variant calling, but good to have regardless. |
Also added to production_workflows project |
Investigating missing RNA Quant Metrics and Transcript Coverage from multiqc in May be that just adding --enable-rna=True isn't enough. Also note that the output files for dragen still contain wgs_* prefixes :/ |
Ah need the --enable-rna-quantification parameter for transcript and quant metrics. This also requires an annotation file to be loaded. Are we happy to have these omitted? This 'QC' workflow can then just be with respect to alignment quality (and depth). |
I'd suggest we should add these as looking at the QC report we are also missing rRNA%, which might be a useful metrics for the lab.
As also mentioned yesterday - not surprised.. |
We can add in |
Reran with
Tried running with multiqc 1.15 (released a few days ago) but I forgot to commit the search patterns file so that's a new PR here MultiQC/MultiQC#1969. tl;dr, we can create our own custom container if we really need the quant metrics in multiqc? |
For dragen-transcriptome workflow, we'll need the plot. So, it'll be good to have it added. |
This is using from this commit MultiQC/MultiQC@eb98188 Copied and created an image under https://quay.io/repository/umccr/multiqc?tab=tags Output here - PTC_NebRNA210629_dragen_alignment_multiqc (1).zip Have then updated the dragen alignment workflow to use new multiqc tool (have added this in as a separate PR #384) |
Waiting for #384 |
@skanwal please let me know if this is all okay from your end? Would like to get stg, prod PRs done for WGS/WTS QC infrastructure and fix up umccr/data-portal-apis#611 with the additional parameters discussed above. |
All good from my end @alexiswl. |
TODO