Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Implement subject endpoint to include ctTSOv2 analysis results from ICAv2 BYOB #684

Closed
1 task done
raylrui opened this issue May 30, 2024 · 3 comments · Fixed by #702 or #703
Closed
1 task done

Feature: Implement subject endpoint to include ctTSOv2 analysis results from ICAv2 BYOB #684

raylrui opened this issue May 30, 2024 · 3 comments · Fixed by #702 or #703
Assignees
@victorskl
Labels
feature New feature investigation
Milestone
Release 2.2.2

Comments

@raylrui
Copy link
Contributor

raylrui commented May 30, 2024 •
edited by victorskl
Loading

Feature

Add TSO V2 filter in the GDSFileManager ICAv2 BYOB for analysis results

To Do

  • tsov2 metadata in the db
    - [ ] the path format of tsov2 in the GDSFileManager
@raylrui raylrui self-assigned this May 30, 2024
@raylrui raylrui added the feature New feature label May 30, 2024
@raylrui raylrui linked a pull request May 30, 2024 that will close this issue
[Draft] add tsov2 in the analysisi results #685
Closed
2 tasks
@victorskl victorskl added this to the Release 2.2.2 milestone May 30, 2024
@victorskl
Copy link
Member

victorskl commented Jun 4, 2024 •
edited
Loading

This is on me. Please kindly wait.

I will need to think a bit on how best to tackle showing results (key files of interest) from the new pipeline (ctTSOv2) run in another system (ICAv2). This is not straight forward.

@raylrui
Copy link
Contributor Author

raylrui commented Jun 4, 2024

sure, will update it when it is ready.

victorskl added a commit to umccr/infrastructure that referenced this issue Jun 14, 2024
@victorskl
Portal TF: Added Portal S3 indexer to ICAv2 pipeline cache bucket for…
a2c9486 
… ctTSOv2 result

* While building OrcaBus actively, we use current Portal to show ctTSOv2 output as new tab.
  * #434
  * umccr/data-portal-apis#684

* Once new output path convention is stable, we can statically filter prefix only to subscribe cttsov2.
  * umccr/orcabus#350

* Related FileManager PR
  * umccr/orcabus#351
@victorskl victorskl mentioned this issue Jun 14, 2024
Merged
@victorskl victorskl changed the title Feature: Add TSO V2 filter in the GDSFileManager for analysis results Feature: Implement subject endpoint to include ctTSOv2 analysis results from ICAv2 BYOB Jun 16, 2024
@victorskl victorskl assigned victorskl and unassigned raylrui Jun 17, 2024
@victorskl
Copy link
Member

As discussed over Slack, taking over for API impl.

victorskl added a commit that referenced this issue Jun 21, 2024
@victorskl
Added support for EventBridge S3 event processing
b39f8eb 
* Updated S3 event parser to handle ObjectCreated and ObjectDeleted come
  through EventBridge event envelope.
* Added relevant unit test cases as guard-rail around parser logic
* Part of story #684
* Related umccr/infrastructure#434
@victorskl victorskl mentioned this issue Jun 21, 2024
Merged
@victorskl victorskl mentioned this issue Jul 1, 2024
Merged
victorskl added a commit that referenced this issue Jul 2, 2024
@victorskl
Fixed Subject having no ctTSOv2 assay library
0a310ab 
Fixes #684
@victorskl victorskl mentioned this issue Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@victorskl victorskl

Labels
feature New feature investigation
Projects
None yet
Milestone
Release 2.2.2
2 participants
@victorskl @raylrui