Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for EventBridge S3 event processing #696

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

victorskl
Copy link
Member

* Updated S3 event parser to handle ObjectCreated and ObjectDeleted come
  through EventBridge event envelope.
* Added relevant unit test cases as guard-rail around parser logic
* Part of story #684
* Related umccr/infrastructure#434
@victorskl victorskl self-assigned this Jun 21, 2024
@victorskl victorskl added this to the Release 2.2.2 milestone Jun 21, 2024
Copy link
Member

@mmalenic mmalenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - matches similar logic in filemanager.

Copy link
Member

@reisingerf reisingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorskl victorskl merged commit fae986e into dev Jun 21, 2024
1 check passed
@victorskl victorskl deleted the support-s3-event-through-eventbridge-envelope branch June 21, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants