Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.2rc2 #642

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Release 2.2rc2 #642

merged 2 commits into from
Nov 2, 2023

Conversation

victorskl
Copy link
Member

Release 2.2rc2 for Staging

@victorskl
Rollback SQS Standard queue event router handler behaviour
53f4362 
* For Standard queue, we would not need to leverage `ReportBatchItemFailures`
  as exception failure error handling is covered by DLQ. Furthermore,
  Standard queue are processed in high-throughput manner, i.e. no particular
  batching control mechanism necessary. Unordered and duplicates are all fine.
  Underlie application and database will take care of it.
* Process simple and fast. If error, keep messages in DLQ. Rolling back to
  this previous behaviour.
* The `ReportBatchItemFailures` is still desirable in all that of FIFO queues.
@victorskl
Merge pull request #641 from umccr/rollback-standard-queue-event-rout…
a6e581d 
…er-handler

Rollback SQS Standard queue event router handler behaviour
@victorskl victorskl self-assigned this Nov 2, 2023
@victorskl victorskl added this to the Release 2.2 milestone Nov 2, 2023
@victorskl
Copy link
Member Author

FYI: I am going to make use of few pending runs in Staging to verify this. But, am confident that this changes won't make any major impact.

@victorskl
Copy link
Member Author

Merging..

@victorskl victorskl merged commit a6e581d into stg Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reisingerf reisingerf reisingerf approved these changes

Assignees

@victorskl victorskl

Labels
None yet
Projects
None yet
Milestone
Release 2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@victorskl @reisingerf