Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove s3-server and dependencies #150

Merged
merged 11 commits into from
Feb 6, 2023
Merged

Remove s3-server and dependencies #150

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
13e7ab4
Cherry-pick from remove-s3-server branch
brainstorm Jan 31, 2023
7c45b1f
Why are tests passing locally?? :thinking_face: /cc @mmalenic
brainstorm Feb 1, 2023
0c7af54
Apply suggestions from @mmalenic on PR review
brainstorm Feb 2, 2023
a851a03
Bump up s3s-* crates as suggested in https://github.com/umccr/htsget-…
brainstorm Feb 2, 2023
7e3feb8
test(search): fix tests related to improperly formatted `folder` in U…
mmalenic Feb 2, 2023
2b10b77
fix(search): check that a key exists before formatting a URL, ensurin…
mmalenic Feb 2, 2023
b5b4284
fix(search): use KeyNotFound error when a key is not found
mmalenic Feb 3, 2023
313fe2c
fix(search): use KeyNotFound for head and get object in AwsS3Storage
mmalenic Feb 3, 2023
f16a1e7
test(search): add set of tests targeting non-existent keys
mmalenic Feb 6, 2023
492e20e
build: remove unused dependencies
mmalenic Feb 6, 2023
01ebf6b
Merge branch 'main' of https://github.com/umccr/htsget-rs into s3-ser…
mmalenic Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading