-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: C4GH and storage changes #265
Conversation
…stead of Arc<Mutex<..>>
Update
|
ba546cc
to
bca364f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Gotcha, probably worth holding to noodles release before merging this PR then? Two birds one shot? |
Nah, I'd like to get this merged so I can move on to the next PRs. It will be easy enough to fix in a different PR when it gets released. This could be a stand-alone dependency bump PR, or as part of a PR including features. |
Changes
htsget-storage
:StorageMiddleware
controls pre-processing and post-processing requests to the storage layer, which is used inC4GHStorage
to decrypt/encrypt data.StorageClone
allows cloning aBox<dyn StorageTrait + Send + Sync + 'static>
.Arc<Mutex<..>>
insideC4GHStorage
.C4GHStorage
.c4gh-experimental
toexperimental
.