Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly choose aws_lc_rs as the crypto provider #266

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

mmalenic
Copy link
Member

Changes

  • Specify aws_lc_rs as the crypto provider in all application binaries

I can't figure out which crate is suddenly enabling ring as a dependency in rustls (is it reqwest?), but I think it's probably worthwhile to specify this explicitly anyway.

This fixes failed build from #265.

@mmalenic mmalenic self-assigned this Sep 19, 2024
@mmalenic mmalenic added the fix fix a bug label Sep 19, 2024
@brainstorm
Copy link
Member

Yeah, good chat w.r.t ring vs aws-lc-rs ... still failing tests so we'll need to dig into:

no process-level CryptoProvider available -- call CryptoProvider::install_default() before this point

Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mmalenic mmalenic added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit ded4d9d Sep 19, 2024
5 checks passed
@brainstorm brainstorm deleted the feat/c4gh-misc branch September 19, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants