Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata-manager: model refactoring #508

Merged
merged 7 commits into from
Aug 20, 2024

Conversation

williamputraintan
Copy link
Member

@williamputraintan williamputraintan commented Aug 20, 2024

  • Refactor internal_id to library_id, subject_id, or specimen_id
  • Introduce orcabus_id as primary key
  • Add ProjectOwner and ProjectName from the tracking sheet to the Library model
  • Update OpenAPI docs to document query by field values

Resolve #470
Resolve #446

Copy link
Member Author

@williamputraintan williamputraintan Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this changes the primary_key, perhaps dropping the db in each cluster and re-migrate from scratch is simpler.

@williamputraintan williamputraintan requested review from victorskl and reisingerf and removed request for victorskl August 20, 2024 07:17
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamputraintan
Copy link
Member Author

@alexiswl Do you still need the support of having internal_id when querying the API or you would just update the step functions once this is merged?

@alexiswl
Copy link
Member

alexiswl commented Aug 20, 2024

Nah happy to just update things that this breaks

gromit

@alexiswl alexiswl closed this Aug 20, 2024
@alexiswl alexiswl reopened this Aug 20, 2024
@williamputraintan williamputraintan merged commit 22c8c62 into main Aug 20, 2024
9 checks passed
@williamputraintan williamputraintan deleted the feat(mm)-model-refactoring branch August 20, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants