Updated stacky with new metadata manager #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| library = get_library_from_library_id(library_id) | ||
|
|
||
| return library.get("project_owner") |
There was a problem hiding this comment.
On the casing end, I suppose this get will take value directly from the results JSON? (From #502) the metadata now has a middleware to translate snake_case to camelCase aligning with other microservices, so this might not get project_owner properly.
In terms of query params, the API may still support snake_case filters, but would recommend using the camelCase if you can as this is what the Swagger documents it.
There was a problem hiding this comment.
I guess this is the same for library_id/Id and subject_id/Id too?
There was a problem hiding this comment.
Yes, the response will be in camelCase
alexiswl
deleted the
update/refactor-stacky-with-new-metadata-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on #508