-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[systemverilog] Add keywords #2635
Conversation
You can run test cases locally with:
|
I run now and one fail is detected. The fail is caused by input and output ports of modports. It is a result as I made them to be detected.
But I found that they should be ignored. I will revert the fix.
I will also add test cases for the issues I fixed. |
Codecov Report
@@ Coverage Diff @@
## master #2635 +/- ##
=======================================
Coverage 86.82% 86.82%
=======================================
Files 183 183
Lines 38949 38949
=======================================
Hits 33817 33817
Misses 5132 5132
Continue to review full report at Codecov.
|
LGTM. |
I woud like you to change the commit log like:
for changing the code.
for changing/adding test cases. |
I added Units tests for this pull-request.
I reverted this fix as I wrote above.
I also reverted this. |
Please, see my comments. |
54413c0
to
c5efd9a
Compare
I've done this by reading https://docs.github.com/ja/github/committing-changes-to-your-project/changing-a-commit-message.
Sorry, I'm not sure what you mean. I have little experience with git.
How do I do this? Could you give a reference? |
I see. https://hackernoon.com/beginners-guide-to-interactive-rebasing-346a3f9c3a6d I can do what I requested to you in place of you. However, I would like to know "git rebase -i" because I expect you send more pull requests in the future:-) So could you try to learn the command line? If things don't go well, let me know. I will take over this pull request and merge this. Thank you. |
Thank you for references. I will try them tomorrow. |
c5efd9a
to
cc68a28
Compare
I've done. It was much easier than I thought. I used "git rebase -i" to change commit messages, but I never thought it was a such powerful tool. |
The new keywords, packed and protected are not in the test case. Is this o.k.? |
Hi. Good point. |
Yes.
|
keywords added: chandle, const, rand, randc, var mark sequence as K_PROPERTY
cc68a28
to
b8bd77c
Compare
I've pushed the fix. |
Thank you for your contribution. |
This is a fix for some of the issues I reported on #2618.