This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
%acme: use cert from clay files #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge next into master
Fix app behn error handling
fixes clay boot printfs
reverted nap:to bugfix
no-op on bad ames packet mugs
|
(Do we have non-world-readable clay directories yet)
…On Friday, 19 April 2019, Fang ***@***.***> wrote:
@joemfb <https://github.com/joemfb> as mentioned over email!
Does what it says on the can. Successfully tested on ~paldev.
------------------------------
You can view, comment on, or merge this pull request online at:
#1151
Commit Summary
- Implement %pem mark
- Implement installing certs from clay using %acme
File Changes
- *M* app/acme.hoon
<https://github.com/urbit/arvo/pull/1151/files#diff-0> (8)
- *A* mar/pem.hoon
<https://github.com/urbit/arvo/pull/1151/files#diff-1> (19)
Patch Links:
- https://github.com/urbit/arvo/pull/1151.patch
- https://github.com/urbit/arvo/pull/1151.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1151>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOFPBXS63RGPVECS6GK5TLPRI5E3ANCNFSM4HHIEO6Q>
.
|
|
yes, we do @ohAitch. |
joemfb
approved these changes
Apr 23, 2019
There was a problem hiding this comment.
I don't particularly like the hardcoded paths, and feel that this isn't strictly functionality that should live in :acme. That being said, the right way to do this requires some more functionality for managing multiple domains (and the intersection between a set of domains and a certificate). Doing that right probably requires a more-complete PKCS10 parser. Barring all that, this is a fine solution.
LGTM.
|
Thanks @joemfb! I agree with you on both counts. I'll add a TODO for factoring it out eventually, to more strongly signal the temporary intention of this code, and then merge this in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joemfb as mentioned over email!
Does what it says on the can. Successfully tested on ~paldev.