fix: Update Irish bank holidays #639
Conversation
@javicalle Thanks, updated the PR with new commits to fix the issue |
|
@javicalle Could you please review it? |
holidays/countries/ireland.py
Outdated
| if self.observed and date(year, DEC, 26).weekday() == SAT: | ||
| self[date(year, DEC, 26) + rd(weekday=MON)] = name + " (Observed)" | ||
| elif self.observed and date(year, DEC, 26).weekday() == SUN: | ||
| self[date(year, DEC, 26) + rd(weekday=TUE)] = name + " (Observed)" |
There was a problem hiding this comment.
Now I understand this part.
I think that could be correct as is, just that maybe I would use:
if self.observed and date(year, DEC, 26).weekday() in WEEKEND:
self[date(year, DEC, 26) + rd(days=2)] = name + " (Observed)"I'm not sure if it's more understandable or easier to maintain, so I'll leave it as a suggestion.
There was a problem hiding this comment.
I like it being a little bit more verbose ;)
|
How can we get it through the finishing line? |
That's up to @dr-prodigy |
|
Sorry, been not available for some weeks! On this now, will let you know 👍 |
|
Okay some fixes (tests, annotations, formatting) required, but then all done. |
|
Sweet, thanks a mil! |
|
Any progress with this, I'm still getting the same error on 2022.5.3. Thanks. |
|
There hasn't been a release of A workaround for Home Assistant (assuming that is what "2022.5.3" is referring to) involves copying the core |
|
Thanks, I thought I was posting in HA Core Github, but obviously not! I'll try reverting holidays back to 0.12 as you suggest. |
Version 0.14 ============ Released June 5, 2022 - Drop support for EOL Python 3.6 #328 (hugovk, dr-p) - Package review #662 (dimbleby) - Added financial markets support: ECB and NYSE, list_supported_financial() method (dr-p) - Support for NY Stock Exchange #651, #458 (nadime, dr-p) - Support for Malta #612, #630 (rafelbev) - Support for Madagascar #656 (fav007) - Support for Cyprus #410, #665 (digidestination, avnigo) - Ireland as standalone country #636, #639 (TeoTN, dr-p, javicalle) - Australia fixes #631 (jeremychrimes) - Singapore updates #652 (mborsetti) - Saudi Arabia fixes #642 (OsaydAbdu) - Spain fixes #634 (javicalle) - US fixes #648 (dashdrum) - Greece fixes #659 (tudorvaran) - India doc fixes #657 (dr-p) - Poland fix #663 (kfsz)
Fixes #636