Add founding day holiday to Saudi Arabia holidays #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
osaydabdu3
commented
Mar 15, 2022
•
osaydabdu3
commented
- Add new founding day holiday to Saudi Arabia module
- Add tests for new "founding day" holiday
- Add tests for weekend shifts that happened at 2013 (from Thrusday, Friday weekend to Friday, Saturday weekend)
- Fix weekend check for national holiday to include previous weekends (before 2013)
- Fix weekend code that mistakenly add UAE weekends into Saudi Arabia
- Add tests for edge cases when overlapping holidays between hijri and gregorian calendars
- Add new "founding day" holiday to Saudi Arabia module - Add tests for new "founding day" holiday - Add tests for weekend shifts that happened at 2013 (from Thrusday, Friday weekend to Friday, Saturday weekend) - Fix weekend check for national holiday to include previous weekends (before 2013) - Fix weekend code that mistakenly add UAE weekends into Saudi Arabia
Pull Request Test Coverage Report for Build 1988737390
💛 - Coveralls |
- add test for overlapping between hijri and gregorian calenders
osaydabdu3
force-pushed
the
update-saudi-holidays
branch
from
89aba7e
to
30601d5
Compare
|
Perfect job! |
dr-prodigy
added a commit
that referenced
this pull request
Jun 5, 2022
Version 0.14 ============ Released June 5, 2022 - Drop support for EOL Python 3.6 #328 (hugovk, dr-p) - Package review #662 (dimbleby) - Added financial markets support: ECB and NYSE, list_supported_financial() method (dr-p) - Support for NY Stock Exchange #651, #458 (nadime, dr-p) - Support for Malta #612, #630 (rafelbev) - Support for Madagascar #656 (fav007) - Support for Cyprus #410, #665 (digidestination, avnigo) - Ireland as standalone country #636, #639 (TeoTN, dr-p, javicalle) - Australia fixes #631 (jeremychrimes) - Singapore updates #652 (mborsetti) - Saudi Arabia fixes #642 (OsaydAbdu) - Spain fixes #634 (javicalle) - US fixes #648 (dashdrum) - Greece fixes #659 (tudorvaran) - India doc fixes #657 (dr-p) - Poland fix #663 (kfsz)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.