-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add nyse holidays #651
Conversation
Very nice work! Per https://github.com/dr-prodigy/python-holidays/issues/458, the ISO 20022 code to be used here is @dr-prodigy not sure how you want to categorize these so they can grow (we already have something for European markets). |
Pull Request Test Coverage Report for Build 2116314726
💛 - Coveralls |
Ah yes, of course - you're referring to the README, right (fixed there)? Or did I miss somewhere else you want the right MIC? |
Are we waiting on anything here? Can we merge this into beta? |
Hi @nadime thanks for your great work! |
Version 0.14 ============ Released June 5, 2022 - Drop support for EOL Python 3.6 #328 (hugovk, dr-p) - Package review #662 (dimbleby) - Added financial markets support: ECB and NYSE, list_supported_financial() method (dr-p) - Support for NY Stock Exchange #651, #458 (nadime, dr-p) - Support for Malta #612, #630 (rafelbev) - Support for Madagascar #656 (fav007) - Support for Cyprus #410, #665 (digidestination, avnigo) - Ireland as standalone country #636, #639 (TeoTN, dr-p, javicalle) - Australia fixes #631 (jeremychrimes) - Singapore updates #652 (mborsetti) - Saudi Arabia fixes #642 (OsaydAbdu) - Spain fixes #634 (javicalle) - US fixes #648 (dashdrum) - Greece fixes #659 (tudorvaran) - India doc fixes #657 (dr-p) - Poland fix #663 (kfsz)
Change to add NYSE holidays as an additional "financial markets" set of holidays. These were still done within the "countries" infrastructure, but perhaps once a few more financial markets are added we should modify the structure slightly.
I've included only "full day" holidays for the NYSE historically and done my best to match with a few sources:
https://s3.amazonaws.com/armstrongeconomics-wp/2013/07/NYSE-Closings.pdf
and
https://nyseholidays.blogspot.com/2012/11/nyse-holidays-from--.html where year1/year2 are always a year ending in X1 and X0 (e.g. 1941-1950).
I've tried my best to conform to the standards I saw, for example adding " (Observed)" at the end of holidays when the observed holiday does not fall on the actual holiday, but please let me know if you see anything else you'd like changed.
Cheers!