enhancement(topology): Add source id to metadata

[StephenWakely]

This adds a new field to the EventMetadata - source that contains the source of the event.

Nothing uses this yet. The plan is to emit a source tag in the metrics so the event can be traced through the topology. This will come in a follow up PR.

[netlify]

✅ Deploy Preview for vrl-playground ready!

Name	Link
🔨 Latest commit	51eadb2
🔍 Latest deploy log	https://app.netlify.com/sites/vrl-playground/deploys/645e455f6008d60007cf457c
😎 Deploy Preview	https://deploy-preview-17369--vrl-playground.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for vector-project ready!

Name	Link
🔨 Latest commit	51eadb2
🔍 Latest deploy log	https://app.netlify.com/sites/vector-project/deploys/645e455fccc62800082f8efe
😎 Deploy Preview	https://deploy-preview-17369--vector-project.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[github-actions]

Regression Detector Results

Run ID: de276749-2f9a-482f-a53b-a72a73935f42
Baseline: ae6a51b
Comparison: f866e3e
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.

experiment	goal	Δ mean %	Δ mean % CI	confidence
http_text_to_http_json	ingress throughput	+4.69	[+4.63, +4.75]	100.00%
socket_to_socket_blackhole	ingress throughput	+4.15	[+4.11, +4.20]	100.00%
syslog_splunk_hec_logs	ingress throughput	+3.23	[+3.16, +3.29]	100.00%
otlp_http_to_blackhole	ingress throughput	+2.71	[+2.53, +2.88]	100.00%
syslog_loki	ingress throughput	+1.86	[+1.78, +1.94]	100.00%
http_to_http_json	ingress throughput	+0.96	[+0.90, +1.03]	100.00%
syslog_humio_logs	ingress throughput	+0.94	[+0.87, +1.01]	100.00%
otlp_grpc_to_blackhole	ingress throughput	+0.92	[+0.81, +1.03]	100.00%
datadog_agent_remap_blackhole	ingress throughput	+0.87	[+0.78, +0.97]	100.00%
http_to_http_acks	ingress throughput	+0.32	[-0.91, +1.55]	26.09%
datadog_agent_remap_datadog_logs_acks	ingress throughput	+0.05	[-0.05, +0.15]	45.46%
file_to_blackhole	ingress throughput	+0.04	[-0.01, +0.09]	67.62%
http_to_http_noack	ingress throughput	+0.03	[-0.03, +0.09]	48.35%
enterprise_http_to_http	ingress throughput	+0.03	[-0.00, +0.06]	76.02%
splunk_hec_to_splunk_hec_logs_acks	ingress throughput	+0.00	[-0.06, +0.07]	4.75%
splunk_hec_indexer_ack_blackhole	ingress throughput	+0.00	[-0.04, +0.05]	4.78%
fluent_elasticsearch	ingress throughput	+0.00	[-0.00, +0.00]	27.22%
splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-0.03	[-0.07, +0.02]	55.72%
splunk_hec_route_s3	ingress throughput	-0.25	[-0.38, -0.11]	98.22%
datadog_agent_remap_datadog_logs	ingress throughput	-0.41	[-0.53, -0.30]	100.00%
syslog_log2metric_splunk_hec_metrics	ingress throughput	-0.87	[-0.95, -0.78]	100.00%
datadog_agent_remap_blackhole_acks	ingress throughput	-1.14	[-1.26, -1.01]	100.00%
syslog_log2metric_humio_metrics	ingress throughput	-2.64	[-2.75, -2.53]	100.00%
syslog_regex_logs2metric_ddmetrics	ingress throughput	-4.26	[-4.51, -4.02]	100.00%

[datadog-vectordotdev]

Datadog Report

Branch report: stephen/source_metadata
Commit report: e946306

❌ vector: 30 Failed (0 Known Flaky), 0 New Flaky, 1855 Passed, 0 Skipped, 6m 17.73s Wall Time

❌ Failed Tests (30)

This report shows up to 5 failed tests.

• transforms::aggregate::tests::transform_interval - vector - Details

  Expand for error

   thread 'transforms::aggregate::tests::transform_interval' panicked at 'assertion failed: \`(left == right)\`
     left: \`Metric(Metric { series: MetricSeries { name: MetricName { name: "counter_a", namespace: None }, tags: None }, data: MetricData { time: MetricTime { timestamp: None, interval_ms: None }, kind: Incremental, value: Counter { value: 85.0 } }, metadata: EventMetadata { value: Object({}), secrets: {}, finalizers: EventFinalizers([]), source_id: None, schema_definition: Definition { event_kind: Kind { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), undefined: Some(()), array: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }), object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, metadata_kind: Kind { bytes: None, integer: None, float: None, boolean: None, timestamp: None, regex: None, null: None, undefined: None, array: None, object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, meaning: {}, log_namespaces: {Vector, Legacy} } } })\`,
    right: \`Metric(Metric { series: MetricSeries { name: MetricName { name: "counter_a", namespace: None }, tags: None }, data: MetricData { time: MetricTime { timestamp: None, interval_ms: None }, kind: Incremental, value: Counter { value: 85.0 } }, metadata: EventMetadata { value: Object({}), secrets: {}, finalizers: EventFinalizers([]), source_id: Some(OutputId { component: ComponentKey { id: "in" }, port: None }), schema_definition: Definition { event_kind: Kind { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), undefined: Some(()), array: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }), object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, metadata_kind: Kind { bytes: None, integer: None, float: None, boolean: None, timestamp: None, regex: None, null: None, undefined: None, array: None, object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, meaning: {}, log_namespaces: {Vector, Legacy} } } })\`', src/transforms/aggregate.rs:542:40
   stack backtrace:
      0:     0x55fe8a21d88a - std::backtrace_rs::backtrace::libunwind::trace::ha9053a9a07ca49cb
                                  at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5
      1:     0x55fe8a21d88a - std::backtrace_rs::backtrace::trace_unsynchronized::h9c2852a457ad564e
                                  at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
      2:     0x55fe8a21d88a - std::sys_common::backtrace::_print_fmt::h457936fbfaa0070f
                                  at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/sys_common/backtrace.rs:65:5
   ...
  

• transforms::dedupe::tests::dedupe_ignore_age_out - vector - Details

  Expand for error

   thread 'transforms::dedupe::tests::dedupe_ignore_age_out' panicked at 'assertion failed: \`(left == right)\`
     left: \`Log(LogEvent { inner: Inner { fields: Object({"matched": Bytes(b"some value"), "message": Bytes(b"message"), "timestamp": Timestamp(2023-05-11T17:01:30.695548985Z)}), size_cache: AtomicCell { value: Some(312) }, json_encoded_size_cache: AtomicCell { value: Some(89) } }, metadata: EventMetadata { value: Object({}), secrets: {}, finalizers: EventFinalizers([]), source_id: Some(OutputId { component: ComponentKey { id: "in" }, port: None }), schema_definition: Definition { event_kind: Kind { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), undefined: Some(()), array: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }), object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, metadata_kind: Kind { bytes: None, integer: None, float: None, boolean: None, timestamp: None, regex: None, null: None, undefined: None, array: None, object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, meaning: {}, log_namespaces: {Vector, Legacy} } } })\`,
    right: \`Log(LogEvent { inner: Inner { fields: Object({"matched": Bytes(b"some value"), "message": Bytes(b"message"), "timestamp": Timestamp(2023-05-11T17:01:30.695548985Z)}), size_cache: AtomicCell { value: Some(312) }, json_encoded_size_cache: AtomicCell { value: Some(89) } }, metadata: EventMetadata { value: Object({}), secrets: {}, finalizers: EventFinalizers([]), source_id: None, schema_definition: Definition { event_kind: Kind { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), undefined: Some(()), array: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }), object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, metadata_kind: Kind { bytes: None, integer: None, float: None, boolean: None, timestamp: None, regex: None, null: None, undefined: None, array: None, object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, meaning: {}, log_namespaces: {Vector, Legacy} } } })\`', src/transforms/dedupe.rs:501:13
   stack backtrace:
      0:     0x55f79182388a - std::backtrace_rs::backtrace::libunwind::trace::ha9053a9a07ca49cb
                                  at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5
      1:     0x55f79182388a - std::backtrace_rs::backtrace::trace_unsynchronized::h9c2852a457ad564e
                                  at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
      2:     0x55f79182388a - std::sys_common::backtrace::_print_fmt::h457936fbfaa0070f
                                  at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/sys_common/backtrace.rs:65:5
   ...
  

• transforms::dedupe::tests::dedupe_ignore_basic - vector - Details

  Expand for error

   thread 'transforms::dedupe::tests::dedupe_ignore_basic' panicked at 'assertion failed: \`(left == right)\`
     left: \`Log(LogEvent { inner: Inner { fields: Object({"matched": Bytes(b"some value"), "message": Bytes(b"message"), "timestamp": Timestamp(2023-05-11T17:01:30.727888041Z), "unmatched": Bytes(b"another value")}), size_cache: AtomicCell { value: Some(398) }, json_encoded_size_cache: AtomicCell { value: Some(117) } }, metadata: EventMetadata { value: Object({}), secrets: {}, finalizers: EventFinalizers([]), source_id: Some(OutputId { component: ComponentKey { id: "in" }, port: None }), schema_definition: Definition { event_kind: Kind { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), undefined: Some(()), array: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }), object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, metadata_kind: Kind { bytes: None, integer: None, float: None, boolean: None, timestamp: None, regex: None, null: None, undefined: None, array: None, object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, meaning: {}, log_namespaces: {Vector, Legacy} } } })\`,
    right: \`Log(LogEvent { inner: Inner { fields: Object({"matched": Bytes(b"some value"), "message": Bytes(b"message"), "timestamp": Timestamp(2023-05-11T17:01:30.727888041Z), "unmatched": Bytes(b"another value")}), size_cache: AtomicCell { value: Some(398) }, json_encoded_size_cache: AtomicCell { value: Some(117) } }, metadata: EventMetadata { value: Object({}), secrets: {}, finalizers: EventFinalizers([]), source_id: None, schema_definition: Definition { event_kind: Kind { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), undefined: Some(()), array: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }), object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, metadata_kind: Kind { bytes: None, integer: None, float: None, boolean: None, timestamp: None, regex: None, null: None, undefined: None, array: None, object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, meaning: {}, log_namespaces: {Vector, Legacy} } } })\`', src/transforms/dedupe.rs:363:13
   stack backtrace:
      0:     0x55931052c88a - std::backtrace_rs::backtrace::libunwind::trace::ha9053a9a07ca49cb
                                  at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5
      1:     0x55931052c88a - std::backtrace_rs::backtrace::trace_unsynchronized::h9c2852a457ad564e
                                  at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
      2:     0x55931052c88a - std::sys_common::backtrace::_print_fmt::h457936fbfaa0070f
                                  at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/sys_common/backtrace.rs:65:5
   ...
  

• transforms::dedupe::tests::dedupe_ignore_field_name_matters - vector - Details

  Expand for error

   thread 'transforms::dedupe::tests::dedupe_ignore_field_name_matters' panicked at 'assertion failed: \`(left == right)\`
     left: \`Log(LogEvent { inner: Inner { fields: Object({"matched1": Bytes(b"some value"), "message": Bytes(b"message"), "timestamp": Timestamp(2023-05-11T17:01:30.788084403Z)}), size_cache: AtomicCell { value: Some(313) }, json_encoded_size_cache: AtomicCell { value: Some(90) } }, metadata: EventMetadata { value: Object({}), secrets: {}, finalizers: EventFinalizers([]), source_id: Some(OutputId { component: ComponentKey { id: "in" }, port: None }), schema_definition: Definition { event_kind: Kind { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), undefined: Some(()), array: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }), object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, metadata_kind: Kind { bytes: None, integer: None, float: None, boolean: None, timestamp: None, regex: None, null: None, undefined: None, array: None, object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, meaning: {}, log_namespaces: {Vector, Legacy} } } })\`,
    right: \`Log(LogEvent { inner: Inner { fields: Object({"matched1": Bytes(b"some value"), "message": Bytes(b"message"), "timestamp": Timestamp(2023-05-11T17:01:30.788084403Z)}), size_cache: AtomicCell { value: Some(313) }, json_encoded_size_cache: AtomicCell { value: Some(90) } }, metadata: EventMetadata { value: Object({}), secrets: {}, finalizers: EventFinalizers([]), source_id: None, schema_definition: Definition { event_kind: Kind { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), undefined: Some(()), array: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }), object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, metadata_kind: Kind { bytes: None, integer: None, float: None, boolean: None, timestamp: None, regex: None, null: None, undefined: None, array: None, object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, meaning: {}, log_namespaces: {Vector, Legacy} } } })\`', src/transforms/dedupe.rs:409:13
   stack backtrace:
      0:     0x5624d86f088a - std::backtrace_rs::backtrace::libunwind::trace::ha9053a9a07ca49cb
                                  at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5
      1:     0x5624d86f088a - std::backtrace_rs::backtrace::trace_unsynchronized::h9c2852a457ad564e
                                  at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
      2:     0x5624d86f088a - std::sys_common::backtrace::_print_fmt::h457936fbfaa0070f
                                  at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/sys_common/backtrace.rs:65:5
   ...
  

• transforms::dedupe::tests::dedupe_ignore_field_order_irrelevant - vector - Details

  Expand for error

   thread 'transforms::dedupe::tests::dedupe_ignore_field_order_irrelevant' panicked at 'assertion failed: \`(left == right)\`
     left: \`Log(LogEvent { inner: Inner { fields: Object({"matched1": Bytes(b"value1"), "matched2": Bytes(b"value2"), "message": Bytes(b"message"), "timestamp": Timestamp(2023-05-11T17:01:32.564473345Z)}), size_cache: AtomicCell { value: Some(387) }, json_encoded_size_cache: AtomicCell { value: Some(106) } }, metadata: EventMetadata { value: Object({}), secrets: {}, finalizers: EventFinalizers([]), source_id: Some(OutputId { component: ComponentKey { id: "in" }, port: None }), schema_definition: Definition { event_kind: Kind { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), undefined: Some(()), array: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }), object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, metadata_kind: Kind { bytes: None, integer: None, float: None, boolean: None, timestamp: None, regex: None, null: None, undefined: None, array: None, object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, meaning: {}, log_namespaces: {Vector, Legacy} } } })\`,
    right: \`Log(LogEvent { inner: Inner { fields: Object({"matched1": Bytes(b"value1"), "matched2": Bytes(b"value2"), "message": Bytes(b"message"), "timestamp": Timestamp(2023-05-11T17:01:32.564473345Z)}), size_cache: AtomicCell { value: Some(387) }, json_encoded_size_cache: AtomicCell { value: Some(106) } }, metadata: EventMetadata { value: Object({}), secrets: {}, finalizers: EventFinalizers([]), source_id: None, schema_definition: Definition { event_kind: Kind { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), undefined: Some(()), array: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }), object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, metadata_kind: Kind { bytes: None, integer: None, float: None, boolean: None, timestamp: None, regex: None, null: None, undefined: None, array: None, object: Some(Collection { known: {}, unknown: Unknown(Infinite(Infinite { bytes: Some(()), integer: Some(()), float: Some(()), boolean: Some(()), timestamp: Some(()), regex: Some(()), null: Some(()), array: Some(()), object: Some(()) })) }) }, meaning: {}, log_namespaces: {Vector, Legacy} } } })\`', src/transforms/dedupe.rs:458:13
   stack backtrace:
      0:     0x55978ced888a - std::backtrace_rs::backtrace::libunwind::trace::ha9053a9a07ca49cb
                                  at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5
      1:     0x55978ced888a - std::backtrace_rs::backtrace::trace_unsynchronized::h9c2852a457ad564e
                                  at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
      2:     0x55978ced888a - std::sys_common::backtrace::_print_fmt::h457936fbfaa0070f
                                  at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/sys_common/backtrace.rs:65:5
   ...
  

[bruceg]

One typo and a bunch of questions before I'm ready to approve. This is roughly what I would expect to see for this kind of metadata.

[bruceg]

Every use of this function takes the form *x.source_mut() = Some(value);. Would it be better to change the interface to a setter?

Suggested change

	/// Returns a mutable reference to the metadata source.
	pub fn source_mut(&mut self) -> &mut Option<Arc<OutputId>> {
	&mut self.source
	}
	/// Returns a mutable reference to the metadata source.
	pub fn set_source(&mut self, source_id: Arc<OutputId>) {
	self.source = Some(source_id);
	}

[StephenWakely]

Good point. A source will never be changed once set.

[bruceg]

If it will not be changed once set, is there some pattern that will prevent changing it, like a once cell?

[bruceg]

Is the output port actually used/useful? What is the envisioned use case?

[StephenWakely]

That's a good question. The primary use case is for the telemetry that the sinks will emit. Adding the source as a tag to these metrics will allow an event to be tracked from source to sink.

A secondary benefit will be to give VRL access to the field, something that has been asked for a number of times.

As it stands at the minute, the port is probably not that useful since the only sources that specify a port at the moment use the port to distinguish between logs, traces or metric outputs. So the port can be determined through other means. I'm not sure whether this will always be the case though..

[bruceg]

I'm 50/50 on this one. If there's not a known use, I don't think we should include it from the basic YAGNI principle. However, since it's in an Arc, cloning it costs no more than cloning the base component name, so it's pretty much free.

[StephenWakely]

I will shortly be adding another field to the metadata to indicate the previous component in the pipeline. That field will need the port, since the output of the port determines the schema definition that the component outputs. Keeping it like this does make it consistent with that.

But still I am also 50/50 on this.

[github-actions]

Regression Detector Results

Run ID: 25cd1421-b874-4f65-bcf7-c54350f5440c
Baseline: 22cda94
Comparison: a04f787
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.

experiment	goal	Δ mean %	Δ mean % CI	confidence
http_text_to_http_json	ingress throughput	+4.35	[+4.25, +4.45]	100.00%
otlp_http_to_blackhole	ingress throughput	+4.19	[+4.01, +4.36]	100.00%
socket_to_socket_blackhole	ingress throughput	+2.35	[+2.30, +2.40]	100.00%
datadog_agent_remap_blackhole_acks	ingress throughput	+1.93	[+1.79, +2.08]	100.00%
syslog_loki	ingress throughput	+1.61	[+1.52, +1.70]	100.00%
http_to_http_json	ingress throughput	+1.48	[+1.42, +1.54]	100.00%
datadog_agent_remap_blackhole	ingress throughput	+1.45	[+1.35, +1.54]	100.00%
otlp_grpc_to_blackhole	ingress throughput	+1.34	[+1.23, +1.45]	100.00%
syslog_splunk_hec_logs	ingress throughput	+1.34	[+1.27, +1.40]	100.00%
datadog_agent_remap_datadog_logs_acks	ingress throughput	+0.91	[+0.81, +1.00]	100.00%
datadog_agent_remap_datadog_logs	ingress throughput	+0.90	[+0.80, +1.01]	100.00%
file_to_blackhole	ingress throughput	+0.03	[-0.02, +0.08]	56.72%
http_to_http_noack	ingress throughput	+0.01	[-0.05, +0.08]	20.31%
splunk_hec_to_splunk_hec_logs_noack	ingress throughput	+0.00	[-0.05, +0.05]	2.94%
fluent_elasticsearch	ingress throughput	-0.00	[-0.00, +0.00]	40.47%
splunk_hec_indexer_ack_blackhole	ingress throughput	-0.01	[-0.05, +0.04]	16.07%
splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-0.01	[-0.08, +0.05]	16.58%
enterprise_http_to_http	ingress throughput	-0.02	[-0.05, +0.02]	45.16%
syslog_humio_logs	ingress throughput	-0.10	[-0.17, -0.02]	90.87%
splunk_hec_route_s3	ingress throughput	-0.43	[-0.56, -0.30]	100.00%
syslog_regex_logs2metric_ddmetrics	ingress throughput	-0.77	[-0.98, -0.57]	100.00%
syslog_log2metric_humio_metrics	ingress throughput	-1.30	[-1.40, -1.21]	100.00%
syslog_log2metric_splunk_hec_metrics	ingress throughput	-1.49	[-1.57, -1.41]	100.00%
http_to_http_acks	ingress throughput	-2.52	[-3.73, -1.30]	99.21%

[github-actions]

Regression Detector Results

Run ID: 60006215-5d07-4756-af22-c6fbb696bee5
Baseline: 58ba741
Comparison: 51eadb2
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.

experiment	goal	Δ mean %	Δ mean % CI	confidence
datadog_agent_remap_datadog_logs	ingress throughput	+4.04	[+3.96, +4.12]	100.00%
datadog_agent_remap_blackhole_acks	ingress throughput	+1.69	[+1.59, +1.79]	100.00%
syslog_splunk_hec_logs	ingress throughput	+0.92	[+0.86, +0.99]	100.00%
http_text_to_http_json	ingress throughput	+0.85	[+0.78, +0.92]	100.00%
socket_to_socket_blackhole	ingress throughput	+0.68	[+0.63, +0.73]	100.00%
syslog_humio_logs	ingress throughput	+0.67	[+0.61, +0.74]	100.00%
otlp_grpc_to_blackhole	ingress throughput	+0.23	[+0.11, +0.34]	98.58%
enterprise_http_to_http	ingress throughput	+0.06	[+0.02, +0.10]	95.32%
http_to_http_json	ingress throughput	+0.03	[-0.02, +0.08]	50.19%
http_to_http_noack	ingress throughput	+0.02	[-0.04, +0.08]	27.31%
splunk_hec_indexer_ack_blackhole	ingress throughput	+0.01	[-0.03, +0.05]	27.33%
splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-0.00	[-0.06, +0.06]	0.39%
fluent_elasticsearch	ingress throughput	-0.00	[-0.00, +0.00]	31.36%
file_to_blackhole	ingress throughput	-0.00	[-0.05, +0.05]	4.46%
splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-0.03	[-0.07, +0.02]	57.32%
syslog_loki	ingress throughput	-0.18	[-0.27, -0.10]	99.46%
otlp_http_to_blackhole	ingress throughput	-0.35	[-0.50, -0.19]	99.58%
syslog_regex_logs2metric_ddmetrics	ingress throughput	-0.38	[-0.69, -0.08]	89.11%
datadog_agent_remap_datadog_logs_acks	ingress throughput	-0.39	[-0.49, -0.28]	100.00%
datadog_agent_remap_blackhole	ingress throughput	-1.03	[-1.14, -0.91]	100.00%
http_to_http_acks	ingress throughput	-1.32	[-2.51, -0.13]	84.54%
splunk_hec_route_s3	ingress throughput	-1.53	[-1.66, -1.40]	100.00%
syslog_log2metric_splunk_hec_metrics	ingress throughput	-1.91	[-1.99, -1.84]	100.00%
syslog_log2metric_humio_metrics	ingress throughput	-4.40	[-4.55, -4.25]	100.00%

[bruceg]

I'm good with this either way we go on the actual data type inside the Arc.