Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deployment documentation. #32006

Merged
merged 22 commits into from
Jan 5, 2022
Merged

Update deployment documentation. #32006

merged 22 commits into from
Jan 5, 2022

Conversation

leerob
Copy link
Member

@leerob leerob commented Dec 1, 2021

Building off #31465 for next export docs.

  • Clearly explains the standard output from next build
  • Move Dockerfile snippet to example, instead of embedded directly
  • Clarify both Vercel and next start use the Build API output spec
  • Less emphasis on recommending Vercel (more neutrality)
  • Mention Middleware & Edge Functions when discussing Vercel
  • Add "Going to Production" link at the bottom for related reading

@leerob
Copy link
Member Author

leerob commented Dec 3, 2021

This will need to be paired with a headings redirects PR in front 👍

@leerob leerob mentioned this pull request Dec 12, 2021
Merged
molebox
molebox previously approved these changes Dec 15, 2021
View reviewed changes
Copy link
Collaborator

@molebox molebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Lee! I left some small comments. But otherwise LGTM

docs/deployment.md Outdated Show resolved Hide resolved
docs/deployment.md Show resolved Hide resolved
docs/deployment.md Outdated Show resolved Hide resolved
timneutkens
timneutkens reviewed Dec 15, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
timneutkens
timneutkens reviewed Dec 15, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
timneutkens
timneutkens reviewed Dec 15, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
timneutkens
timneutkens reviewed Dec 15, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
timneutkens
timneutkens reviewed Dec 15, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
timneutkens
timneutkens reviewed Dec 15, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
timneutkens
timneutkens reviewed Dec 15, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
molebox
molebox previously approved these changes Dec 22, 2021
View reviewed changes
styfle
styfle reviewed Dec 22, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
styfle
styfle reviewed Dec 22, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
styfle
styfle reviewed Dec 22, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
styfle
styfle reviewed Dec 22, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
styfle
styfle reviewed Dec 22, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
styfle
styfle reviewed Dec 22, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
styfle
styfle reviewed Dec 23, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
styfle
styfle reviewed Dec 23, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
leerob
leerob commented Dec 23, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
@leerob @styfle
Apply suggestions from code review
66fd0dd 
Co-authored-by: Steven <steven@ceriously.com>
ijjk
ijjk reviewed Dec 23, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to link to the new standalone output mode mentioning they can try it out https://nextjs.org/docs/advanced-features/output-file-tracing#automatically-copying-traced-files-experimental as this is what we ideally want to replace using next start in production in custom deployments.

ijjk
ijjk reviewed Dec 23, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
ijjk
ijjk reviewed Dec 23, 2021
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
leerob
leerob commented Jan 5, 2022
View reviewed changes
docs/deployment.md Outdated Show resolved Hide resolved
leerob and others added 2 commits January 5, 2022 14:21
@leerob
Update docs/deployment.md
f5066e0
@leerob @ijjk
Update docs/deployment.md
e54938f 
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@leerob
Copy link
Member Author

leerob commented Jan 5, 2022

@ijjk once that moves out of experimental, yes!

Ready for review again 👍

@kodiakhq kodiakhq bot merged commit 26ddf32 into canary Jan 5, 2022
@kodiakhq kodiakhq bot deleted the deployment-docs branch January 5, 2022 21:56
teleaziz added a commit to teleaziz/next.js that referenced this pull request Jan 11, 2022
@teleaziz
Merge branch 'cms-builder-io-example' of github.com:teleaziz/next.js …
ce988af 
…into cms-builder-io-example

* 'cms-builder-io-example' of github.com:teleaziz/next.js: (22 commits)
  drop dynamic import with `ssr: false` on server-side (vercel#32606)
  next-swc: fix ssg code elimination when used in render (vercel#32709)
  Add Caveats section to custom error page (vercel#33160)
  v12.0.8-canary.20
  Allow dependencies to use environment variables in middlewares (vercel#33141)
  use a separate webpack runtime for middleware (vercel#33134)
  No info on environment variables in the src folder (vercel#33110) (vercel#33136)
  docs: minor text-copy cleanup (vercel#33120)
  Update swc (vercel#33063)
  Update next.config.js (vercel#33091)
  Adding Asset Component for Rich Text Renderer (vercel#32503)
  Update using-mdx.md (vercel#33077)
  v12.0.8-canary.19
  Fix middleware at root in standalone mode (vercel#33053)
  Add util for generating new tests/error documents (vercel#33001)
  Remove extra config from tailwind example (vercel#33062)
  Fix link for Next.js Analytics in docs (vercel#33049)
  Bump `@vercel/nft` to 0.17.2 (vercel#33048)
  Update deployment documentation. (vercel#32006)
  v12.0.8-canary.18
  ...
@vercel vercel locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens left review comments

@styfle styfle styfle left review comments

@ijjk ijjk ijjk approved these changes

@molebox molebox molebox left review comments

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leerob @styfle @timneutkens @ijjk @molebox