Add Caveats section to custom error page #33160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glenngijsberts
requested review from
huozhi,
ijjk,
leerob,
padmaia,
shuding,
styfle and
timneutkens
as code owners
teleaziz
added a commit
to teleaziz/next.js
that referenced
this pull request
Jan 11, 2022
…into cms-builder-io-example * 'cms-builder-io-example' of github.com:teleaziz/next.js: (22 commits) drop dynamic import with `ssr: false` on server-side (vercel#32606) next-swc: fix ssg code elimination when used in render (vercel#32709) Add Caveats section to custom error page (vercel#33160) v12.0.8-canary.20 Allow dependencies to use environment variables in middlewares (vercel#33141) use a separate webpack runtime for middleware (vercel#33134) No info on environment variables in the src folder (vercel#33110) (vercel#33136) docs: minor text-copy cleanup (vercel#33120) Update swc (vercel#33063) Update next.config.js (vercel#33091) Adding Asset Component for Rich Text Renderer (vercel#32503) Update using-mdx.md (vercel#33077) v12.0.8-canary.19 Fix middleware at root in standalone mode (vercel#33053) Add util for generating new tests/error documents (vercel#33001) Remove extra config from tailwind example (vercel#33062) Fix link for Next.js Analytics in docs (vercel#33049) Bump `@vercel/nft` to 0.17.2 (vercel#33048) Update deployment documentation. (vercel#32006) v12.0.8-canary.18 ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desscription
This is a follow up of #32873. As discussed in #32873, currently it's not recommended to use getServerSideProps in the
Errorcomponent, so this PR will add that caveat to the documentation page, likeDocumentandAppalso have.Documentation / Examples
yarn lint