Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dependencies to use environment variables in middlewares #33141

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Allow dependencies to use environment variables in middlewares #33141

merged 4 commits into from
Jan 10, 2022

Conversation

Schniz
Copy link
Contributor

@Schniz Schniz commented Jan 10, 2022

After discussing with @sokra, seems that the proposed solution is split in two:

  • We need to make sure that the process polyfill uses global.process if available. This is because middlewares are bundled using browser target and therefore process.env.MY_ENV gets shimmed into require('process').env.MY_ENV.

  • Allow process.env to be statically analyzed for dependencies so they will be exported to the manifest.

Related issues:

Schniz added 2 commits January 10, 2022 13:39
@Schniz
Allow dependencies to use environment variables in middlewares
6234605 
After discussing with @sokra, seems that the proposed solution is split in two:

* We need to make sure that the `process` polyfill uses `global.process` if available. This is because middlewares are bundled using `browser` target and therefore `process.env.MY_ENV` gets shimmed into `require('process').env.MY_ENV`.

* Allow `process.env` to be statically analyzed for dependencies so they
  will be exported to the manifest.

Related issues:

* should fix vercel#33043.
@Schniz
Add a test that verifies the changes
9988e92
@ijjk

This comment has been minimized.

Sign in to view
sokra
sokra previously approved these changes Jan 10, 2022
View reviewed changes
packages/next/build/polyfills/process.js Outdated Show resolved Hide resolved
@balazsorban44 balazsorban44 mentioned this pull request Jan 10, 2022
Closed
@Schniz @sokra
Update packages/next/build/polyfills/process.js
f2cc463 
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
@ijjk

This comment has been minimized.

Sign in to view
ijjk
ijjk approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change and added test look good, thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Jan 10, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Schniz/next.js fix-33043 Change
buildDuration 14.3s 14.4s ⚠️ +42ms
buildDurationCached 3.2s 3.2s ⚠️ +53ms
nodeModulesSize 355 MB 355 MB ⚠️ +256 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Schniz/next.js fix-33043 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.873 2.883 ⚠️ +0.01
/ avg req/sec 870.27 867.28 ⚠️ -2.99
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.307 1.338 ⚠️ +0.03
/error-in-render avg req/sec 1912.05 1868.81 ⚠️ -43.24
Client Bundles (main, webpack, commons)
vercel/next.js canary Schniz/next.js fix-33043 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.1 kB 27.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.9 kB 70.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Schniz/next.js fix-33043 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Schniz/next.js fix-33043 Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.74 kB 4.74 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary Schniz/next.js fix-33043 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary Schniz/next.js fix-33043 Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Schniz/next.js fix-33043 Change
buildDuration 15.9s 15.9s -16ms
buildDurationCached 3.2s 3.2s ⚠️ +14ms
nodeModulesSize 355 MB 355 MB ⚠️ +256 B
Page Load Tests Overall increase ✓
vercel/next.js canary Schniz/next.js fix-33043 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.927 2.911 -0.02
/ avg req/sec 854.22 858.81 +4.59
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.328 1.31 -0.02
/error-in-render avg req/sec 1882.39 1907.99 +25.6
Client Bundles (main, webpack, commons)
vercel/next.js canary Schniz/next.js fix-33043 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.1 kB 71.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Schniz/next.js fix-33043 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Schniz/next.js fix-33043 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.76 kB 4.76 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary Schniz/next.js fix-33043 Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary Schniz/next.js fix-33043 Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: d54db0c

@kodiakhq kodiakhq bot merged commit 4aa9879 into vercel:canary Jan 10, 2022
@Schniz Schniz deleted the fix-33043 branch January 11, 2022 10:25
teleaziz added a commit to teleaziz/next.js that referenced this pull request Jan 11, 2022
@teleaziz
Merge branch 'cms-builder-io-example' of github.com:teleaziz/next.js …
ce988af 
…into cms-builder-io-example

* 'cms-builder-io-example' of github.com:teleaziz/next.js: (22 commits)
  drop dynamic import with `ssr: false` on server-side (vercel#32606)
  next-swc: fix ssg code elimination when used in render (vercel#32709)
  Add Caveats section to custom error page (vercel#33160)
  v12.0.8-canary.20
  Allow dependencies to use environment variables in middlewares (vercel#33141)
  use a separate webpack runtime for middleware (vercel#33134)
  No info on environment variables in the src folder (vercel#33110) (vercel#33136)
  docs: minor text-copy cleanup (vercel#33120)
  Update swc (vercel#33063)
  Update next.config.js (vercel#33091)
  Adding Asset Component for Rich Text Renderer (vercel#32503)
  Update using-mdx.md (vercel#33077)
  v12.0.8-canary.19
  Fix middleware at root in standalone mode (vercel#33053)
  Add util for generating new tests/error documents (vercel#33001)
  Remove extra config from tailwind example (vercel#33062)
  Fix link for Next.js Analytics in docs (vercel#33049)
  Bump `@vercel/nft` to 0.17.2 (vercel#33048)
  Update deployment documentation. (vercel#32006)
  v12.0.8-canary.18
  ...
@balazsorban44 balazsorban44 mentioned this pull request Feb 4, 2022
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@sokra sokra sokra left review comments

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packages used in middleware can't read env vars >=12.05
3 participants
@Schniz @ijjk @sokra