-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve error reporting for fatal errors #3550
improve error reporting for fatal errors #3550
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
Benchmark for 8061adeClick to view benchmark
|
|
Benchmark for 05e7a9fClick to view benchmark
|
Benchmark for fc1f40dClick to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guessing you need to pull in main. Bunch of turborepo tests being deleted and version number changing
2727379
to
47c05ad
Compare
yeah, something weird happened here... should be fixed now... |
Benchmark for 5a4e902
Click to view full benchmark
|
…49736102+kodiakhq[bot]@users.noreply.github.com> # New Features - vercel/turborepo#3540 - vercel/turborepo#3549 - vercel/turborepo#3465 - vercel/turborepo#3550 - vercel/turborepo#3495 - vercel/turborepo#3624 - vercel/turborepo#3600 - vercel/turborepo#3676 - vercel/turborepo#3689 # Fixes - vercel/turborepo#3437 - vercel/turborepo#3542 - vercel/turborepo#3531 - vercel/turborepo#3552 - vercel/turborepo#3551 - vercel/turborepo#3597 - vercel/turborepo#3644 - vercel/turborepo#3623 - vercel/turborepo#3634 - vercel/turborepo#3574 - vercel/turborepo#3673 - vercel/turborepo#3675 - vercel/turborepo#3723 - vercel/turborepo#3677 - vercel/turborepo#3717 - vercel/turborepo#3701 # Performance Improvements - vercel/turborepo#3361 - vercel/turborepo#3619 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This adds the turbo-tasks function name as `context` of all fatal errors propagated from executing or reading turbo-tasks functions. That should help in debugging fatal errors.
This adds the turbo-tasks function name as `context` of all fatal errors propagated from executing or reading turbo-tasks functions. That should help in debugging fatal errors.
The issue message emitted by `TryDotenvProcessEnv` was pretty bad: `Execution of TryDotenvProcessEnv::read_all failed`. This error message comes from #3550, which attaches the calling function as the context for every failed turbo function. This PR accomplishes 2 main things: 1. Expose an explicit method determining whether a the `DotenvEnvProcess`'s prior or current env failed 2. Detects a current env failure and uses the error's root cause for the issue message. <img width="961" alt="Screen Shot 2023-04-04 at 7 29 52 PM" src="https://user-images.githubusercontent.com/112982/229944525-d39dbe87-778a-4421-9bc8-632924cd3782.png"> Fixes WEB-851 Tests: vercel/next.js#47937
This adds the turbo-tasks function name as `context` of all fatal errors propagated from executing or reading turbo-tasks functions. That should help in debugging fatal errors.
This adds the turbo-tasks function name as `context` of all fatal errors propagated from executing or reading turbo-tasks functions. That should help in debugging fatal errors.
This adds the turbo-tasks function name as `context` of all fatal errors propagated from executing or reading turbo-tasks functions. That should help in debugging fatal errors.
This adds the turbo-tasks function name as
context
of all fatal errors propagated from executing or reading turbo-tasks functions.That should help in debugging fatal errors.