Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set nextExport flag for page rendering #3717

Merged
merged 1 commit into from
Feb 9, 2023
Merged

set nextExport flag for page rendering #3717

merged 1 commit into from
Feb 9, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 9, 2023

Otherwise router.isReady will never be true for pages without gSSP, gSP or gIP

@vercel
Copy link

vercel bot commented Feb 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 9, 2023 at 0:57AM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 9, 2023 at 0:57AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 9, 2023 at 0:57AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 9, 2023 at 0:57AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 9, 2023 at 0:57AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 9, 2023 at 0:57AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 9, 2023 at 0:57AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 9, 2023 at 0:57AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 9, 2023 at 0:57AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 9, 2023 at 0:57AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra marked this pull request as ready for review February 9, 2023 13:56
@sokra sokra requested a review from a team as a code owner February 9, 2023 13:56
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Benchmark for c73fa55

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9029.09µs ± 96.69µs 9002.73µs ± 72.43µs -0.29%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9501.48µs ± 181.29µs 9344.75µs ± 94.27µs -1.65%
bench_hmr_to_commit/Turbopack RSC/1000 modules 489.06ms ± 2.29ms 483.41ms ± 1.82ms -1.16%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9359.17µs ± 91.68µs 9238.36µs ± 85.91µs -1.29%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8058.84µs ± 75.32µs 8169.10µs ± 76.62µs +1.37%
bench_hmr_to_eval/Turbopack RCC/1000 modules 8302.25µs ± 90.90µs 8376.76µs ± 55.91µs +0.90%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8239.11µs ± 61.76µs 8220.81µs ± 62.54µs -0.22%
bench_hydration/Turbopack RCC/1000 modules 4137.25ms ± 12.98ms 4169.35ms ± 8.31ms +0.78%
bench_hydration/Turbopack RSC/1000 modules 3729.05ms ± 19.36ms 3768.22ms ± 20.45ms +1.05%
bench_hydration/Turbopack SSR/1000 modules 3657.90ms ± 8.38ms 3634.50ms ± 18.62ms -0.64%
bench_startup/Turbopack CSR/1000 modules 2736.03ms ± 6.76ms 2762.37ms ± 17.38ms +0.96%
bench_startup/Turbopack RCC/1000 modules 2535.62ms ± 5.02ms 2532.07ms ± 5.06ms -0.14%
bench_startup/Turbopack RSC/1000 modules 2407.90ms ± 6.76ms 2421.47ms ± 10.54ms +0.56%
bench_startup/Turbopack SSR/1000 modules 2087.80ms ± 3.50ms 2086.65ms ± 3.92ms -0.06%

@sokra sokra added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 9, 2023
@kodiakhq kodiakhq bot merged commit e282ba1 into main Feb 9, 2023
@kodiakhq kodiakhq bot deleted the sokra/fix-router-ready branch February 9, 2023 20:30
@jridgewell jridgewell mentioned this pull request Feb 10, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Feb 10, 2023
@Brooooooklyn @kodiakhq
Update turbopack to 230209.02 (#45776)Co-authored-by: kodiakhq[bot] <…
946ccb0 
…49736102+kodiakhq[bot]@users.noreply.github.com>

# New Features
- vercel/turborepo#3540
- vercel/turborepo#3549
- vercel/turborepo#3465
- vercel/turborepo#3550
- vercel/turborepo#3495
- vercel/turborepo#3624
- vercel/turborepo#3600
- vercel/turborepo#3676
- vercel/turborepo#3689

# Fixes

- vercel/turborepo#3437
- vercel/turborepo#3542
- vercel/turborepo#3531
- vercel/turborepo#3552
- vercel/turborepo#3551
- vercel/turborepo#3597
- vercel/turborepo#3644
- vercel/turborepo#3623
- vercel/turborepo#3634
- vercel/turborepo#3574
- vercel/turborepo#3673
- vercel/turborepo#3675
- vercel/turborepo#3723
- vercel/turborepo#3677
- vercel/turborepo#3717
- vercel/turborepo#3701

# Performance Improvements

- vercel/turborepo#3361 
- vercel/turborepo#3619

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@sokra
set nextExport flag for page rendering (vercel/turborepo#3717)
454ea15 
Otherwise `router.isReady` will never be true for pages without gSSP, gSP or gIP
sokra added a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@sokra
set nextExport flag for page rendering (vercel/turborepo#3717)
40a49f4 
Otherwise `router.isReady` will never be true for pages without gSSP, gSP or gIP
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
set nextExport flag for page rendering (vercel/turborepo#3717)
dd2ade3 
Otherwise `router.isReady` will never be true for pages without gSSP, gSP or gIP
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
set nextExport flag for page rendering (vercel/turborepo#3717)
47eff0d 
Otherwise `router.isReady` will never be true for pages without gSSP, gSP or gIP
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
set nextExport flag for page rendering (vercel/turborepo#3717)
2a3b01c 
Otherwise `router.isReady` will never be true for pages without gSSP, gSP or gIP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @alexkirsz