Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix glob parsing and improve error reporting #3644

Merged
merged 1 commit into from
Feb 6, 2023
Merged

fix glob parsing and improve error reporting #3644

merged 1 commit into from
Feb 6, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 6, 2023

Our glob parser was not able to parse alternatives that contain a slash: {a/b}

@sokra sokra requested a review from a team as a code owner February 6, 2023 07:07
@vercel
Copy link

vercel bot commented Feb 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 7:08AM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 7:08AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 7:08AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 6, 2023 at 7:08AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 6, 2023 at 7:08AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 7:08AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 6, 2023 at 7:08AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 7:08AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 7:08AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 7:08AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Benchmark for 7f10a5c

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack RCC/1000 modules 8686.47µs ± 73.08µs 9177.16µs ± 111.93µs +5.65% +1.37%
bench_hydration/Turbopack RCC/1000 modules 4352.37ms ± 30.38ms 4250.31ms ± 13.83ms -2.34% -0.32%
bench_startup/Turbopack RCC/1000 modules 2574.40ms ± 13.25ms 2662.64ms ± 24.13ms +3.43% +0.52%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9459.29µs ± 69.00µs 9425.15µs ± 104.95µs -0.36%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9961.99µs ± 95.71µs 9866.00µs ± 130.11µs -0.96%
bench_hmr_to_commit/Turbopack RSC/1000 modules 495.22ms ± 1.07ms 490.84ms ± 3.88ms -0.89%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9966.58µs ± 107.81µs 9732.27µs ± 69.55µs -2.35%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8517.25µs ± 52.96µs 8427.92µs ± 83.79µs -1.05%
bench_hmr_to_eval/Turbopack RCC/1000 modules 8686.47µs ± 73.08µs 9177.16µs ± 111.93µs +5.65% +1.37%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8595.45µs ± 59.78µs 8724.64µs ± 117.76µs +1.50%
bench_hydration/Turbopack RCC/1000 modules 4352.37ms ± 30.38ms 4250.31ms ± 13.83ms -2.34% -0.32%
bench_hydration/Turbopack RSC/1000 modules 3801.02ms ± 19.46ms 3765.34ms ± 15.37ms -0.94%
bench_hydration/Turbopack SSR/1000 modules 3604.60ms ± 21.68ms 3624.77ms ± 5.56ms +0.56%
bench_startup/Turbopack CSR/1000 modules 2764.70ms ± 9.89ms 2771.96ms ± 16.58ms +0.26%
bench_startup/Turbopack RCC/1000 modules 2574.40ms ± 13.25ms 2662.64ms ± 24.13ms +3.43% +0.52%
bench_startup/Turbopack RSC/1000 modules 2493.29ms ± 12.10ms 2483.73ms ± 7.73ms -0.38%
bench_startup/Turbopack SSR/1000 modules 2038.21ms ± 3.55ms 2042.65ms ± 4.93ms +0.22%

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests

See workflow summary for details

@sokra sokra merged commit 54df174 into main Feb 6, 2023
@sokra sokra deleted the sokra/fix-glob branch February 6, 2023 10:16
@jridgewell jridgewell mentioned this pull request Feb 10, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Feb 10, 2023
@Brooooooklyn @kodiakhq
Update turbopack to 230209.02 (#45776)Co-authored-by: kodiakhq[bot] <…
946ccb0 
…49736102+kodiakhq[bot]@users.noreply.github.com>

# New Features
- vercel/turborepo#3540
- vercel/turborepo#3549
- vercel/turborepo#3465
- vercel/turborepo#3550
- vercel/turborepo#3495
- vercel/turborepo#3624
- vercel/turborepo#3600
- vercel/turborepo#3676
- vercel/turborepo#3689

# Fixes

- vercel/turborepo#3437
- vercel/turborepo#3542
- vercel/turborepo#3531
- vercel/turborepo#3552
- vercel/turborepo#3551
- vercel/turborepo#3597
- vercel/turborepo#3644
- vercel/turborepo#3623
- vercel/turborepo#3634
- vercel/turborepo#3574
- vercel/turborepo#3673
- vercel/turborepo#3675
- vercel/turborepo#3723
- vercel/turborepo#3677
- vercel/turborepo#3717
- vercel/turborepo#3701

# Performance Improvements

- vercel/turborepo#3361 
- vercel/turborepo#3619

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
fix glob parsing and improve error reporting (vercel/turborepo#3644)
055403c 
Our glob parser was not able to parse alternatives that contain a slash:
`{a/b}`
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix glob parsing and improve error reporting (vercel/turborepo#3644)
d86436c 
Our glob parser was not able to parse alternatives that contain a slash:
`{a/b}`
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
fix glob parsing and improve error reporting (vercel/turborepo#3644)
61c896c 
Our glob parser was not able to parse alternatives that contain a slash:
`{a/b}`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @alexkirsz