Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose module_options and resolve_options in turbotrace #3839

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Expose module_options and resolve_options in turbotrace #3839

merged 2 commits into from
Mar 2, 2023

Conversation

Brooooooklyn
Copy link
Contributor

@Brooooooklyn Brooooooklyn commented Feb 16, 2023 •
edited
Loading

This pr allows passing ModuleOptionsContext and ResolveOptionsContext in fn start, so next.js can pass enableJsx: true, enableTypes: true while tracing entries, and enableJsx: false, enableTypes: false while tracing compiled files.

@Brooooooklyn Brooooooklyn requested a review from a team as a code owner February 16, 2023 11:43
@vercel
Copy link

vercel bot commented Feb 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-designsystem-docs 🔄 Building (Inspect) Mar 2, 2023 at 1:34PM (UTC)
examples-svelte-web 🔄 Building (Inspect) Mar 2, 2023 at 1:34PM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Mar 2, 2023 at 1:34PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Mar 2, 2023 at 1:34PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 2, 2023 at 1:34PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Mar 2, 2023 at 1:34PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Mar 2, 2023 at 1:34PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 2, 2023 at 1:34PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Mar 2, 2023 at 1:34PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Mar 2, 2023 at 1:34PM (UTC)

@Brooooooklyn Brooooooklyn requested a review from sokra February 16, 2023 11:50
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@github-actions
Copy link
Contributor

Benchmark for db9d852

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9588.20µs ± 90.23µs 9616.00µs ± 49.55µs +0.29%
bench_hmr_to_commit/Turbopack RCC/1000 modules 11.72ms ± 0.27ms 11.77ms ± 0.25ms +0.43%
bench_hmr_to_commit/Turbopack RSC/1000 modules 513.68ms ± 1.40ms 517.11ms ± 2.54ms +0.67%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9669.55µs ± 85.87µs 9772.50µs ± 75.93µs +1.06%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8604.78µs ± 33.54µs 8607.00µs ± 49.92µs +0.03%
bench_hmr_to_eval/Turbopack RCC/1000 modules 10.26ms ± 0.12ms 10.43ms ± 0.13ms +1.68%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8675.07µs ± 93.50µs 8703.47µs ± 95.49µs +0.33%
bench_hydration/Turbopack RCC/1000 modules 3928.67ms ± 28.10ms 3933.49ms ± 28.59ms +0.12%
bench_hydration/Turbopack RSC/1000 modules 3413.94ms ± 10.96ms 3445.75ms ± 12.02ms +0.93%
bench_hydration/Turbopack SSR/1000 modules 3578.56ms ± 19.54ms 3558.15ms ± 14.93ms -0.57%
bench_startup/Turbopack CSR/1000 modules 2809.03ms ± 16.84ms 2767.90ms ± 8.79ms -1.46%
bench_startup/Turbopack RCC/1000 modules 2318.07ms ± 6.17ms 2313.95ms ± 3.66ms -0.18%
bench_startup/Turbopack RSC/1000 modules 2247.92ms ± 9.86ms 2259.48ms ± 7.04ms +0.51%
bench_startup/Turbopack SSR/1000 modules 2128.12ms ± 1.73ms 2132.96ms ± 2.33ms +0.23%

sokra
sokra requested changes Feb 17, 2023
View reviewed changes
crates/node-file-trace/src/lib.rs Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Benchmark for dd3d7cf

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9473.85µs ± 69.96µs 9378.27µs ± 66.34µs -1.01%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.75ms ± 0.19ms 13.29ms ± 0.12ms +4.29%
bench_hmr_to_commit/Turbopack RSC/1000 modules 494.91ms ± 1.98ms 491.16ms ± 1.95ms -0.76%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9591.86µs ± 65.89µs 9517.16µs ± 72.24µs -0.78%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8482.90µs ± 40.07µs 8424.37µs ± 68.29µs -0.69%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.82ms ± 0.10ms 11.09ms ± 0.32ms -6.23%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8540.07µs ± 71.88µs 8606.08µs ± 94.79µs +0.77%
bench_hydration/Turbopack RCC/1000 modules 3664.08ms ± 16.02ms 3692.91ms ± 17.97ms +0.79%
bench_hydration/Turbopack RSC/1000 modules 3313.57ms ± 10.33ms 3300.66ms ± 11.26ms -0.39%
bench_hydration/Turbopack SSR/1000 modules 3378.81ms ± 12.68ms 3396.64ms ± 20.60ms +0.53%
bench_startup/Turbopack CSR/1000 modules 2656.82ms ± 9.04ms 2633.78ms ± 10.06ms -0.87%
bench_startup/Turbopack RCC/1000 modules 2254.25ms ± 2.61ms 2255.34ms ± 3.78ms +0.05%
bench_startup/Turbopack RSC/1000 modules 2172.26ms ± 6.01ms 2172.34ms ± 4.13ms +0.00%
bench_startup/Turbopack SSR/1000 modules 2056.86ms ± 2.33ms 2055.19ms ± 3.33ms -0.08%

@github-actions
Copy link
Contributor

Benchmark for ec2406d

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 11.47ms ± 0.09ms 11.44ms ± 0.09ms -0.21%
bench_hmr_to_commit/Turbopack RCC/1000 modules 15.72ms ± 0.22ms 15.58ms ± 0.21ms -0.89%
bench_hmr_to_commit/Turbopack RSC/1000 modules 504.10ms ± 1.80ms 509.18ms ± 2.19ms +1.01%
bench_hmr_to_commit/Turbopack SSR/1000 modules 11.48ms ± 0.08ms 11.39ms ± 0.08ms -0.74%
bench_hmr_to_eval/Turbopack CSR/1000 modules 10.48ms ± 0.11ms 10.44ms ± 0.08ms -0.43%
bench_hmr_to_eval/Turbopack RCC/1000 modules 14.28ms ± 0.10ms 14.24ms ± 0.19ms -0.29%
bench_hmr_to_eval/Turbopack SSR/1000 modules 10.44ms ± 0.10ms 10.49ms ± 0.08ms +0.45%
bench_hydration/Turbopack RCC/1000 modules 3810.54ms ± 14.43ms 3796.37ms ± 11.46ms -0.37%
bench_hydration/Turbopack RSC/1000 modules 3441.33ms ± 14.10ms 3487.24ms ± 32.64ms +1.33%
bench_hydration/Turbopack SSR/1000 modules 3309.25ms ± 9.87ms 3334.93ms ± 9.71ms +0.78%
bench_startup/Turbopack CSR/1000 modules 2548.08ms ± 8.27ms 2524.62ms ± 12.61ms -0.92%
bench_startup/Turbopack RCC/1000 modules 2322.96ms ± 4.57ms 2317.29ms ± 4.45ms -0.24%
bench_startup/Turbopack RSC/1000 modules 2287.58ms ± 13.38ms 2266.86ms ± 5.62ms -0.91%
bench_startup/Turbopack SSR/1000 modules 2050.90ms ± 5.16ms 2039.99ms ± 3.04ms -0.53%

@Brooooooklyn Brooooooklyn requested a review from jridgewell March 1, 2023 07:07
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Benchmark for bed82f6

Test Base PR % Significant %
bench_hydration/Turbopack RSC/1000 modules 3592.77ms ± 13.53ms 3525.55ms ± 8.08ms -1.87% -0.67%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9272.37µs ± 40.64µs 9253.04µs ± 24.13µs -0.21%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.72ms ± 0.25ms 12.46ms ± 0.23ms -2.06%
bench_hmr_to_commit/Turbopack RSC/1000 modules 505.97ms ± 0.73ms 504.46ms ± 2.48ms -0.30%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9293.73µs ± 45.08µs 9366.15µs ± 33.31µs +0.78%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8267.65µs ± 24.54µs 8310.44µs ± 49.35µs +0.52%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.36ms ± 0.22ms 11.35ms ± 0.19ms -0.10%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8282.79µs ± 41.97µs 8290.59µs ± 53.51µs +0.09%
bench_hydration/Turbopack RCC/1000 modules 3923.47ms ± 9.74ms 3931.55ms ± 11.06ms +0.21%
bench_hydration/Turbopack RSC/1000 modules 3592.77ms ± 13.53ms 3525.55ms ± 8.08ms -1.87% -0.67%
bench_hydration/Turbopack SSR/1000 modules 3401.29ms ± 20.36ms 3408.82ms ± 12.96ms +0.22%
bench_startup/Turbopack CSR/1000 modules 2577.09ms ± 7.57ms 2632.19ms ± 35.50ms +2.14%
bench_startup/Turbopack RCC/1000 modules 2404.19ms ± 12.01ms 2384.43ms ± 10.37ms -0.82%
bench_startup/Turbopack RSC/1000 modules 2357.93ms ± 9.42ms 2346.67ms ± 13.53ms -0.48%
bench_startup/Turbopack SSR/1000 modules 2074.96ms ± 8.40ms 2094.87ms ± 9.68ms +0.96%

jridgewell
jridgewell approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, one last blocking comment

crates/node-file-trace/src/lib.rs Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Benchmark for be0f0f0

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack RSC/1000 modules 475.24ms ± 1.56ms 492.07ms ± 2.92ms +3.54% +1.64%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8188.14µs ± 39.91µs 7864.45µs ± 69.83µs -3.95% -1.29%
bench_hydration/Turbopack SSR/1000 modules 3234.75ms ± 5.31ms 3268.74ms ± 6.25ms +1.05% +0.33%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8487.93µs ± 41.73µs 8383.68µs ± 34.73µs -1.23%
bench_hmr_to_commit/Turbopack RCC/1000 modules 13.08ms ± 0.16ms 13.16ms ± 0.12ms +0.63%
bench_hmr_to_commit/Turbopack RSC/1000 modules 475.24ms ± 1.56ms 492.07ms ± 2.92ms +3.54% +1.64%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8596.68µs ± 46.24µs 8569.16µs ± 52.23µs -0.32%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7603.93µs ± 54.64µs 7613.77µs ± 47.26µs +0.13%
bench_hmr_to_eval/Turbopack RCC/1000 modules 12.09ms ± 0.10ms 11.78ms ± 0.14ms -2.58%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8188.14µs ± 39.91µs 7864.45µs ± 69.83µs -3.95% -1.29%
bench_hydration/Turbopack RCC/1000 modules 3517.12ms ± 6.56ms 3509.57ms ± 8.29ms -0.21%
bench_hydration/Turbopack RSC/1000 modules 3171.05ms ± 12.67ms 3165.66ms ± 11.66ms -0.17%
bench_hydration/Turbopack SSR/1000 modules 3234.75ms ± 5.31ms 3268.74ms ± 6.25ms +1.05% +0.33%
bench_startup/Turbopack CSR/1000 modules 2524.49ms ± 5.11ms 2539.85ms ± 6.70ms +0.61%
bench_startup/Turbopack RCC/1000 modules 2096.40ms ± 4.26ms 2106.25ms ± 4.82ms +0.47%
bench_startup/Turbopack RSC/1000 modules 2005.95ms ± 5.16ms 2006.09ms ± 6.66ms +0.01%
bench_startup/Turbopack SSR/1000 modules 2023.32ms ± 2.89ms 2021.72ms ± 4.15ms -0.08%

@Brooooooklyn Brooooooklyn merged commit ff4b9d1 into main Mar 2, 2023
@Brooooooklyn Brooooooklyn deleted the expose-options branch March 2, 2023 16:28
@jridgewell jridgewell mentioned this pull request Mar 2, 2023
Merged
This was referenced Mar 7, 2023
Closed
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Mar 8, 2023
@kdy1
Update turbopack to 230308.1 (#46909)
37b0349 
## Bugfixes

 - vercel/turborepo#3526
 - vercel/turborepo#4084
 - vercel/turborepo#4083
 - vercel/turborepo#4067
 - vercel/turborepo#3959
 - vercel/turborepo#4060
 - vercel/turborepo#4081
 - vercel/turborepo#4103
 - vercel/turborepo#4100
 - vercel/turborepo#4108
 - vercel/turborepo#4101
 - vercel/turborepo#4112
 - vercel/turborepo#3956
 - vercel/turborepo#4118
 - vercel/turborepo#4117

## Feature

 - vercel/turborepo#4058
  - vercel/turborepo#4013
  - vercel/turborepo#4005
  - vercel/turborepo#4001
  - vercel/turborepo#3839
  - vercel/turborepo#4017
  - vercel/turborepo#4086
  - vercel/turborepo#4067

## Performance

  - vercel/turborepo#4040
  - vercel/turborepo#4110

## Refactor

 - vercel/turborepo#4098
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@Brooooooklyn
Expose module_options and resolve_options in turbotrace (vercel/turbo…
efab71a 
…repo#3839)

This pr allows passing `ModuleOptionsContext` and
`ResolveOptionsContext` in fn start, so next.js can pass enableJsx:
true, enableTypes: true while tracing entries, and `enableJsx: false`,
`enableTypes: false` while tracing compiled files.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@Brooooooklyn
Expose module_options and resolve_options in turbotrace (vercel/turbo…
f8055a0 
…repo#3839)

This pr allows passing `ModuleOptionsContext` and
`ResolveOptionsContext` in fn start, so next.js can pass enableJsx:
true, enableTypes: true while tracing entries, and `enableJsx: false`,
`enableTypes: false` while tracing compiled files.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@Brooooooklyn
Expose module_options and resolve_options in turbotrace (vercel/turbo…
bc35d24 
…repo#3839)

This pr allows passing `ModuleOptionsContext` and
`ResolveOptionsContext` in fn start, so next.js can pass enableJsx:
true, enableTypes: true while tracing entries, and `enableJsx: false`,
`enableTypes: false` while tracing compiled files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra requested changes

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Brooooooklyn @jridgewell @sokra