Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inject swc helpers #4060

Merged
merged 2 commits into from
Mar 4, 2023
Merged

inject swc helpers #4060

merged 2 commits into from
Mar 4, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 3, 2023

Description

This fixed the _extends is not defined issue.

@vercel
Copy link

vercel bot commented Mar 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-designsystem-docs 🔄 Building (Inspect) Mar 3, 2023 at 10:16AM (UTC)
turbo-site 🔄 Building (Inspect) Visit Preview Mar 3, 2023 at 10:16AM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Mar 3, 2023 at 10:16AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Mar 3, 2023 at 10:16AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 3, 2023 at 10:16AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Mar 3, 2023 at 10:16AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Mar 3, 2023 at 10:16AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Mar 3, 2023 at 10:16AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 3, 2023 at 10:16AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Mar 3, 2023 at 10:16AM (UTC)

@sokra sokra requested a review from ForsakenHarmony March 3, 2023 08:33
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Benchmark for ff301b2

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9100.38µs ± 45.80µs 9053.38µs ± 34.02µs -0.52%
bench_hmr_to_commit/Turbopack RCC/1000 modules 13.14ms ± 0.11ms 12.61ms ± 0.24ms -4.03%
bench_hmr_to_commit/Turbopack RSC/1000 modules 503.54ms ± 1.85ms 503.44ms ± 1.44ms -0.02%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9231.13µs ± 40.89µs 9243.83µs ± 38.19µs +0.14%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8106.10µs ± 24.40µs 8092.22µs ± 55.64µs -0.17%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.97ms ± 0.14ms 12.00ms ± 0.14ms +0.23%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8307.92µs ± 55.19µs 8318.48µs ± 62.15µs +0.13%
bench_hydration/Turbopack RCC/1000 modules 3618.62ms ± 15.15ms 3618.23ms ± 13.03ms -0.01%
bench_hydration/Turbopack RSC/1000 modules 3244.20ms ± 8.61ms 3224.74ms ± 9.40ms -0.60%
bench_hydration/Turbopack SSR/1000 modules 3319.96ms ± 9.91ms 3326.61ms ± 9.92ms +0.20%
bench_startup/Turbopack CSR/1000 modules 2586.89ms ± 9.24ms 2569.46ms ± 7.88ms -0.67%
bench_startup/Turbopack RCC/1000 modules 2137.94ms ± 2.81ms 2134.44ms ± 5.80ms -0.16%
bench_startup/Turbopack RSC/1000 modules 2060.45ms ± 6.19ms 2086.04ms ± 9.44ms +1.24%
bench_startup/Turbopack SSR/1000 modules 2053.58ms ± 4.63ms 2063.22ms ± 4.67ms +0.47%

@sokra sokra marked this pull request as ready for review March 3, 2023 10:15
@sokra sokra requested a review from a team as a code owner March 3, 2023 10:15
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Benchmark for c098125

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9642.46µs ± 44.53µs 9676.45µs ± 34.89µs +0.35%
bench_hmr_to_commit/Turbopack RCC/1000 modules 13.47ms ± 0.12ms 13.88ms ± 0.13ms +3.03%
bench_hmr_to_commit/Turbopack RSC/1000 modules 509.69ms ± 1.64ms 507.94ms ± 1.52ms -0.34%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9917.53µs ± 17.78µs 9895.87µs ± 62.54µs -0.22%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8783.58µs ± 36.59µs 8701.64µs ± 41.38µs -0.93%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.79ms ± 0.24ms 12.41ms ± 0.21ms +5.28%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8812.85µs ± 18.94µs 8838.15µs ± 51.36µs +0.29%
bench_hydration/Turbopack RCC/1000 modules 3637.49ms ± 11.41ms 3633.17ms ± 12.60ms -0.12%
bench_hydration/Turbopack RSC/1000 modules 3275.62ms ± 12.96ms 3298.87ms ± 14.95ms +0.71%
bench_hydration/Turbopack SSR/1000 modules 3331.48ms ± 8.99ms 3352.43ms ± 6.69ms +0.63%
bench_startup/Turbopack CSR/1000 modules 2597.47ms ± 6.61ms 2579.68ms ± 3.74ms -0.68%
bench_startup/Turbopack RCC/1000 modules 2201.91ms ± 32.52ms 2155.85ms ± 7.41ms -2.09%
bench_startup/Turbopack RSC/1000 modules 2084.68ms ± 7.21ms 2076.93ms ± 6.71ms -0.37%
bench_startup/Turbopack SSR/1000 modules 2065.91ms ± 5.16ms 2062.02ms ± 3.32ms -0.19%

@sokra sokra added the pr: automerge Kodiak will merge these automatically after checks pass label Mar 4, 2023
@kodiakhq kodiakhq bot merged commit 144519e into main Mar 4, 2023
@kodiakhq kodiakhq bot deleted the sokra/web-629-docs-only-works-on-client-side branch March 4, 2023 06:51
This was referenced Mar 7, 2023
Closed
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Mar 8, 2023
@kdy1
Update turbopack to 230308.1 (#46909)
37b0349 
## Bugfixes

 - vercel/turborepo#3526
 - vercel/turborepo#4084
 - vercel/turborepo#4083
 - vercel/turborepo#4067
 - vercel/turborepo#3959
 - vercel/turborepo#4060
 - vercel/turborepo#4081
 - vercel/turborepo#4103
 - vercel/turborepo#4100
 - vercel/turborepo#4108
 - vercel/turborepo#4101
 - vercel/turborepo#4112
 - vercel/turborepo#3956
 - vercel/turborepo#4118
 - vercel/turborepo#4117

## Feature

 - vercel/turborepo#4058
  - vercel/turborepo#4013
  - vercel/turborepo#4005
  - vercel/turborepo#4001
  - vercel/turborepo#3839
  - vercel/turborepo#4017
  - vercel/turborepo#4086
  - vercel/turborepo#4067

## Performance

  - vercel/turborepo#4040
  - vercel/turborepo#4110

## Refactor

 - vercel/turborepo#4098
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@sokra
inject swc helpers (vercel/turborepo#4060)
a716876 
### Description

This fixed the `_extends` is not defined issue.
sokra added a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@sokra
inject swc helpers (vercel/turborepo#4060)
f0ee042 
### Description

This fixed the `_extends` is not defined issue.
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
inject swc helpers (vercel/turborepo#4060)
e2797ff 
### Description

This fixed the `_extends` is not defined issue.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
inject swc helpers (vercel/turborepo#4060)
5fb804f 
### Description

This fixed the `_extends` is not defined issue.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
inject swc helpers (vercel/turborepo#4060)
a08f758 
### Description

This fixed the `_extends` is not defined issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@ForsakenHarmony ForsakenHarmony Awaiting requested review from ForsakenHarmony

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @jridgewell