Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve and enable issue path handling #4017

Merged
merged 9 commits into from
Mar 7, 2023
Merged

improve and enable issue path handling #4017

merged 9 commits into from
Mar 7, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 1, 2023

Description

adds the issue trace again, adds some basic descriptions e. g. to pages

Testing Instructions

snapshot issues

[X] Auto label

@vercel
Copy link

vercel bot commented Mar 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-nonmonorepo 🔄 Building (Inspect) Mar 7, 2023 at 4:51PM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2023 at 4:51PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2023 at 4:51PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2023 at 4:51PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 7, 2023 at 4:51PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2023 at 4:51PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2023 at 4:51PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2023 at 4:51PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2023 at 4:51PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2023 at 4:51PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Benchmark for 17d0aa6

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack SSR/1000 modules 8364.92µs ± 39.19µs 8650.48µs ± 38.93µs +3.41% +1.53%
bench_hydration/Turbopack RCC/1000 modules 3780.91ms ± 8.95ms 3823.07ms ± 9.56ms +1.12% +0.14%
bench_startup/Turbopack RCC/1000 modules 2330.10ms ± 4.79ms 2352.56ms ± 5.02ms +0.96% +0.12%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9300.50µs ± 54.83µs 9437.07µs ± 35.09µs +1.47%
bench_hmr_to_commit/Turbopack RCC/1000 modules 13.02ms ± 0.13ms 13.06ms ± 0.24ms +0.24%
bench_hmr_to_commit/Turbopack RSC/1000 modules 499.08ms ± 1.33ms 503.07ms ± 6.01ms +0.80%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9340.63µs ± 61.83µs 9527.06µs ± 62.08µs +2.00%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8334.46µs ± 31.10µs 8427.44µs ± 23.02µs +1.12%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.66ms ± 0.17ms 11.89ms ± 0.20ms +2.01%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8364.92µs ± 39.19µs 8650.48µs ± 38.93µs +3.41% +1.53%
bench_hydration/Turbopack RCC/1000 modules 3780.91ms ± 8.95ms 3823.07ms ± 9.56ms +1.12% +0.14%
bench_hydration/Turbopack RSC/1000 modules 3477.52ms ± 6.96ms 3486.38ms ± 10.49ms +0.25%
bench_hydration/Turbopack SSR/1000 modules 3332.73ms ± 11.56ms 3331.95ms ± 13.07ms -0.02%
bench_startup/Turbopack CSR/1000 modules 2565.74ms ± 10.16ms 2545.32ms ± 9.99ms -0.80%
bench_startup/Turbopack RCC/1000 modules 2330.10ms ± 4.79ms 2352.56ms ± 5.02ms +0.96% +0.12%
bench_startup/Turbopack RSC/1000 modules 2297.73ms ± 4.12ms 2304.05ms ± 9.77ms +0.27%
bench_startup/Turbopack SSR/1000 modules 2047.68ms ± 2.71ms 2055.69ms ± 2.96ms +0.39%

@sokra sokra force-pushed the sokra/web-651-restore-issue_path-functionality-to-show branch from a91234b to 1aeb5db Compare March 1, 2023 08:54
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Benchmark for 42ae321

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9739.24µs ± 33.51µs 10.02ms ± 0.05ms +2.83% +1.07%
bench_hmr_to_commit/Turbopack SSR/1000 modules 10.02ms ± 0.03ms 10.40ms ± 0.06ms +3.78% +2.00%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8773.06µs ± 36.94µs 9011.87µs ± 32.72µs +2.72% +1.12%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9739.24µs ± 33.51µs 10.02ms ± 0.05ms +2.83% +1.07%
bench_hmr_to_commit/Turbopack RCC/1000 modules 16.37ms ± 0.22ms 15.65ms ± 0.78ms -4.37%
bench_hmr_to_commit/Turbopack RSC/1000 modules 521.01ms ± 2.64ms 534.34ms ± 5.79ms +2.56%
bench_hmr_to_commit/Turbopack SSR/1000 modules 10.02ms ± 0.03ms 10.40ms ± 0.06ms +3.78% +2.00%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8706.91µs ± 40.70µs 8892.15µs ± 62.01µs +2.13%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.36ms ± 0.16ms 11.75ms ± 0.18ms +3.37%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8773.06µs ± 36.94µs 9011.87µs ± 32.72µs +2.72% +1.12%
bench_hydration/Turbopack RCC/1000 modules 3884.82ms ± 13.13ms 3882.64ms ± 10.00ms -0.06%
bench_hydration/Turbopack RSC/1000 modules 3514.34ms ± 15.86ms 3551.52ms ± 14.76ms +1.06%
bench_hydration/Turbopack SSR/1000 modules 3403.00ms ± 10.78ms 3421.29ms ± 9.89ms +0.54%
bench_startup/Turbopack CSR/1000 modules 2602.37ms ± 3.80ms 2586.45ms ± 8.45ms -0.61%
bench_startup/Turbopack RCC/1000 modules 2381.02ms ± 6.29ms 2383.95ms ± 8.70ms +0.12%
bench_startup/Turbopack RSC/1000 modules 2338.97ms ± 10.01ms 2347.16ms ± 7.54ms +0.35%
bench_startup/Turbopack SSR/1000 modules 2093.46ms ± 3.95ms 2092.08ms ± 2.79ms -0.07%

@sokra sokra force-pushed the sokra/web-651-restore-issue_path-functionality-to-show branch from 1aeb5db to 94c2b78 Compare March 1, 2023 10:55
@sokra sokra marked this pull request as ready for review March 1, 2023 11:08
@sokra sokra requested a review from a team as a code owner March 1, 2023 11:08
@sokra sokra marked this pull request as draft March 1, 2023 11:08
@sokra sokra force-pushed the sokra/web-651-restore-issue_path-functionality-to-show branch from 94c2b78 to 40c5b09 Compare March 1, 2023 11:15
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Benchmark for f1a7b2b

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.78ms ± 0.13ms 13.16ms ± 0.05ms +2.99% +0.23%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9120.67µs ± 62.98µs 9339.83µs ± 45.90µs +2.40% +0.02%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9066.77µs ± 32.77µs 9097.77µs ± 58.89µs +0.34%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.78ms ± 0.13ms 13.16ms ± 0.05ms +2.99% +0.23%
bench_hmr_to_commit/Turbopack RSC/1000 modules 504.63ms ± 1.45ms 503.67ms ± 1.21ms -0.19%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9120.67µs ± 62.98µs 9339.83µs ± 45.90µs +2.40% +0.02%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8045.71µs ± 48.60µs 8094.14µs ± 44.73µs +0.60%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.29ms ± 0.24ms 11.46ms ± 0.17ms +1.54%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8179.49µs ± 52.41µs 8288.30µs ± 47.08µs +1.33%
bench_hydration/Turbopack RCC/1000 modules 3810.69ms ± 14.87ms 3859.09ms ± 12.32ms +1.27%
bench_hydration/Turbopack RSC/1000 modules 3473.93ms ± 13.70ms 3459.82ms ± 14.28ms -0.41%
bench_hydration/Turbopack SSR/1000 modules 3373.22ms ± 15.47ms 3341.78ms ± 10.42ms -0.93%
bench_startup/Turbopack CSR/1000 modules 2592.19ms ± 8.91ms 2568.05ms ± 13.04ms -0.93%
bench_startup/Turbopack RCC/1000 modules 2332.62ms ± 8.67ms 2329.78ms ± 6.91ms -0.12%
bench_startup/Turbopack RSC/1000 modules 2293.11ms ± 8.41ms 2272.04ms ± 6.77ms -0.92%
bench_startup/Turbopack SSR/1000 modules 2062.36ms ± 3.32ms 2051.70ms ± 4.14ms -0.52%

@sokra sokra force-pushed the sokra/web-651-restore-issue_path-functionality-to-show branch from 40c5b09 to 70d2446 Compare March 3, 2023 12:41
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Benchmark for fb6e3ce

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack SSR/1000 modules 9841.86µs ± 38.45µs 10.06ms ± 0.04ms +2.23% +0.63%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.24ms ± 0.11ms 12.05ms ± 0.12ms +7.22% +2.96%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8771.43µs ± 29.72µs 9020.77µs ± 57.64µs +2.84% +0.84%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9617.66µs ± 43.36µs 9754.06µs ± 27.44µs +1.42%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.77ms ± 0.23ms 13.36ms ± 0.22ms +4.63%
bench_hmr_to_commit/Turbopack RSC/1000 modules 513.17ms ± 1.21ms 512.30ms ± 2.39ms -0.17%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9841.86µs ± 38.45µs 10.06ms ± 0.04ms +2.23% +0.63%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8604.53µs ± 65.01µs 8710.99µs ± 52.83µs +1.24%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.24ms ± 0.11ms 12.05ms ± 0.12ms +7.22% +2.96%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8771.43µs ± 29.72µs 9020.77µs ± 57.64µs +2.84% +0.84%
bench_hydration/Turbopack RCC/1000 modules 3670.91ms ± 8.00ms 3659.30ms ± 10.12ms -0.32%
bench_hydration/Turbopack RSC/1000 modules 3305.37ms ± 14.05ms 3297.82ms ± 9.46ms -0.23%
bench_hydration/Turbopack SSR/1000 modules 3357.87ms ± 6.15ms 3365.43ms ± 8.45ms +0.23%
bench_startup/Turbopack CSR/1000 modules 2587.62ms ± 4.63ms 2591.39ms ± 9.18ms +0.15%
bench_startup/Turbopack RCC/1000 modules 2157.82ms ± 4.74ms 2158.45ms ± 3.92ms +0.03%
bench_startup/Turbopack RSC/1000 modules 2096.30ms ± 6.26ms 2103.00ms ± 6.92ms +0.32%
bench_startup/Turbopack SSR/1000 modules 2078.86ms ± 3.03ms 2068.56ms ± 2.13ms -0.50%

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Benchmark for 23ef2ef

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9162.95µs ± 28.71µs 9288.50µs ± 33.05µs +1.37% +0.02%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8108.20µs ± 20.26µs 8229.16µs ± 26.75µs +1.49% +0.33%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8422.42µs ± 39.50µs 8623.42µs ± 29.30µs +2.39% +0.75%
bench_startup/Turbopack RCC/1000 modules 2186.40ms ± 7.56ms 2152.68ms ± 4.57ms -1.54% -0.43%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9162.95µs ± 28.71µs 9288.50µs ± 33.05µs +1.37% +0.02%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.68ms ± 0.10ms 13.06ms ± 0.68ms +3.01%
bench_hmr_to_commit/Turbopack RSC/1000 modules 510.26ms ± 0.66ms 512.64ms ± 1.28ms +0.47%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9305.90µs ± 43.74µs 9488.62µs ± 65.19µs +1.96%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8108.20µs ± 20.26µs 8229.16µs ± 26.75µs +1.49% +0.33%
bench_hmr_to_eval/Turbopack RCC/1000 modules 10.89ms ± 0.22ms 11.64ms ± 0.16ms +6.93%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8422.42µs ± 39.50µs 8623.42µs ± 29.30µs +2.39% +0.75%
bench_hydration/Turbopack RCC/1000 modules 3668.16ms ± 10.06ms 3667.36ms ± 10.93ms -0.02%
bench_hydration/Turbopack RSC/1000 modules 3248.55ms ± 12.91ms 3272.55ms ± 12.82ms +0.74%
bench_hydration/Turbopack SSR/1000 modules 3369.55ms ± 7.82ms 3362.59ms ± 7.19ms -0.21%
bench_startup/Turbopack CSR/1000 modules 2621.23ms ± 5.15ms 2615.50ms ± 5.50ms -0.22%
bench_startup/Turbopack RCC/1000 modules 2186.40ms ± 7.56ms 2152.68ms ± 4.57ms -1.54% -0.43%
bench_startup/Turbopack RSC/1000 modules 2075.46ms ± 2.45ms 2069.70ms ± 4.48ms -0.28%
bench_startup/Turbopack SSR/1000 modules 2060.01ms ± 4.38ms 2075.67ms ± 3.74ms +0.76%

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Benchmark for ab4cdcb

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack SSR/1000 modules 9280.37µs ± 53.35µs 9547.15µs ± 27.56µs +2.87% +1.12%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8307.11µs ± 48.45µs 8518.71µs ± 25.07µs +2.55% +0.77%
bench_startup/Turbopack CSR/1000 modules 2629.93ms ± 5.60ms 2592.81ms ± 5.84ms -1.41% -0.54%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9069.08µs ± 54.85µs 9213.72µs ± 60.80µs +1.59%
bench_hmr_to_commit/Turbopack RCC/1000 modules 11.71ms ± 0.12ms 11.56ms ± 0.10ms -1.25%
bench_hmr_to_commit/Turbopack RSC/1000 modules 514.75ms ± 1.07ms 514.97ms ± 1.00ms +0.04%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9280.37µs ± 53.35µs 9547.15µs ± 27.56µs +2.87% +1.12%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8237.64µs ± 41.61µs 8240.34µs ± 42.66µs +0.03%
bench_hmr_to_eval/Turbopack RCC/1000 modules 10.38ms ± 0.06ms 11.80ms ± 1.01ms +13.60%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8307.11µs ± 48.45µs 8518.71µs ± 25.07µs +2.55% +0.77%
bench_hydration/Turbopack RCC/1000 modules 3667.50ms ± 9.23ms 3673.38ms ± 9.71ms +0.16%
bench_hydration/Turbopack RSC/1000 modules 3306.46ms ± 12.38ms 3320.51ms ± 14.77ms +0.42%
bench_hydration/Turbopack SSR/1000 modules 3362.04ms ± 5.26ms 3353.76ms ± 5.64ms -0.25%
bench_startup/Turbopack CSR/1000 modules 2629.93ms ± 5.60ms 2592.81ms ± 5.84ms -1.41% -0.54%
bench_startup/Turbopack RCC/1000 modules 2162.42ms ± 2.99ms 2159.53ms ± 4.78ms -0.13%
bench_startup/Turbopack RSC/1000 modules 2079.39ms ± 5.62ms 2085.00ms ± 6.62ms +0.27%
bench_startup/Turbopack SSR/1000 modules 2071.98ms ± 3.49ms 2072.66ms ± 3.08ms +0.03%

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Benchmark for 72dade6

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack SSR/1000 modules 9290.56µs ± 56.89µs 9538.10µs ± 50.32µs +2.66% +0.35%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9066.83µs ± 44.29µs 9190.04µs ± 41.58µs +1.36%
bench_hmr_to_commit/Turbopack RCC/1000 modules 13.13ms ± 0.10ms 13.58ms ± 0.19ms +3.38%
bench_hmr_to_commit/Turbopack RSC/1000 modules 502.86ms ± 0.57ms 501.97ms ± 0.93ms -0.18%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9290.56µs ± 56.89µs 9538.10µs ± 50.32µs +2.66% +0.35%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8091.66µs ± 50.10µs 8236.08µs ± 39.26µs +1.78%
bench_hmr_to_eval/Turbopack RCC/1000 modules 12.41ms ± 0.74ms 12.14ms ± 0.08ms -2.16%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8354.80µs ± 34.85µs 8497.96µs ± 50.83µs +1.71%
bench_hydration/Turbopack RCC/1000 modules 3598.63ms ± 6.95ms 3598.98ms ± 5.11ms +0.01%
bench_hydration/Turbopack RSC/1000 modules 3290.49ms ± 8.80ms 3251.30ms ± 13.08ms -1.19%
bench_hydration/Turbopack SSR/1000 modules 3298.65ms ± 6.68ms 3296.92ms ± 4.27ms -0.05%
bench_startup/Turbopack CSR/1000 modules 2558.44ms ± 3.57ms 2548.97ms ± 3.90ms -0.37%
bench_startup/Turbopack RCC/1000 modules 2119.35ms ± 3.38ms 2117.21ms ± 2.37ms -0.10%
bench_startup/Turbopack RSC/1000 modules 2052.66ms ± 8.49ms 2049.18ms ± 5.45ms -0.17%
bench_startup/Turbopack SSR/1000 modules 2033.69ms ± 1.25ms 2031.38ms ± 2.26ms -0.11%

@sokra sokra marked this pull request as ready for review March 6, 2023 14:00
@sokra sokra requested a review from alexkirsz March 6, 2023 14:00
alexkirsz
alexkirsz suggested changes Mar 6, 2023
View reviewed changes
crates/next-core/src/app_source.rs Outdated Show resolved Hide resolved
crates/next-core/src/next_config.rs Outdated Show resolved Hide resolved
crates/turbopack-dev-server/src/update/protocol.rs Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Benchmark for 2b82e83

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9016.26µs ± 28.73µs 9204.03µs ± 33.42µs +2.08% +0.70%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8273.75µs ± 38.15µs 8423.09µs ± 21.24µs +1.80% +0.37%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9016.26µs ± 28.73µs 9204.03µs ± 33.42µs +2.08% +0.70%
bench_hmr_to_commit/Turbopack RCC/1000 modules 10.97ms ± 0.06ms 11.08ms ± 0.05ms +0.96%
bench_hmr_to_commit/Turbopack RSC/1000 modules 518.53ms ± 1.07ms 519.42ms ± 1.01ms +0.17%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9366.76µs ± 43.15µs 9488.52µs ± 39.41µs +1.30%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8162.87µs ± 34.20µs 8208.05µs ± 33.37µs +0.55%
bench_hmr_to_eval/Turbopack RCC/1000 modules 9902.27µs ± 23.14µs 10.04ms ± 0.06ms +1.44%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8273.75µs ± 38.15µs 8423.09µs ± 21.24µs +1.80% +0.37%
bench_hydration/Turbopack RCC/1000 modules 3636.48ms ± 8.74ms 3663.60ms ± 5.06ms +0.75%
bench_hydration/Turbopack RSC/1000 modules 3307.44ms ± 8.14ms 3297.86ms ± 7.91ms -0.29%
bench_hydration/Turbopack SSR/1000 modules 3360.72ms ± 7.12ms 3376.00ms ± 7.52ms +0.45%
bench_startup/Turbopack CSR/1000 modules 2604.31ms ± 7.82ms 2580.60ms ± 7.54ms -0.91%
bench_startup/Turbopack RCC/1000 modules 2162.82ms ± 4.11ms 2156.30ms ± 4.29ms -0.30%
bench_startup/Turbopack RSC/1000 modules 2090.36ms ± 4.54ms 2088.96ms ± 4.82ms -0.07%
bench_startup/Turbopack SSR/1000 modules 2069.55ms ± 3.33ms 2063.50ms ± 1.41ms -0.29%

@sokra sokra requested a review from alexkirsz March 7, 2023 15:27
@sokra sokra force-pushed the sokra/web-651-restore-issue_path-functionality-to-show branch from 3510b6f to 659ee6f Compare March 7, 2023 16:51
@sokra sokra added the pr: automerge Kodiak will merge these automatically after checks pass label Mar 7, 2023
@kodiakhq kodiakhq bot merged commit a29b684 into main Mar 7, 2023
@kodiakhq kodiakhq bot deleted the sokra/web-651-restore-issue_path-functionality-to-show branch March 7, 2023 17:10
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Benchmark for 47b30fb

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack SSR/1000 modules 7970.42µs ± 47.90µs 8284.01µs ± 37.79µs +3.93% +1.76%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8835.99µs ± 37.45µs 8847.37µs ± 30.45µs +0.13%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.79ms ± 0.12ms 12.87ms ± 0.11ms +0.60%
bench_hmr_to_commit/Turbopack RSC/1000 modules 494.25ms ± 0.42ms 495.27ms ± 1.22ms +0.21%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8967.29µs ± 54.60µs 9089.45µs ± 53.54µs +1.36%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8020.51µs ± 38.11µs 8042.99µs ± 16.84µs +0.28%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.28ms ± 0.09ms 11.70ms ± 0.19ms +3.66%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7970.42µs ± 47.90µs 8284.01µs ± 37.79µs +3.93% +1.76%
bench_hydration/Turbopack RCC/1000 modules 3558.09ms ± 6.18ms 3554.32ms ± 9.71ms -0.11%
bench_hydration/Turbopack RSC/1000 modules 3227.92ms ± 14.66ms 3195.78ms ± 12.55ms -1.00%
bench_hydration/Turbopack SSR/1000 modules 3242.66ms ± 5.85ms 3258.94ms ± 8.16ms +0.50%
bench_startup/Turbopack CSR/1000 modules 2540.61ms ± 7.61ms 2524.39ms ± 7.01ms -0.64%
bench_startup/Turbopack RCC/1000 modules 2117.92ms ± 4.05ms 2118.41ms ± 4.51ms +0.02%
bench_startup/Turbopack RSC/1000 modules 2061.46ms ± 7.26ms 2047.05ms ± 6.05ms -0.70%
bench_startup/Turbopack SSR/1000 modules 2005.31ms ± 1.27ms 2006.76ms ± 3.47ms +0.07%

mehulkar pushed a commit that referenced this pull request Mar 7, 2023
@sokra @mehulkar
improve and enable issue path handling (#4017)
d1b1215 
### Description

adds the issue trace again, adds some basic descriptions e. g. to pages

### Testing Instructions

snapshot issues

[X] Auto label
@kdy1 kdy1 mentioned this pull request Mar 8, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Mar 8, 2023
@kdy1
Update turbopack to 230308.1 (#46909)
37b0349 
## Bugfixes

 - vercel/turborepo#3526
 - vercel/turborepo#4084
 - vercel/turborepo#4083
 - vercel/turborepo#4067
 - vercel/turborepo#3959
 - vercel/turborepo#4060
 - vercel/turborepo#4081
 - vercel/turborepo#4103
 - vercel/turborepo#4100
 - vercel/turborepo#4108
 - vercel/turborepo#4101
 - vercel/turborepo#4112
 - vercel/turborepo#3956
 - vercel/turborepo#4118
 - vercel/turborepo#4117

## Feature

 - vercel/turborepo#4058
  - vercel/turborepo#4013
  - vercel/turborepo#4005
  - vercel/turborepo#4001
  - vercel/turborepo#3839
  - vercel/turborepo#4017
  - vercel/turborepo#4086
  - vercel/turborepo#4067

## Performance

  - vercel/turborepo#4040
  - vercel/turborepo#4110

## Refactor

 - vercel/turborepo#4098
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@sokra
improve and enable issue path handling (vercel/turborepo#4017)
ca67d95 
### Description

adds the issue trace again, adds some basic descriptions e. g. to pages

### Testing Instructions

snapshot issues

[X] Auto label
sokra added a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@sokra
improve and enable issue path handling (vercel/turborepo#4017)
951568c 
### Description

adds the issue trace again, adds some basic descriptions e. g. to pages

### Testing Instructions

snapshot issues

[X] Auto label
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
improve and enable issue path handling (vercel/turborepo#4017)
0aad1fd 
### Description

adds the issue trace again, adds some basic descriptions e. g. to pages

### Testing Instructions

snapshot issues

[X] Auto label
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
improve and enable issue path handling (vercel/turborepo#4017)
0d75273 
### Description

adds the issue trace again, adds some basic descriptions e. g. to pages

### Testing Instructions

snapshot issues

[X] Auto label
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
improve and enable issue path handling (vercel/turborepo#4017)
efd75c0 
### Description

adds the issue trace again, adds some basic descriptions e. g. to pages

### Testing Instructions

snapshot issues

[X] Auto label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @alexkirsz