Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add zipkin request tracing for Knative functions #157

Merged
merged 1 commit into from
Mar 3, 2021
Merged

add zipkin request tracing for Knative functions #157

merged 1 commit into from
Mar 3, 2021

Conversation

shyamjesal
Copy link
Collaborator

@shyamjesal shyamjesal commented Mar 3, 2021 •
edited
Loading

Once the cluster is booted, run istioctl dashboard zipkin to start the zipkin dashboard.

  • To monitor requests remotely, run ssh -L 9411:127.0.0.1:9411 <Host_IP> for port forwarding.
  • Open your browser and enter localhost:9411 for the dashboard.

Screenshots:
image
image

Signed-off-by: Shyam Jesal s.jesalpura@gmail.com

@shyamjesal shyamjesal requested a review from ustiugov March 3, 2021 10:23
@shyamjesal shyamjesal self-assigned this Mar 3, 2021
@ustiugov
Copy link
Member

ustiugov commented Mar 3, 2021

I don't see any change related to tracing in setup_master_node.sh. Can you describe the instructions better in the PR's description? also, please attach a couple of screenshots

@shyamjesal
Copy link
Collaborator Author

I don't see any change related to tracing in setup_master_node.sh. Can you describe the instructions better in the PR's description? also, please attach a couple of screenshots

istioctl is required in $PATH by setup_zipkin.sh but it was not added earlier. I will add screenshots.

@shyamjesal shyamjesal force-pushed the request-tracing-zipkin branch 2 times, most recently from 5bfa10c to 865c3a8 Compare March 3, 2021 12:19
ustiugov
ustiugov requested changes Mar 3, 2021
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment •
edited by shyamjesal
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please update the changelog as well, saying that vHive officially supports Zipkin tracing from now on.
  • Please add this script to the vHive CRI test's setup.

scripts/cluster/setup_master_node.sh Outdated
@@ -57,4 +60,18 @@ fi
kubectl apply --filename $ROOT/configs/knative_yamls/serving-default-domain.yaml

kubectl apply --filename https://github.com/knative/net-istio/releases/download/v0.19.0/release.yaml

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this part cannot be on by default because tracing may result in a slowdown. You should have it as a separate script.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, you are right.

scripts/cluster/setup_master_node.sh Outdated
--type merge \
-p '{"data":{"backend":"zipkin","zipkin-endpoint":"http://zipkin.istio-system.svc.cluster.local:9411/api/v2/spans","debug":"true"}}'

echo "1. Once the zipkin container is running, start the dashboard using istioctl dashboard zipkin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be in the Dev's manual.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@shyamjesal shyamjesal force-pushed the request-tracing-zipkin branch 2 times, most recently from b8c1609 to 3ad1d8e Compare March 3, 2021 13:49
ustiugov
ustiugov requested changes Mar 3, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
docs/developers_guide.md Show resolved Hide resolved
scripts/setup_zipkin.sh Outdated Show resolved Hide resolved
@shyamjesal shyamjesal force-pushed the request-tracing-zipkin branch from 3ad1d8e to c1c7cfd Compare March 3, 2021 14:38
@shyamjesal
add zipkin request tracing for Knative functions
7fa5153 
Signed-off-by: Shyam Jesal <s.jesalpura@gmail.com>
@shyamjesal shyamjesal force-pushed the request-tracing-zipkin branch from c1c7cfd to 7fa5153 Compare March 3, 2021 14:44
@shyamjesal shyamjesal merged commit 23da57f into master Mar 3, 2021
@ustiugov ustiugov deleted the request-tracing-zipkin branch March 3, 2021 17:12
@ustiugov ustiugov added this to the Support function composition milestone Mar 3, 2021
@ustiugov ustiugov added the enhancement New feature or request label Mar 3, 2021
HermioneKT added a commit that referenced this pull request Jan 31, 2024
@HermioneKT
# This is a combination of 252 commits.
3c6919f 
parent 6674807
author HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800
committer HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800

test

# This is the commit message #157:

test

# This is the commit message #159:

test

# This is the commit message #160:

test

# This is the commit message #161:

test

# This is the commit message #162:

test

# This is the commit message #163:

test

# This is the commit message #164:

tesT

# This is the commit message #165:

test

# This is the commit message #166:

test

# This is the commit message #167:

test

# This is the commit message #168:

test

# This is the commit message #169:

test

# This is the commit message #170:

test

# This is the commit message #171:

Test

# This is the commit message #172:

test

# This is the commit message #173:

test

# This is the commit message #174:

test

# This is the commit message #175:

test

# This is the commit message #176:

test

# This is the commit message #177:

test

# This is the commit message #178:

test

# This is the commit message #179:

test

# This is the commit message #180:

test

# This is the commit message #181:

test

# This is the commit message #182:

test

# This is the commit message #183:

test

# This is the commit message #184:

test

# This is the commit message #185:

test

# This is the commit message #186:

test

# This is the commit message #187:

test

# This is the commit message #188:

test

# This is the commit message #189:

test

# This is the commit message #190:

Test

# This is the commit message #191:

Test

# This is the commit message #192:

test

# This is the commit message #193:

Test

# This is the commit message #194:

test

# This is the commit message #195:

test

# This is the commit message #196:

test

# This is the commit message #197:

test

# This is the commit message #198:

test

# This is the commit message #199:

Test

# This is the commit message #200:

test

# This is the commit message #201:

test

# This is the commit message #202:

Test

# This is the commit message #203:

test

# This is the commit message #204:

test

# This is the commit message #205:

test

# This is the commit message #206:

test

# This is the commit message #207:

test

# This is the commit message #208:

test

# This is the commit message #209:

test

# This is the commit message #210:

test

# This is the commit message #211:

Test

# This is the commit message #212:

test

# This is the commit message #213:

Test

# This is the commit message #214:

Test

# This is the commit message #215:

Test

# This is the commit message #216:

test

# This is the commit message #217:

Test

# This is the commit message #218:

test

# This is the commit message #219:

test

# This is the commit message #220:

test

# This is the commit message #221:

test

# This is the commit message #222:

test

# This is the commit message #223:

test

# This is the commit message #224:

test

# This is the commit message #225:

test

# This is the commit message #226:

test

# This is the commit message #227:

test

# This is the commit message #228:

test

# This is the commit message #229:

Test

# This is the commit message #230:

test

# This is the commit message #231:

test

# This is the commit message #232:

test

# This is the commit message #233:

test

# This is the commit message #234:

Test

# This is the commit message #235:

test

# This is the commit message #236:

test

# This is the commit message #237:

test

# This is the commit message #238:

test

# This is the commit message #239:

test

# This is the commit message #240:

test

# This is the commit message #241:

test

# This is the commit message #242:

test

# This is the commit message #243:

test

# This is the commit message #244:

test

# This is the commit message #245:

test

# This is the commit message #246:

test

# This is the commit message #247:

test

# This is the commit message #248:

test

# This is the commit message #249:

test

# This is the commit message #250:

test

# This is the commit message #251:

test

# This is the commit message #252:

test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ustiugov ustiugov ustiugov approved these changes

Assignees

@shyamjesal shyamjesal

Labels
enhancement New feature or request
Projects
None yet
Milestone
Support function composition
Development

Successfully merging this pull request may close these issues.
2 participants
@shyamjesal @ustiugov