Add cluster restart script #208

shyamjesal · 2021-04-12T08:03:21Z

Closing #151

ustiugov · 2021-04-12T08:10:37Z

scripts/cloudlab/start_vhive_cluster.sh

+    mkdir -p ~/ctrd-logs
+fi
+
+sudo containerd 1>~/ctrd-logs/ctrd.out 2>~/ctrd-logs/ctrd.err &


use $HOME instead

ustiugov · 2021-04-12T08:11:49Z

scripts/cloudlab/start_vhive_cluster.sh

@@ -0,0 +1,41 @@
+#!/bin/bash


rename to start_onenode_vhive_cluster

ustiugov · 2021-04-12T12:13:55Z

please use this script in the CRI test so that it is covered by the CI

ustiugov

Need to let the user specify the log location when running the script manually

Please add info about this feature to (and tick the boxes when done)

changelog (please also mention that CI logs are now saved as artifacts)
the dev guide
the quickstart guide in the docs
the quickstart guide in the wiki

ustiugov · 2021-04-14T12:30:14Z

scripts/cloudlab/start_onenode_vhive_cluster.sh

+
+$SCRIPTS/github_runner/clean_cri_runner.sh
+
+CTRDLOGDIR=/tmp/ctrd-logs/$GITHUB_RUN_ID


if used by a user and not by the CI, they should be able to set this folder to a specific location by a runtime argument

Okay If the $GITHUB_RUN_ID variable is empty, the script will ask for the custom log location.

sounds good

ustiugov

please pay attention to the docs, it's important for our users and hence vHive adoption.

ustiugov · 2021-04-14T15:27:59Z

CHANGELOG.md

@@ -30,6 +30,8 @@ More info [here](./docs/developers_guide.md#MinIO-S3-service)
 Other
 - vHive now also supports vanilla Knative benchmarking and testing (i.e., using containers for function sandboxes).
 More info [here](./docs/developers_guide.md#Testing-stock-Knative-images).
+- Added [script](./scripts/cloudlab/start_onenode_vhive_cluster.sh) to start vHive single node cluster.


Suggested change

- Added [script](./scripts/cloudlab/start_onenode_vhive_cluster.sh) to start vHive single node cluster.

- Added [script](./scripts/cloudlab/start_onenode_vhive_cluster.sh) to (re)start vHive single node cluster in a push-button.

ustiugov · 2021-04-14T15:28:49Z

CHANGELOG.md

@@ -30,6 +30,8 @@ More info [here](./docs/developers_guide.md#MinIO-S3-service)
 Other
 - vHive now also supports vanilla Knative benchmarking and testing (i.e., using containers for function sandboxes).
 More info [here](./docs/developers_guide.md#Testing-stock-Knative-images).
+- Added [script](./scripts/cloudlab/start_onenode_vhive_cluster.sh) to start vHive single node cluster.


this should go to [Unrelease] above instead of v1.2

docs/quickstart_guide.md

ustiugov · 2021-04-14T15:32:29Z

scripts/cloudlab/start_onenode_vhive_cluster.sh

+CTRDLOGDIR=$1
+
+if [ -z $CTRDLOGDIR ] && [ -z "$GITHUB_RUN_ID" ] ; then
+    echo "Log directory missing"


Suggested change

echo "Log directory missing"

echo "[ERROR]: The log-directory argument is missing"

ustiugov

Minor

ustiugov · 2021-04-14T17:21:52Z

docs/quickstart_guide.md

 ./scripts/cloudlab/setup_node.sh
 sudo containerd
 sudo PATH=$PATH /usr/local/bin/firecracker-containerd --config /etc/firecracker-containerd/config.toml
 source /etc/profile && go build && sudo ./vhive
 ./scripts/cluster/create_one_node_cluster.sh
 ```
+### Using autostart script


Suggested change

### Using autostart script

### Using a script

ustiugov · 2021-04-14T17:22:45Z

docs/quickstart_guide.md

+```bash
+scripts/cloudlab/start_onenode_vhive_cluster.sh <folder to store logs>
+```
+
 ### Clean up


move this under "Manual" subsection

ustiugov · 2021-04-14T17:23:20Z

docs/quickstart_guide.md

@@ -118,13 +118,23 @@ kn service delete --all

 ## Setup a single-node cluster (master and worker functionality on the same node)

-```
+### Manual (Recommended)


Suggested change

### Manual (Recommended)

### Manual

No need to recommend it here.

docs/quickstart_guide.md

ustiugov · 2021-04-14T17:50:23Z

CHANGELOG.md

@@ -30,6 +30,8 @@ More info [here](./docs/developers_guide.md#MinIO-S3-service)
 Other
 - vHive now also supports vanilla Knative benchmarking and testing (i.e., using containers for function sandboxes).
 More info [here](./docs/developers_guide.md#Testing-stock-Knative-images).
+- Added [script](./scripts/cloudlab/start_onenode_vhive_cluster.sh) to (re)start vHive single node cluster in a push-button.


Move to unreleased

My bad. I forgot to save the file before committing.

Signed-off-by: shyam Jesal <s.jesalpura@gmail.com>

parent 6674807 author HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800 committer HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800 test # This is the commit message #157: test # This is the commit message #159: test # This is the commit message #160: test # This is the commit message #161: test # This is the commit message #162: test # This is the commit message #163: test # This is the commit message #164: tesT # This is the commit message #165: test # This is the commit message #166: test # This is the commit message #167: test # This is the commit message #168: test # This is the commit message #169: test # This is the commit message #170: test # This is the commit message #171: Test # This is the commit message #172: test # This is the commit message #173: test # This is the commit message #174: test # This is the commit message #175: test # This is the commit message #176: test # This is the commit message #177: test # This is the commit message #178: test # This is the commit message #179: test # This is the commit message #180: test # This is the commit message #181: test # This is the commit message #182: test # This is the commit message #183: test # This is the commit message #184: test # This is the commit message #185: test # This is the commit message #186: test # This is the commit message #187: test # This is the commit message #188: test # This is the commit message #189: test # This is the commit message #190: Test # This is the commit message #191: Test # This is the commit message #192: test # This is the commit message #193: Test # This is the commit message #194: test # This is the commit message #195: test # This is the commit message #196: test # This is the commit message #197: test # This is the commit message #198: test # This is the commit message #199: Test # This is the commit message #200: test # This is the commit message #201: test # This is the commit message #202: Test # This is the commit message #203: test # This is the commit message #204: test # This is the commit message #205: test # This is the commit message #206: test # This is the commit message #207: test # This is the commit message #208: test # This is the commit message #209: test # This is the commit message #210: test # This is the commit message #211: Test # This is the commit message #212: test # This is the commit message #213: Test # This is the commit message #214: Test # This is the commit message #215: Test # This is the commit message #216: test # This is the commit message #217: Test # This is the commit message #218: test # This is the commit message #219: test # This is the commit message #220: test # This is the commit message #221: test # This is the commit message #222: test # This is the commit message #223: test # This is the commit message #224: test # This is the commit message #225: test # This is the commit message #226: test # This is the commit message #227: test # This is the commit message #228: test # This is the commit message #229: Test # This is the commit message #230: test # This is the commit message #231: test # This is the commit message #232: test # This is the commit message #233: test # This is the commit message #234: Test # This is the commit message #235: test # This is the commit message #236: test # This is the commit message #237: test # This is the commit message #238: test # This is the commit message #239: test # This is the commit message #240: test # This is the commit message #241: test # This is the commit message #242: test # This is the commit message #243: test # This is the commit message #244: test # This is the commit message #245: test # This is the commit message #246: test # This is the commit message #247: test # This is the commit message #248: test # This is the commit message #249: test # This is the commit message #250: test # This is the commit message #251: test # This is the commit message #252: test

shyamjesal requested a review from ustiugov April 12, 2021 08:03

shyamjesal force-pushed the add_cluster_restart_script branch from dc09a2a to f8f227c Compare April 12, 2021 08:07

ustiugov requested changes Apr 12, 2021

View reviewed changes

shyamjesal force-pushed the add_cluster_restart_script branch 2 times, most recently from 1627617 to 1e5e4c9 Compare April 14, 2021 12:27

ustiugov requested changes Apr 14, 2021

View reviewed changes

shyamjesal force-pushed the add_cluster_restart_script branch from 0fb0f72 to 6c6cbf9 Compare April 14, 2021 15:02

ustiugov requested changes Apr 14, 2021

View reviewed changes

shyamjesal force-pushed the add_cluster_restart_script branch 3 times, most recently from ae9f57e to fb66b1f Compare April 14, 2021 17:06

ustiugov requested changes Apr 14, 2021

View reviewed changes

shyamjesal force-pushed the add_cluster_restart_script branch from fb66b1f to f0bb4d4 Compare April 14, 2021 17:38

ustiugov requested changes Apr 14, 2021

View reviewed changes

shyamjesal force-pushed the add_cluster_restart_script branch from f0bb4d4 to 8b3bda9 Compare April 14, 2021 18:21

ustiugov previously approved these changes Apr 14, 2021

View reviewed changes

ustiugov enabled auto-merge (rebase) April 14, 2021 18:27

ustiugov force-pushed the master branch from d5f7931 to acba40d Compare April 15, 2021 12:07

shyamjesal disabled auto-merge April 15, 2021 12:35

shyamjesal added 3 commits April 15, 2021 20:15

added cluster restart script

2fbb614

Signed-off-by: shyam Jesal <s.jesalpura@gmail.com>

use start cluster script for CRI tests

949fa3d

Signed-off-by: shyam Jesal <s.jesalpura@gmail.com>

docs update + minor tweaks

73950a7

Signed-off-by: shyam Jesal <s.jesalpura@gmail.com>

shyamjesal dismissed ustiugov’s stale review via 73950a7 April 15, 2021 14:51

shyamjesal force-pushed the add_cluster_restart_script branch from 8b3bda9 to 73950a7 Compare April 15, 2021 14:51

ustiugov approved these changes Apr 15, 2021

View reviewed changes

ustiugov enabled auto-merge (rebase) April 15, 2021 15:39

ustiugov disabled auto-merge April 15, 2021 17:00

ustiugov merged commit 4660f50 into main Apr 15, 2021

ustiugov deleted the add_cluster_restart_script branch April 15, 2021 17:01

ustiugov mentioned this pull request Apr 19, 2021

Need a script to restart a vHive cluster (single node) #151

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cluster restart script #208

Add cluster restart script #208

shyamjesal commented Apr 12, 2021

ustiugov Apr 12, 2021

ustiugov Apr 12, 2021

ustiugov commented Apr 12, 2021

ustiugov left a comment •

edited by shyamjesal

Loading

ustiugov Apr 14, 2021

shyamjesal Apr 14, 2021

ustiugov Apr 14, 2021

ustiugov left a comment

ustiugov Apr 14, 2021

shyamjesal Apr 14, 2021

ustiugov Apr 14, 2021

shyamjesal Apr 14, 2021

ustiugov Apr 14, 2021

ustiugov left a comment

ustiugov Apr 14, 2021

ustiugov Apr 14, 2021

ustiugov Apr 14, 2021

ustiugov Apr 14, 2021

shyamjesal Apr 14, 2021


		$SCRIPTS/github_runner/clean_cri_runner.sh

		CTRDLOGDIR=/tmp/ctrd-logs/$GITHUB_RUN_ID

	- Added [script](./scripts/cloudlab/start_onenode_vhive_cluster.sh) to start vHive single node cluster.
	- Added [script](./scripts/cloudlab/start_onenode_vhive_cluster.sh) to (re)start vHive single node cluster in a push-button.

	echo "Log directory missing"
	echo "[ERROR]: The log-directory argument is missing"

Add cluster restart script #208

Add cluster restart script #208

Conversation

shyamjesal commented Apr 12, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ustiugov commented Apr 12, 2021

ustiugov left a comment • edited by shyamjesal Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ustiugov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ustiugov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ustiugov left a comment •

edited by shyamjesal

Loading