Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moved pmutool installation to integ test dockerfile #167

Merged
merged 1 commit into from
Mar 12, 2021
Merged

moved pmutool installation to integ test dockerfile #167

merged 1 commit into from
Mar 12, 2021

Conversation

shyamjesal
Copy link
Collaborator

Signed-off-by: Shyam Jesal s.jesalpura@gmail.com

ustiugov
ustiugov reviewed Mar 11, 2021
View reviewed changes
scripts/install_pmutools.sh Outdated
@@ -25,7 +25,7 @@
set -e

sudo apt-get install linux-tools-`uname -r` -y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sudo apt-get install linux-tools-`uname -r` -y
sudo apt-get install -y linux-tools-`uname -r` numactl

scripts/install_pmutools.sh Outdated Show resolved Hide resolved
@shyamjesal shyamjesal force-pushed the pmu-tool-fix branch 3 times, most recently from bf6daf1 to b9c4b3c Compare March 11, 2021 19:00
ustiugov
ustiugov reviewed Mar 11, 2021
View reviewed changes
scripts/install_pmutools.sh Outdated
/usr/local/pmu-tools/toplev --print > /dev/null

# disabling nmi watchdog to minimize multiplexing
sudo echo 0 > /proc/sys/kernel/nmi_watchdog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove this line and add this to the pre-requisites in profile.md

@shyamjesal shyamjesal force-pushed the pmu-tool-fix branch 2 times, most recently from 7c11227 to 33d7f5b Compare March 11, 2021 19:12
@shyamjesal
moved pmutool installation to integ test dockerfile
97b4559 
Signed-off-by: Shyam Jesal <s.jesalpura@gmail.com>
@ustiugov ustiugov enabled auto-merge (rebase) March 11, 2021 19:50
@ustiugov ustiugov disabled auto-merge March 11, 2021 19:51
@ustiugov ustiugov enabled auto-merge (rebase) March 11, 2021 19:51
@ustiugov ustiugov merged commit c8169b5 into master Mar 12, 2021
@ustiugov ustiugov deleted the pmu-tool-fix branch March 12, 2021 08:38
@shyamjesal shyamjesal linked an issue Mar 12, 2021 that may be closed by this pull request
PMU tools must be installed inside the runner, not on the host #166
Closed
HermioneKT added a commit that referenced this pull request Jan 31, 2024
@HermioneKT
# This is a combination of 252 commits.
3c6919f 
parent 6674807
author HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800
committer HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800

test

# This is the commit message #157:

test

# This is the commit message #159:

test

# This is the commit message #160:

test

# This is the commit message #161:

test

# This is the commit message #162:

test

# This is the commit message #163:

test

# This is the commit message #164:

tesT

# This is the commit message #165:

test

# This is the commit message #166:

test

# This is the commit message #167:

test

# This is the commit message #168:

test

# This is the commit message #169:

test

# This is the commit message #170:

test

# This is the commit message #171:

Test

# This is the commit message #172:

test

# This is the commit message #173:

test

# This is the commit message #174:

test

# This is the commit message #175:

test

# This is the commit message #176:

test

# This is the commit message #177:

test

# This is the commit message #178:

test

# This is the commit message #179:

test

# This is the commit message #180:

test

# This is the commit message #181:

test

# This is the commit message #182:

test

# This is the commit message #183:

test

# This is the commit message #184:

test

# This is the commit message #185:

test

# This is the commit message #186:

test

# This is the commit message #187:

test

# This is the commit message #188:

test

# This is the commit message #189:

test

# This is the commit message #190:

Test

# This is the commit message #191:

Test

# This is the commit message #192:

test

# This is the commit message #193:

Test

# This is the commit message #194:

test

# This is the commit message #195:

test

# This is the commit message #196:

test

# This is the commit message #197:

test

# This is the commit message #198:

test

# This is the commit message #199:

Test

# This is the commit message #200:

test

# This is the commit message #201:

test

# This is the commit message #202:

Test

# This is the commit message #203:

test

# This is the commit message #204:

test

# This is the commit message #205:

test

# This is the commit message #206:

test

# This is the commit message #207:

test

# This is the commit message #208:

test

# This is the commit message #209:

test

# This is the commit message #210:

test

# This is the commit message #211:

Test

# This is the commit message #212:

test

# This is the commit message #213:

Test

# This is the commit message #214:

Test

# This is the commit message #215:

Test

# This is the commit message #216:

test

# This is the commit message #217:

Test

# This is the commit message #218:

test

# This is the commit message #219:

test

# This is the commit message #220:

test

# This is the commit message #221:

test

# This is the commit message #222:

test

# This is the commit message #223:

test

# This is the commit message #224:

test

# This is the commit message #225:

test

# This is the commit message #226:

test

# This is the commit message #227:

test

# This is the commit message #228:

test

# This is the commit message #229:

Test

# This is the commit message #230:

test

# This is the commit message #231:

test

# This is the commit message #232:

test

# This is the commit message #233:

test

# This is the commit message #234:

Test

# This is the commit message #235:

test

# This is the commit message #236:

test

# This is the commit message #237:

test

# This is the commit message #238:

test

# This is the commit message #239:

test

# This is the commit message #240:

test

# This is the commit message #241:

test

# This is the commit message #242:

test

# This is the commit message #243:

test

# This is the commit message #244:

test

# This is the commit message #245:

test

# This is the commit message #246:

test

# This is the commit message #247:

test

# This is the commit message #248:

test

# This is the commit message #249:

test

# This is the commit message #250:

test

# This is the commit message #251:

test

# This is the commit message #252:

test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ustiugov ustiugov ustiugov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PMU tools must be installed inside the runner, not on the host
2 participants
@shyamjesal @ustiugov