Restore support for null coalesce on match expressions #10422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimeo#10068 added isset restrictions that didn't consider null coalesces on match expressions. This restores that support by converting the match expression to a virtual variable for the isset analysis, similar to other incompatible expressions.
tscni
force-pushed
the
fix/match-null-coalesce
branch
from
1b9e9c2
to
d91aab1
Compare
tscni
commented
Nov 29, 2023
| @@ -39,6 +39,7 @@ public static function analyze( | |||
| || $root_expr instanceof PhpParser\Node\Expr\MethodCall | |||
| || $root_expr instanceof PhpParser\Node\Expr\StaticCall | |||
| || $root_expr instanceof PhpParser\Node\Expr\Cast | |||
| || $root_expr instanceof PhpParser\Node\Expr\Match_ | |||
There was a problem hiding this comment.
Based on #10068 (comment), ClassConstFetch and AssignRef are currently supported in the isset analyzer for exactly the same reasons and shouldn't actually be there:
I'm wondering whether they should be moved here too.
orklah
added
the
release:fix
|
Thanks! |
tcarrio
pushed a commit
to open-feature/php-sdk
that referenced
this pull request
Dec 4, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vimeo/psalm](https://github.com/vimeo/psalm) | `~5.16.0` -> `~5.17.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vimeo/psalm (vimeo/psalm)</summary> ### [`v5.17.0`](https://github.com/vimeo/psalm/releases/tag/5.17.0) [Compare Source](https://github.com/vimeo/psalm/compare/5.16.0...5.17.0) <!-- Release notes generated using configuration in .github/release.yml at 5.x --> #### What's Changed ##### Features - Implement by-ref closure use analysis by [@​danog](https://github.com/danog) in [vimeo/psalm#10419 ##### Fixes - Update MongoDB stubs for 1.17 by [@​alcaeus](https://github.com/alcaeus) in [vimeo/psalm#10402 - Fix backtick analysis by [@​danog](https://github.com/danog) in [vimeo/psalm#10409 - Declare we do not support document highlighting by [@​tm1000](https://github.com/tm1000) in [vimeo/psalm#10408 - update define types to be correct by [@​kkmuffme](https://github.com/kkmuffme) in [vimeo/psalm#10423 - Fix return type of DOMXPath::query by [@​nielsdos](https://github.com/nielsdos) in [vimeo/psalm#10443 - Fix CLI -r error by [@​kkmuffme](https://github.com/kkmuffme) in [vimeo/psalm#10442 - Use correct file path while adding unused suppressions for virtual \__… by [@​danog](https://github.com/danog) in [vimeo/psalm#10434 - Restore support for null coalesce on match expressions by [@​tscni](https://github.com/tscni) in [vimeo/psalm#10422 - Fix static magic method pureness not being inherited from traits by [@​tscni](https://github.com/tscni) in [vimeo/psalm#10429 - Fix POSIX only detection of absolute paths by [@​rarila](https://github.com/rarila) in [vimeo/psalm#10441 - Emit UnusedPsalmSuppress issues for suppressed issues already removed by [@​danog](https://github.com/danog) in [vimeo/psalm#10431 - Use keyed arrays when assigning literal union keys & assertion fixes by [@​danog](https://github.com/danog) in [vimeo/psalm#10439 ##### Internal changes - use branch name to randomize tests to ensure test dependencies will error by [@​kkmuffme](https://github.com/kkmuffme) in [vimeo/psalm#10424 #### New Contributors - [@​nielsdos](https://github.com/nielsdos) made their first contribution in [vimeo/psalm#10443 **Full Changelog**: vimeo/psalm@5.16.0...5.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/php-sdk). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
tcarrio
pushed a commit
to open-feature/php-sdk
that referenced
this pull request
Dec 5, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vimeo/psalm](https://github.com/vimeo/psalm) | `~5.16.0` -> `~5.17.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vimeo/psalm (vimeo/psalm)</summary> ### [`v5.17.0`](https://github.com/vimeo/psalm/releases/tag/5.17.0) [Compare Source](https://github.com/vimeo/psalm/compare/5.16.0...5.17.0) <!-- Release notes generated using configuration in .github/release.yml at 5.x --> #### What's Changed ##### Features - Implement by-ref closure use analysis by [@​danog](https://github.com/danog) in [vimeo/psalm#10419 ##### Fixes - Update MongoDB stubs for 1.17 by [@​alcaeus](https://github.com/alcaeus) in [vimeo/psalm#10402 - Fix backtick analysis by [@​danog](https://github.com/danog) in [vimeo/psalm#10409 - Declare we do not support document highlighting by [@​tm1000](https://github.com/tm1000) in [vimeo/psalm#10408 - update define types to be correct by [@​kkmuffme](https://github.com/kkmuffme) in [vimeo/psalm#10423 - Fix return type of DOMXPath::query by [@​nielsdos](https://github.com/nielsdos) in [vimeo/psalm#10443 - Fix CLI -r error by [@​kkmuffme](https://github.com/kkmuffme) in [vimeo/psalm#10442 - Use correct file path while adding unused suppressions for virtual \__… by [@​danog](https://github.com/danog) in [vimeo/psalm#10434 - Restore support for null coalesce on match expressions by [@​tscni](https://github.com/tscni) in [vimeo/psalm#10422 - Fix static magic method pureness not being inherited from traits by [@​tscni](https://github.com/tscni) in [vimeo/psalm#10429 - Fix POSIX only detection of absolute paths by [@​rarila](https://github.com/rarila) in [vimeo/psalm#10441 - Emit UnusedPsalmSuppress issues for suppressed issues already removed by [@​danog](https://github.com/danog) in [vimeo/psalm#10431 - Use keyed arrays when assigning literal union keys & assertion fixes by [@​danog](https://github.com/danog) in [vimeo/psalm#10439 ##### Internal changes - use branch name to randomize tests to ensure test dependencies will error by [@​kkmuffme](https://github.com/kkmuffme) in [vimeo/psalm#10424 #### New Contributors - [@​nielsdos](https://github.com/nielsdos) made their first contribution in [vimeo/psalm#10443 **Full Changelog**: vimeo/psalm@5.16.0...5.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/php-sdk). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Tom Carrio <tom@carrio.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10068 added
isset()restrictions that didn't consider null coalesces on match expressions.This restores that support by converting the match expression to a virtual variable for the isset analysis, similar to other incompatible expressions.