-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if argument passed to isset() is not a variable #10068
Conversation
@Nitamet thanks for your effort. Please target Apparently, this needs some more work, so I've marked this PR as a draft. Mark it as |
And I thought that running composer tests was enough 💀 |
You need to rebase your changes on top of |
b7b21cd
to
f742af0
Compare
I've added other valid statements and changed the branch, tests seem to be ok now, the failed one is not related to this PR. There's a little issue related to null coalescing operator though class Foo {
public const BAR = 'bar';
}
// This works
Foo::BAR ?? "doesn't exist";
// And this crashes
isset(Foo::BAR) ? Foo::BAR : "doesn't exist";
$var = 0;
// This works
($a =& $var) ?? "hello";
// And this crashes
isset((a =& $var)) ? (a =& $var) : "hello"; So if we don't add |
Sounds good to me. |
Thanks! |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [google/protobuf](https://developers.google.com/protocol-buffers/) ([source](https://github.com/protocolbuffers/protobuf-php)) | require | minor | `3.23.4` -> `3.24.1` | | [grpc/grpc](https://grpc.io) ([source](https://github.com/grpc/grpc-php)) | require | minor | `1.52.0` -> `1.57.0` | | [phpstan/phpstan](https://github.com/phpstan/phpstan) | require-dev | patch | `1.10.27` -> `1.10.29` | | [phpunit/phpunit](https://phpunit.de/) ([source](https://github.com/sebastianbergmann/phpunit)) | require-dev | patch | `10.3.1` -> `10.3.2` | | [vimeo/psalm](https://github.com/vimeo/psalm) | require-dev | minor | `5.14.1` -> `5.15.0` | --- ### Release Notes <details> <summary>protocolbuffers/protobuf-php (google/protobuf)</summary> ### [`v3.24.1`](https://github.com/protocolbuffers/protobuf-php/compare/v3.24.0...v3.24.1) [Compare Source](https://github.com/protocolbuffers/protobuf-php/compare/v3.24.0...v3.24.1) ### [`v3.24.0`](https://github.com/protocolbuffers/protobuf-php/compare/v3.23.4...v3.24.0) [Compare Source](https://github.com/protocolbuffers/protobuf-php/compare/v3.23.4...v3.24.0) </details> <details> <summary>grpc/grpc-php (grpc/grpc)</summary> ### [`v1.57.0`](https://github.com/grpc/grpc-php/compare/v1.52.0...v1.57.0) [Compare Source](https://github.com/grpc/grpc-php/compare/v1.52.0...v1.57.0) </details> <details> <summary>phpstan/phpstan (phpstan/phpstan)</summary> ### [`v1.10.29`](https://github.com/phpstan/phpstan/releases/tag/1.10.29) [Compare Source](https://github.com/phpstan/phpstan/compare/1.10.28...1.10.29) # Improvements 🔧 - Update nikic/php-parser to v4.17.1 - PHP 8.3 features are no longer parse errors. Full-fledged PHP 8.3 support is coming later this year. - Update BetterReflection to 6.12.0 # Bugfixes 🐛 - PHPStan Pro - when launching, `PHP_BINARY` needs to be escaped (phpstan/phpstan-src@2c7cfd8) # Function signature fixes 🤖 - Fix FTP-related function signatures ([#​2551](https://github.com/phpstan/phpstan-src/pull/2551)), thanks [@​thg2k](https://github.com/thg2k)! ### [`v1.10.28`](https://github.com/phpstan/phpstan/releases/tag/1.10.28) [Compare Source](https://github.com/phpstan/phpstan/compare/1.10.27...1.10.28) # Improvements 🔧 - Update BetterReflection to 6.12.0 (phpstan/phpstan-src@7c49c94) # Bugfixes 🐛 - Nullsafe operator on `null` results in `null` (phpstan/phpstan-src@5c40c85), [#​9721](https://github.com/phpstan/phpstan/issues/9721) - Properties set in the native constructor are initialized in additional constructors (phpstan/phpstan-src@1b0c6a0), [#​9619](https://github.com/phpstan/phpstan/issues/9619) - Fix performance problem with nested BooleanOr and BooleanAnd (phpstan/phpstan-src@9adae6c), [#​9690](https://github.com/phpstan/phpstan/issues/9690), [#​9676](https://github.com/phpstan/phpstan/issues/9676) - CallableTypeHelper - copy variadic parameters if the accepting closure has more parameters (phpstan/phpstan-src@31ed326), [#​9699](https://github.com/phpstan/phpstan/issues/9699) # Internals 🔍 - Simplify access to ClassReflection in ClassPropertyNode ([#​2565](https://github.com/phpstan/phpstan-src/pull/2565)), thanks [@​mad-briller](https://github.com/mad-briller)! </details> <details> <summary>sebastianbergmann/phpunit (phpunit/phpunit)</summary> ### [`v10.3.2`](https://github.com/sebastianbergmann/phpunit/compare/10.3.1...10.3.2) [Compare Source](https://github.com/sebastianbergmann/phpunit/compare/10.3.1...10.3.2) </details> <details> <summary>vimeo/psalm (vimeo/psalm)</summary> ### [`v5.15.0`](https://github.com/vimeo/psalm/releases/tag/5.15.0) [Compare Source](https://github.com/vimeo/psalm/compare/5.14.1...5.15.0) <!-- Release notes generated using configuration in .github/release.yml at 5.x --> #### What's Changed ##### Features - Check if argument passed to isset() is not a variable by [@​Nitamet](https://github.com/Nitamet) in [vimeo/psalm#10068 - Fix [#​9997](https://github.com/vimeo/psalm/issues/9997) dynamic properties on SimpleXmlElement by [@​ygottschalk](https://github.com/ygottschalk) in [vimeo/psalm#10049 - Nicer PHP version checking by [@​Nitamet](https://github.com/Nitamet) in [vimeo/psalm#10129 ##### Fixes - Fixed `DOMDocument::load*` signatures by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10073 - make (s)printf error reporting more correct/literal by [@​kkmuffme](https://github.com/kkmuffme) in [vimeo/psalm#10088 - Fix parameter having `object` type in PHPDoc and only `&` in the method's definition, used with code having an object calling it's method with itself as an argument for mentioned parameter by [@​kubawerlos](https://github.com/kubawerlos) in [vimeo/psalm#10104 - mysqli_field_seek returns true by [@​kamil-tekiela](https://github.com/kamil-tekiela) in [vimeo/psalm#10107 - Fix bcdiv nullable scale stub by [@​TheDevick](https://github.com/TheDevick) in [vimeo/psalm#10106 - Cleanup `test` command and `fixAll` action by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10108 - Correct type for `$enum->name` by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10109 - argv and argc were inconsistent in Context with VariableFetchAnalyzer by [@​kkmuffme](https://github.com/kkmuffme) in [vimeo/psalm#10093 - Fix `hash_pbkdf2` `$options` parameter by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10110 - Forbid faulty `nikic/php-parser` version by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10112 - `strip_tags()/$allowed_tags` can accept arrays since 7.4 by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10122 - Fix crash when assertion array is not a list by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10123 - Fix crash on array access to undefined class by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10134 - Correct exit code for invalid version format by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10135 #### New Contributors - [@​Nitamet](https://github.com/Nitamet) made their first contribution in [vimeo/psalm#10068 - [@​TheDevick](https://github.com/TheDevick) made their first contribution in [vimeo/psalm#10106 **Full Changelog**: vimeo/psalm@5.14.1...5.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos-sdk-php). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vimeo/psalm](https://github.com/vimeo/psalm) | require-dev | minor | `~5.14.0` -> `~5.15.0` | --- ### Release Notes <details> <summary>vimeo/psalm (vimeo/psalm)</summary> ### [`v5.15.0`](https://github.com/vimeo/psalm/releases/tag/5.15.0) [Compare Source](https://github.com/vimeo/psalm/compare/5.14.1...5.15.0) <!-- Release notes generated using configuration in .github/release.yml at 5.x --> #### What's Changed ##### Features - Check if argument passed to isset() is not a variable by [@​Nitamet](https://github.com/Nitamet) in [vimeo/psalm#10068 - Fix [#​9997](https://github.com/vimeo/psalm/issues/9997) dynamic properties on SimpleXmlElement by [@​ygottschalk](https://github.com/ygottschalk) in [vimeo/psalm#10049 - Nicer PHP version checking by [@​Nitamet](https://github.com/Nitamet) in [vimeo/psalm#10129 ##### Fixes - Fixed `DOMDocument::load*` signatures by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10073 - make (s)printf error reporting more correct/literal by [@​kkmuffme](https://github.com/kkmuffme) in [vimeo/psalm#10088 - Fix parameter having `object` type in PHPDoc and only `&` in the method's definition, used with code having an object calling it's method with itself as an argument for mentioned parameter by [@​kubawerlos](https://github.com/kubawerlos) in [vimeo/psalm#10104 - mysqli_field_seek returns true by [@​kamil-tekiela](https://github.com/kamil-tekiela) in [vimeo/psalm#10107 - Fix bcdiv nullable scale stub by [@​TheDevick](https://github.com/TheDevick) in [vimeo/psalm#10106 - Cleanup `test` command and `fixAll` action by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10108 - Correct type for `$enum->name` by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10109 - argv and argc were inconsistent in Context with VariableFetchAnalyzer by [@​kkmuffme](https://github.com/kkmuffme) in [vimeo/psalm#10093 - Fix `hash_pbkdf2` `$options` parameter by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10110 - Forbid faulty `nikic/php-parser` version by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10112 - `strip_tags()/$allowed_tags` can accept arrays since 7.4 by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10122 - Fix crash when assertion array is not a list by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10123 - Fix crash on array access to undefined class by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10134 - Correct exit code for invalid version format by [@​weirdan](https://github.com/weirdan) in [vimeo/psalm#10135 #### New Contributors - [@​Nitamet](https://github.com/Nitamet) made their first contribution in [vimeo/psalm#10068 - [@​TheDevick](https://github.com/TheDevick) made their first contribution in [vimeo/psalm#10106 **Full Changelog**: vimeo/psalm@5.14.1...5.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/php-sdk). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40My4yIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
vimeo#10068 added isset restrictions that didn't consider null coalesces on match expressions. This restores that support by converting it to a virtual variable for the isset analysis too.
vimeo#10068 added isset restrictions that didn't consider null coalesces on match expressions. This restores that support by converting the match expression to a virtual variable for the isset analysis, similar to other incompatible expressions.
Added the condition to IssetAnalyzer to emit the issue when anything other than a variable is passed to isset()
Fixes #9949